Skip to contentSkip to conversation

perf top: Lower message level for failure on synthesizing events for pre-existing BPF programs

tip:perf/core tip-bot for Arnaldo Carvalho de Melo 1 participant 1 message May 30, 2019 perf events

lore
Share & tools
lore
#0 lore raw
Commit-ID:  2d45ef7033ec90104ae8e4c3996227bdad24dc76
Gitweb:     https://git.kernel.org/tip/2d45ef7033ec90104ae8e4c3996227bdad24dc76
Author:     Arnaldo Carvalho de Melo <[email protected]>
AuthorDate: Mon, 20 May 2019 11:04:08 -0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 28 May 2019 18:37:45 -0300

perf top: Lower message level for failure on synthesizing events for pre-existing BPF programs

Move it from being a pr_warning() to a pr_debug(). Also capitalize BPF and explain what gets missing when we're not able to synthesize these
events: we'll not be able to resolve symbols, etc.

Cc Adrian Hunter <[email protected]>
Cc Alexei Starovoitov <[email protected]>
Cc Andrii Nakryiko <[email protected]>
Cc Daniel Borkmann <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Luis Cláudio Gonçalves <[email protected]>
Cc Martin KaFai Lau <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Song Liu <[email protected]>
Cc Wang Nan <[email protected]>
Cc Yonghong Song <[email protected]>
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-top.c +1 -1
index 31d78d874fc7..6651377fd762 100644
@@ -1215,7 +1215,7 @@ static int __cmd_top(struct perf_top *top)
 						&top->session->machines.host,
 						&top->record_opts);
 	if (ret < 0)
-		pr_warning("Couldn't synthesize bpf events.\n");
+		pr_debug("Couldn't synthesize BPF events: Pre-existing BPF programs won't have symbols resolved.\n");
 
 	machine__synthesize_threads(&top->session->machines.host, &opts->target,
 				    top->evlist->threads, false,