Skip to contentSkip to conversation

firedtv: fix printk format mismatch

PATCH In review Stefan Richter 2 participants 2 messages Mar 5, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firedtv: fix printk format mismatch

Eliminate
drivers/media/dvb/firewire/firedtv-avc.c: In function 'debug_fcp':
drivers/media/dvb/firewire/firedtv-avc.c:156: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'

---

Mauro, if you don't mind I queue it up in linux1394-2.6.git for after 2.6.29, before 2.6.30-rc1. There may be firewire subsystem related changes of firedtv coming together until then.

 drivers/media/dvb/firewire/firedtv-avc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/dvb/firewire/firedtv-avc.c +2 -2
Index: linux/drivers/media/dvb/firewire/firedtv-avc.c
===================================================================
@@ -115,7 +115,7 @@ static const char *debug_fcp_ctype(unsig
 }
 
 static const char *debug_fcp_opcode(unsigned int opcode,
-				    const u8 *data, size_t length)
+				    const u8 *data, int length)
 {
 	switch (opcode) {
 	case AVC_OPCODE_VENDOR:			break;
@@ -141,7 +141,7 @@ static const char *debug_fcp_opcode(unsi
 	return "Vendor";
 }
 
-static void debug_fcp(const u8 *data, size_t length)
+static void debug_fcp(const u8 *data, int length)
 {
 	unsigned int subunit_type, subunit_id, op;
 	const char *prefix = data[0] > 7 ? "FCP <- " : "FCP -> ";
Signature · 3 lines
Stefan Richter
-=====-==--= --== --=-=
http://arcgraph.de/sr/
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · On Thu, 5 Mar 2009 19:13:43 +0100 (CET) Stefan Richter…

Eliminate
drivers/media/dvb/firewire/firedtv-avc.c: In function 'debug_fcp':
drivers/media/dvb/firewire/firedtv-avc.c:156: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'

Quoted 5 lines

---

Mauro, if you don't mind I queue it up in linux1394-2.6.git for after 2.6.29, before 2.6.30-rc1. There may be firewire subsystem related changes of firedtv coming together until then.

Seems fine for me.

Quoted 19 lines
 drivers/media/dvb/firewire/firedtv-avc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/media/dvb/firewire/firedtv-avc.c
===================================================================

drivers/media/dvb/firewire/firedtv-avc.c +1 -1
@@ -115,7 +115,7 @@ static const char *debug_fcp_ctype(unsig
 }
 
 static const char *debug_fcp_opcode(unsigned int opcode,
-				    const u8 *data, size_t length)
+				    const u8 *data, int length)
 {
 	switch (opcode) {
 	case AVC_OPCODE_VENDOR:			break;

drivers/media/dvb/firewire/firedtv-avc.c static const char *debug_fcp_opcode(unsi · line 147

Quoted 8 lines
drivers/media/dvb/firewire/firedtv-avc.c +1 -1
@@ -141,7 +141,7 @@ static const char *debug_fcp_opcode(unsi
 	return "Vendor";
 }
 
-static void debug_fcp(const u8 *data, size_t length)
+static void debug_fcp(const u8 *data, int length)
 {
 	unsigned int subunit_type, subunit_id, op;
 	const char *prefix = data[0] > 7 ? "FCP <- " : "FCP -> ";

Cheers,
Mauro