Skip to contentSkip to conversation

ieee1394: sbp2: convert from PCI DMA to generic DMA

PATCH New Stefan Richter 1 participant 1 message Nov 22, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ieee1394: sbp2: convert from PCI DMA to generic DMA

ieee1394: sbp2: convert from PCI DMA to generic DMA

API conversion without change in functionality

---

Todo:
- Collaps all management ORB DMAs into one block. They can probably even be compressed into a union.
- Use streaming DMA instead of coherent DMA for ORB DMAs.
- Take a target's Unit_Characteristics.ORB_size into account.
- Collaps the command ORB DMAs into one block.
- Convert ieee1394 from PCI DMA to generic DMA too, thus elimiate its dependency on CONFIG_PCI.

 drivers/ieee1394/Kconfig |    2
 drivers/ieee1394/sbp2.c  |  126 ++++++++++++++++++---------------------
 drivers/ieee1394/sbp2.h  |    2
 3 files changed, 62 insertions(+), 68 deletions(-)
drivers/ieee1394/Kconfig +1 -1
Index: linux/drivers/ieee1394/Kconfig
===================================================================
@@ -120,7 +120,7 @@ comment "SBP-2 support (for storage devi
 
 config IEEE1394_SBP2
 	tristate "SBP-2 support (Harddisks etc.)"
-	depends on IEEE1394 && SCSI && (PCI || BROKEN)
+	depends on IEEE1394 && SCSI
 	help
 	  This option enables you to use SBP-2 devices connected to an IEEE
 	  1394 bus.  SBP-2 devices include storage devices like harddisks and
drivers/ieee1394/sbp2.c +60 -66

278 lines not on this page · raw message

drivers/ieee1394/sbp2.h +1 -1
Index: linux/drivers/ieee1394/sbp2.h
===================================================================
@@ -263,7 +263,7 @@ struct sbp2_command_info {
 	dma_addr_t cmd_dma;
 	enum sbp2_dma_types dma_type;
 	unsigned long dma_size;
-	int dma_dir;
+	enum dma_data_direction dma_dir;
 };
 
 /* Per FireWire host */
Signature · 3 lines
Stefan Richter
-=====-=-==- =-== =-==-
http://arcgraph.de/sr/