Skip to contentSkip to conversation

driver core: properly get driver in device_release_driver

PATCH New Stefan Richter 1 participant 2 messages Jun 17, 2007 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver core: properly get driver in device_release_driver

---
 drivers/base/dd.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/base/dd.c +1 -2
Index: linux-2.6.22-rc3/drivers/base/dd.c
===================================================================
@@ -309,9 +309,8 @@ static void __device_release_driver(stru
 {
 	struct device_driver * drv;
 
-	drv = dev->driver;
+	drv = get_driver(dev->driver);
 	if (drv) {
-		get_driver(drv);
 		driver_sysfs_remove(dev);
 		sysfs_remove_link(&dev->kobj, "driver");
 		klist_remove(&dev->knode_driver);
Signature · 3 lines
Stefan Richter
-=====-=-=== -==- =---=
http://arcgraph.de/sr/
#1 lore raw

PATCH 1/1 driver core: fix kernel doc of device_release_driver

---
 drivers/base/dd.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/base/dd.c +9 -9
Index: linux-2.6.22-rc3/drivers/base/dd.c
===================================================================
@@ -294,17 +294,10 @@ int driver_attach(struct device_driver *
 	return bus_for_each_dev(drv->bus, NULL, drv, __driver_attach);
 }
 
-/**
- *	device_release_driver - manually detach device from driver.
- *	@dev:	device.
- *
- *	Manually detach device from driver.
- *
+/*
  *	__device_release_driver() must be called with @dev->sem held.
- *	When called for a USB interface, @dev->parent->sem must be held
- *	as well.
+ *	When called for a USB interface, @dev->parent->sem must be held as well.
  */
-
 static void __device_release_driver(struct device * dev)
 {
 	struct device_driver * drv;
@@ -330,6 +323,13 @@ static void __device_release_driver(stru
 	}
 }
 
+/**
+ *	device_release_driver - manually detach device from driver.
+ *	@dev:	device.
+ *
+ *	Manually detach device from driver.
+ *	When called for a USB interface, @dev->parent->sem must be held.
+ */
 void device_release_driver(struct device * dev)
 {
 	/*
Signature · 3 lines
Stefan Richter
-=====-=-=== -==- =---=
http://arcgraph.de/sr/