patch: s2255drv driver removal problem fixed
From: Dean Anderson <[email protected]>
This patch fixes kfree problem on driver removal, fixes streamoff problem and removes unnecessary videobuf_waiton from free_buffer function.
Signed-off-by Dean Anderson <[email protected]>
drivers/media/video/s2255drv.c renamed from drivers/media/video/s2255drv.c.orig +2 -6
@@ -723,7 +723,6 @@ {dprintk (4 ,"%s\n" , __func__); -videobuf_waiton (&buf->vb,0 ,0 );videobuf_vmalloc_free (&buf->vb); buf->vb.state =VIDEOBUF_NEEDS_INIT ; }
@@ -1325,7 +1324,6 @@static int vidioc_streamoff (struct file *file,void *priv,enum v4l2_buf_type i) { -int res;struct s2255_fh *fh = priv;struct s2255_dev *dev = fh->dev;
@@ -1339,9 +1337,7 @@return -EINVAL ; }s2255_stop_acquire (dev, fh->channel); - res =videobuf_streamoff (&fh->vb_vidq); -if (res <0 ) -return res; +videobuf_streamoff (&fh->vb_vidq);res_free (dev, fh);return 0 ; }
@@ -1708,13 +1704,13 @@kfree (dev->fw_data);usb_put_dev (dev->udev);dprintk (1 ,"%s" , __func__); -kfree (dev);while (!list_empty (&s2255_devlist)) { list = s2255_devlist.next;list_del (list); }mutex_unlock (&dev->open_lock); +kfree (dev); }static int s2255_close (struct file *file)
--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list