Skip to contentSkip to conversation

drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)

linux Daniel Vetter 3 participants 3 messages Jan 31, 2016 – Feb 1, 2016 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): torvalds/linux/commit/[email protected]

A message that is not in the archive (sent off-list or not yet received): torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1/[email protected]

#2 lore raw

It's a github comment so pretty hopeless to follow up with the reporter, but it sounds like we have a culprit for the ilk wm issues/fifo underruns. -Daniel

---------- Forwarded message ----------
From: Manfred G Kitzbichler <[email protected]>
Date: Sat, Jan 30, 2016 at 5:42 AM
Subject: Re: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)
To: torvalds/linux <[email protected]>
Cc: Daniel Vetter <[email protected]>

As stated above, this commit introduced a screen flicker regression. Please fix asap!

(cf.
http://cgit.freedesktop.org/drm-intel/commit/?id=54da691deb123c045259ebf4f5c67381244f58f1
)

—
Reply to this email directly or view it on GitHub
<https://github.com/torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1#commitcomment-15780006>
.

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 3 lines · Daniel Vetter

It's a github comment so pretty hopeless to follow up with the reporter, but it sounds like we have a culprit for the ilk wm issues/fifo underruns.

https://bugs.freedesktop.org/show_bug.cgi?id=93892

BR,
Jani.

Quoted 22 lines

-Daniel

---------- Forwarded message ----------
From: Manfred G Kitzbichler <[email protected]>
Date: Sat, Jan 30, 2016 at 5:42 AM
Subject: Re: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)
To: torvalds/linux <[email protected]>
Cc: Daniel Vetter <[email protected]>

As stated above, this commit introduced a screen flicker regression. Please fix asap!

(cf.
http://cgit.freedesktop.org/drm-intel/commit/?id=54da691deb123c045259ebf4f5c67381244f58f1
)

—
Reply to this email directly or view it on GitHub
<https://github.com/torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1#commitcomment-15780006>
.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
In reply to Daniel Vetter
Quoted 3 lines · Daniel Vetter

It's a github comment so pretty hopeless to follow up with the reporter, but it sounds like we have a culprit for the ilk wm issues/fifo underruns. -Daniel

I think this is the flickering regression that we expected to come back when we reverted the two-step watermarks. Resurrecting a much earlier workaround that we lost should help prevent the user-visible problems in the short term; I just sent a patch for that.

I'm traveling, so I haven't seen any IRC discussion that may have happened recently, but I believe the CI regression we saw on that final two-step watermark patch are still unsolved. But since we've already reverted that patch, they shouldn't be blocking anything, right?

Matt

Quoted 28 lines

---------- Forwarded message ----------
From: Manfred G Kitzbichler <[email protected]>
Date: Sat, Jan 30, 2016 at 5:42 AM
Subject: Re: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)
To: torvalds/linux <[email protected]>
Cc: Daniel Vetter <[email protected]>

As stated above, this commit introduced a screen flicker regression. Please fix asap!

(cf.
http://cgit.freedesktop.org/drm-intel/commit/?id=54da691deb123c045259ebf4f5c67381244f58f1
)

—
Reply to this email directly or view it on GitHub
<https://github.com/torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1#commitcomment-15780006>
.

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Signature · 9 lines
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx