Skip to contentSkip to conversation

RFC: [2.6 patch] better i386 CPU selection

DISCUSSION Andi Kleen 2 participants 2 messages Sep 14, 2003 6 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#6 lore raw
Quoted 4 lines · Adrian Bunk

I don't like the current user interface that says "if you want to support both an Athlon and a Pentium 4 in your kernel use the Pentium III option. And for better optimization, also check the "generic" option".

The big issue with your ifdefing of workarounds is that it causes subtle support problems. A lot of settings for specific CPUs boot and work fine on other CPUs (possibly with small performance impact, but they're rarely noticeable without explicit benchmarking). Just when you don't include the workarounds for the bugs on these other CPUs it will boot and even run, but fail mysteriously once a month. And that would be a support nightmare.

-Andi

#7 lore raw
Quoted 6 lines · Andi Kleen
Quoted 4 lines · Adrian Bunk

I don't like the current user interface that says "if you want to support both an Athlon and a Pentium 4 in your kernel use the Pentium III option. And for better optimization, also check the "generic" option".

Quoted 8 lines

The big issue with your ifdefing of workarounds is that it causes subtle support problems. A lot of settings for specific CPUs boot and work fine on other CPUs (possibly with small performance impact, but they're rarely noticeable without explicit benchmarking). Just when you don't include the workarounds for the bugs on these other CPUs it will boot and even run, but fail mysteriously once a month. And that would be a support nightmare.

it sounds like a nessasary part of this patch would be to detect the CPU type and complain VERY loudly if it's not one supported by the build.

This is probably a good idea anyway.

David Lang