Skip to contentSkip to conversation

-W -Wno-unused -Wno-sign-compare compile flags

DISCUSSION [email protected] 4 participants 4 messages Oct 29, 2006

lore
Share & tools
lore
#0 lore raw

Hello !linux-kernel

Does anybody try to compile latest linux-kernel with -W -Wno-unused -Wno-sign-compare CFLAGS? There is a tons of warnings :(
Recent versions of grsecurity patches adds this flags to default. When I asked to grsec developers, why did they do that, they answered: to show, how messy linux code is... Is there any objections about it?

#1 lore raw
Quoted 8 lines · someone from

Hello !linux-kernel

Does anybody try to compile latest linux-kernel with -W -Wno-unused -Wno-sign-compare CFLAGS? There is a tons of warnings :(
Recent versions of grsecurity patches adds this flags to default. When I asked to grsec developers, why did they do that, they answered: to show, how messy linux code is...

Yes, it is. You are welcome to fix it.
____

#2 lore raw
In reply to [email protected]
Quoted 9 lines · On Sun, 29 Oct 2006 17:22:48 +0300, [email protected] said:

Hello !linux-kernel

Does anybody try to compile latest linux-kernel with -W -Wno-unused -Wno-sign-compare CFLAGS? There is a tons of warnings :(
Recent versions of grsecurity patches adds this flags to default. When I asked to grsec developers, why did they do that, they answered: to show, how messy linux code is... Is there any objections about it?

I'd recommend attacking this one flag at a time - so for instance, do up a series of patches that cleans up the -Wno-unused warnings, and get that merged. Then get a series for -Wno-sign-compare, and finally a patch that adds -W.

While you're at it, look at these flags as well:

-Werror-implicit-function-declaration -Wcomment -Wendif-labels -Wshadow

(The tree is pretty clean for the first 3, cleaning it for the last will take some work...)

#3 lore raw
In reply to [email protected]
Quoted 9 lines · On Sun, Oct 29, 2006 at 05:22:48PM +0300, [email protected] wrote:

Hello !linux-kernel

Does anybody try to compile latest linux-kernel with -W -Wno-unused -Wno-sign-compare CFLAGS? There is a tons of warnings :(
Recent versions of grsecurity patches adds this flags to default. When I asked to grsec developers, why did they do that, they answered: to show, how messy linux code is... Is there any objections about it?

-W gives many warnings, some of them indicate possible improvements while some of them warn about things that are perfectly OK.

While getting such warnings is a task that is sometimes worked on, it's neither realistic nor required to get all warnings with -W fixed.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed