perf tools: Adjust symbols in VDSO

PATCH In review Vladimir Nikulichev 2 participants 2 messages Apr 11, 2014 – Apr 17, 2014 perf events

lore

Share & tools

lore

Vladimir Nikulichev

author

2014-04-11 14:25 UTC #0 lore raw

PATCH 1/1 perf tools: Adjust symbols in VDSO

perf tools: Adjust symbols in VDSO

pert-report doesn't resolve function names in VDSO:

$ perf report --stdio -g flat,0.0,15,callee --sort pid
...
            8.76%
               0x7fff6b1fe861
               __gettimeofday
               ACE_OS::gettimeofday()
...

In this case symbol values should be adjusted the same way as for executables, relocatable objects and prelinked libraries.

After fix:

$ perf report --stdio -g flat,0.0,15,callee --sort pid
...
            8.76%
               __vdso_gettimeofday
               __gettimeofday
               ACE_OS::gettimeofday()

Signed-off-by Vladimir Nikulichev <[email protected]>

tools/perf/util/symbol-elf.c +0 -0

index 3b7dbf5..6864661 100644
@@ -6,6 +6,7 @@

#include <inttypes.h>

#include "symbol.h"
+#include "vdso.h"
#include <symbol/kallsyms.h>
#include "debug.h"

@@ -618,6 +619,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso, const char *name,

		GElf_Shdr shdr;
		ss->adjust_symbols = (ehdr.e_type == ET_EXEC ||
				ehdr.e_type == ET_REL ||
+				is_vdso_map(dso->short_name) ||
				elf_section_by_name(elf, &ehdr, &shdr,
						     ".gnu.prelink_undo",
						     NULL) != NULL);

Adrian Hunter

reviewer Reviewed-by on v1 1/1

2014-04-17 08:47 UTC #1 lore raw

Quoted 17 lines · Vladimir Nikulichev

perf tools: Adjust symbols in VDSO
pert-report doesn't resolve function names in VDSO:
$ perf report --stdio -g flat,0.0,15,callee --sort pid
...
            8.76%
               0x7fff6b1fe861
               __gettimeofday
               ACE_OS::gettimeofday()
...
In this case symbol values should be adjusted the same way as for executables, relocatable objects and prelinked libraries.
After fix:

Quoted 8 lines

$ perf report --stdio -g flat,0.0,15,callee --sort pid
...
            8.76%
               __vdso_gettimeofday
               __gettimeofday
               ACE_OS::gettimeofday()

Signed-off-by Vladimir Nikulichev <[email protected]>

Annotation still doesn't work. but this is a start, so:

Reviewed-by Adrian Hunter <[email protected]>

Quoted 22 lines

tools/perf/util/symbol-elf.c +2 -0

index 3b7dbf5..6864661 100644
@@ -6,6 +6,7 @@
 #include <inttypes.h>
 
 #include "symbol.h"
+#include "vdso.h"
 #include <symbol/kallsyms.h>
 #include "debug.h"

@@ -618,6 +619,7 @@ int symsrc__init(struct symsrc *ss, struct dso *dso,
 const char *name,
        GElf_Shdr shdr;
        ss->adjust_symbols = (ehdr.e_type == ET_EXEC ||
                ehdr.e_type == ET_REL ||
+                is_vdso_map(dso->short_name) ||
                elf_section_by_name(elf, &ehdr, &shdr,
                             ".gnu.prelink_undo",

                             NULL) != NULL);