Skip to contentSkip to conversation

OUTPUT and TEST_CUSTOM_PROGS

DISCUSSION Yauheni Kaliuta 2 participants 2 messages May 25, 2020 – May 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

lib.mk expects TEST_GEN_PROGS, TEST_GEN_PROGS_EXTENDED and TEST_GEN_FILES to be in local directory and tries to handle out of tree build adding OUTPUT to it at the beginning.

commit be16a244c199 ("selftests: lib.mk: add TEST_CUSTOM_PROGS to allow custom test run/install") adds TEST_CUSTOM_PROGS but it handles it differently. Should it add OUTPUT as well?

Signature · 2 lines
WBR,
Yauheni Kaliuta
maintainer
#1 lore raw
Quoted 10 lines · Yauheni Kaliuta

Hi!

lib.mk expects TEST_GEN_PROGS, TEST_GEN_PROGS_EXTENDED and TEST_GEN_FILES to be in local directory and tries to handle out of tree build adding OUTPUT to it at the beginning.

commit be16a244c199 ("selftests: lib.mk: add TEST_CUSTOM_PROGS to allow custom test run/install") adds TEST_CUSTOM_PROGS but it handles it differently. Should it add OUTPUT as well?

Individual tests apply OUTPUT to TEST_CUSTOM_PROGS. lib.mk rules can't build TEST_CUSTOM_PROGS and it is left up to tests to handle them as custom.

So no on adding OUTPUT to TEST_CUSTOM_PROGS in lib.mk.

thanks,
-- Shuah