Skip to contentSkip to conversation

watchdog: Remove unnecessary OOM messages

PATCH In review Jingoo Han 7 participants 16 messages Feb 11, 2014 – Feb 24, 2014

Subsystems (5)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

cover watchdog: Remove unnecessary OOM messages

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack().

Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages

---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 drivers/watchdog/bcm2835_wdt.c    |    4 +---
 drivers/watchdog/da9052_wdt.c     |    1 -
 drivers/watchdog/da9055_wdt.c     |    4 +---
 drivers/watchdog/pcwd_usb.c       |    4 +---
 drivers/watchdog/sp805_wdt.c      |    1 -
 drivers/watchdog/ts72xx_wdt.c     |    6 ++----
 drivers/watchdog/wm831x_wdt.c     |    1 -
 8 files changed, 6 insertions(+), 19 deletions(-)
author
#1 lore raw

PATCH 1/8 watchdog: at32ap700x: Remove unnecessary OOM messages

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/at32ap700x_wdt.c +1 -3
index afe7d17..25b5c67 100644
@@ -323,10 +323,8 @@ static int __init at32_wdt_probe(struct platform_device *pdev)
 
 	wdt = devm_kzalloc(&pdev->dev, sizeof(struct wdt_at32ap700x),
 			GFP_KERNEL);
-	if (!wdt) {
-		dev_dbg(&pdev->dev, "no memory for wdt structure\n");
+	if (!wdt)
 		return -ENOMEM;
-	}
 
 	wdt->regs = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
 	if (!wdt->regs) {
Signature · 1 line
1.7.10.4
Reviewed-by on v1 1/8
#2 lore raw

Re: [PATCH 1/8] watchdog: at32ap700x: Remove unnecessary OOM messages

Quoted 14 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/at32ap700x_wdt.c +0 -0
index afe7d17..25b5c67 100644
@@ -323,10 +323,8 @@ static int __init at32_wdt_probe(struct platform_device *pdev)
 

drivers/watchdog/at32ap700x_wdt.c static int __init at32_wdt_probe(struct platform_device *pdev) · line 330

Quoted 10 lines
drivers/watchdog/at32ap700x_wdt.c +1 -3
 	wdt = devm_kzalloc(&pdev->dev, sizeof(struct wdt_at32ap700x),
 			GFP_KERNEL);
-	if (!wdt) {
-		dev_dbg(&pdev->dev, "no memory for wdt structure\n");
+	if (!wdt)
 		return -ENOMEM;
-	}
 
 	wdt->regs = devm_ioremap(&pdev->dev, regs->start, resource_size(regs));
 	if (!wdt->regs) {
Signature · 2 lines
Jean Delvare
Suse L3 Support
author
#3 lore raw

PATCH 2/8 watchdog: bcm2835: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/bcm2835_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/bcm2835_wdt.c +1 -3
index cafa973..8df450c 100644
@@ -114,10 +114,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
 	int err;
 
 	wdt = devm_kzalloc(dev, sizeof(struct bcm2835_wdt), GFP_KERNEL);
-	if (!wdt) {
-		dev_err(dev, "Failed to allocate memory for watchdog device");
+	if (!wdt)
 		return -ENOMEM;
-	}
 	platform_set_drvdata(pdev, wdt);
 
 	spin_lock_init(&wdt->lock);
Signature · 1 line
1.7.10.4
Acked-by on v1 2/8
#4 lore raw

Re: [PATCH 2/8] watchdog: bcm2835: Remove unnecessary OOM messages

Quoted 4 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

Quoted 20 lines
---
 drivers/watchdog/bcm2835_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/bcm2835_wdt.c +1 -3
index cafa973..8df450c 100644
@@ -114,10 +114,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
 	int err;
 
 	wdt = devm_kzalloc(dev, sizeof(struct bcm2835_wdt), GFP_KERNEL);
-	if (!wdt) {
-		dev_err(dev, "Failed to allocate memory for watchdog device");
+	if (!wdt)
 		return -ENOMEM;
-	}
 	platform_set_drvdata(pdev, wdt);
 
 	spin_lock_init(&wdt->lock);
author
#5 lore raw

PATCH 3/8 watchdog: da9052: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/da9052_wdt.c |    1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/da9052_wdt.c +0 -1
index f09c54e..2e95896 100644
@@ -185,7 +185,6 @@ static int da9052_wdt_probe(struct platform_device *pdev)
 	driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
 				   GFP_KERNEL);
 	if (!driver_data) {
-		dev_err(da9052->dev, "Unable to alloacate watchdog device\n");
 		ret = -ENOMEM;
 		goto err;
 	}
Signature · 1 line
1.7.10.4
author
#6 lore raw

PATCH 4/8 watchdog: da9055: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/da9055_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/da9055_wdt.c +1 -3
index 575f37a..495089d 100644
@@ -151,10 +151,8 @@ static int da9055_wdt_probe(struct platform_device *pdev)
 
 	driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
 				   GFP_KERNEL);
-	if (!driver_data) {
-		dev_err(da9055->dev, "Failed to allocate watchdog device\n");
+	if (!driver_data)
 		return -ENOMEM;
-	}
 
 	driver_data->da9055 = da9055;
 
Signature · 1 line
1.7.10.4
author
#7 lore raw

PATCH 5/8 watchdog: pcwd_usb: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/pcwd_usb.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/pcwd_usb.c +1 -3
index e562e04..1a11aed 100644
@@ -645,10 +645,8 @@ static int usb_pcwd_probe(struct usb_interface *interface,
 
 	/* allocate memory for our device and initialize it */
 	usb_pcwd = kzalloc(sizeof(struct usb_pcwd_private), GFP_KERNEL);
-	if (usb_pcwd == NULL) {
-		pr_err("Out of memory\n");
+	if (usb_pcwd == NULL)
 		goto error;
-	}
 
 	usb_pcwd_device = usb_pcwd;
 
Signature · 1 line
1.7.10.4
author
#8 lore raw

PATCH 6/8 watchdog: sp805_wdt: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/sp805_wdt.c |    1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/sp805_wdt.c +0 -1
index 3f786ce..d7da73e 100644
@@ -218,7 +218,6 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
 
 	wdt = devm_kzalloc(&adev->dev, sizeof(*wdt), GFP_KERNEL);
 	if (!wdt) {
-		dev_warn(&adev->dev, "Kzalloc failed\n");
 		ret = -ENOMEM;
 		goto err;
 	}
Signature · 1 line
1.7.10.4
Acked-by on v1 6/8
#9 lore raw

Re: [PATCH 6/8] watchdog: sp805_wdt: Remove unnecessary OOM messages

Quoted 13 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/sp805_wdt.c |    1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/sp805_wdt.c +0 -0
index 3f786ce..d7da73e 100644

drivers/watchdog/sp805_wdt.c sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id) · line 223

Quoted 7 lines
drivers/watchdog/sp805_wdt.c +0 -1
@@ -218,7 +218,6 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
 
        wdt = devm_kzalloc(&adev->dev, sizeof(*wdt), GFP_KERNEL);
        if (!wdt) {
-               dev_warn(&adev->dev, "Kzalloc failed\n");
                ret = -ENOMEM;
                goto err;
        }
author
#10 lore raw

PATCH 7/8 watchdog: ts72xx_wdt: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/ts72xx_wdt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/ts72xx_wdt.c +1 -3
index 09d4831..6959fa0 100644
@@ -394,10 +394,8 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)
 	int error = 0;
 
 	wdt = devm_kzalloc(&pdev->dev, sizeof(struct ts72xx_wdt), GFP_KERNEL);
-	if (!wdt) {
-		dev_err(&pdev->dev, "failed to allocate memory\n");
+	if (!wdt)
 		return -ENOMEM;
-	}
 
 	r1 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	wdt->control_reg = devm_ioremap_resource(&pdev->dev, r1);
Signature · 1 line
1.7.10.4
author
#12 lore raw

PATCH 8/8 watchdog: wm831x: Remove unnecessary OOM messages

In reply to Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.

---
 drivers/watchdog/wm831x_wdt.c |    1 -
 1 file changed, 1 deletion(-)
drivers/watchdog/wm831x_wdt.c +0 -1
index e243bd0..2fa17e7 100644
@@ -204,7 +204,6 @@ static int wm831x_wdt_probe(struct platform_device *pdev)
 	driver_data = devm_kzalloc(&pdev->dev, sizeof(*driver_data),
 				   GFP_KERNEL);
 	if (!driver_data) {
-		dev_err(wm831x->dev, "Unable to alloacate watchdog device\n");
 		ret = -ENOMEM;
 		goto err;
 	}
Signature · 1 line
1.7.10.4
author
#13 lore raw
In reply to Jingoo Han
Quoted 8 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack().

Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static

There is a mistake. The followings are right.

Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages

Best regards,
Jingoo Han

Quoted 18 lines

watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages

---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 drivers/watchdog/bcm2835_wdt.c    |    4 +---
 drivers/watchdog/da9052_wdt.c     |    1 -
 drivers/watchdog/da9055_wdt.c     |    4 +---
 drivers/watchdog/pcwd_usb.c       |    4 +---
 drivers/watchdog/sp805_wdt.c      |    1 -
 drivers/watchdog/ts72xx_wdt.c     |    6 ++----
 drivers/watchdog/wm831x_wdt.c     |    1 -
 8 files changed, 6 insertions(+), 19 deletions(-)
maintainer Reviewed-by on the v1 series
#14 lore raw
In reply to Jingoo Han
Quoted 4 lines · Jingoo Han

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack().

Quoted 11 lines

Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages

For the series:

#15 lore raw
In reply to Jingoo Han

Hi Jingoo,

Quoted 15 lines

The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack().

Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages

Quoted 11 lines
---
 drivers/watchdog/at32ap700x_wdt.c |    4 +---
 drivers/watchdog/bcm2835_wdt.c    |    4 +---
 drivers/watchdog/da9052_wdt.c     |    1 -
 drivers/watchdog/da9055_wdt.c     |    4 +---
 drivers/watchdog/pcwd_usb.c       |    4 +---
 drivers/watchdog/sp805_wdt.c      |    1 -
 drivers/watchdog/ts72xx_wdt.c     |    6 ++----
 drivers/watchdog/wm831x_wdt.c     |    1 -
 8 files changed, 6 insertions(+), 19 deletions(-)

This has been added as a single patch to linux-watchdog-next.

Kind regards,
Wim.