watchdog: Remove unnecessary OOM messages
Subsystems (5)
cover watchdog: Remove unnecessary OOM messages
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack().
Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: make 'ts72xx_wdt_pdev' static
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages
--- drivers/watchdog/at32ap700x_wdt.c | 4 +--- drivers/watchdog/bcm2835_wdt.c | 4 +--- drivers/watchdog/da9052_wdt.c | 1 - drivers/watchdog/da9055_wdt.c | 4 +--- drivers/watchdog/pcwd_usb.c | 4 +--- drivers/watchdog/sp805_wdt.c | 1 - drivers/watchdog/ts72xx_wdt.c | 6 ++---- drivers/watchdog/wm831x_wdt.c | 1 - 8 files changed, 6 insertions(+), 19 deletions(-)
PATCH 1/8 watchdog: at32ap700x: Remove unnecessary OOM messages
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/at32ap700x_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/at32ap700x_wdt.c +1 -3
@@ -323,10 +323,8 @@ static int __init at32_wdt_probe(struct platform_device *pdev) wdt =devm_kzalloc (&pdev->dev,sizeof (struct wdt_at32ap700x ),GFP_KERNEL ); -if (!wdt) { -dev_dbg (&pdev->dev,"no memory for wdt structure\n" ); +if (!wdt)return -ENOMEM ; - } wdt->regs =devm_ioremap (&pdev->dev, regs->start,resource_size (regs));if (!wdt->regs) {
Signature · 1 line
1.7.10.4
Re: [PATCH 1/8] watchdog: at32ap700x: Remove unnecessary OOM messages
Quoted 14 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>--- drivers/watchdog/at32ap700x_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/watchdog/at32ap700x_wdt.c +0
-0@@ -323,10 +323,8 @@ static int __init at32_wdt_probe(struct platform_device *pdev)
drivers/watchdog/at32ap700x_wdt.c static int __init at32_wdt_probe(struct platform_device *pdev) · line 330
Quoted 10 lines
drivers/watchdog/at32ap700x_wdt.c +1
-3wdt =devm_kzalloc (&pdev->dev,sizeof (struct wdt_at32ap700x ),GFP_KERNEL ); -if (!wdt) { -dev_dbg (&pdev->dev,"no memory for wdt structure\n" ); +if (!wdt)return -ENOMEM ; - } wdt->regs =devm_ioremap (&pdev->dev, regs->start,resource_size (regs));if (!wdt->regs) {
Signature · 2 lines
Jean Delvare Suse L3 Support
PATCH 2/8 watchdog: bcm2835: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/bcm2835_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/bcm2835_wdt.c +1 -3
@@ -114,10 +114,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)int err; wdt =devm_kzalloc (dev,sizeof (struct bcm2835_wdt ),GFP_KERNEL ); -if (!wdt) { -dev_err (dev,"Failed to allocate memory for watchdog device" ); +if (!wdt)return -ENOMEM ; - }platform_set_drvdata (pdev, wdt);spin_lock_init (&wdt->lock);
Signature · 1 line
1.7.10.4
Re: [PATCH 2/8] watchdog: bcm2835: Remove unnecessary OOM messages
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>
Quoted 20 lines
--- drivers/watchdog/bcm2835_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/watchdog/bcm2835_wdt.c +1
-3@@ -114,10 +114,8 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)int err; wdt =devm_kzalloc (dev,sizeof (struct bcm2835_wdt ),GFP_KERNEL ); -if (!wdt) { -dev_err (dev,"Failed to allocate memory for watchdog device" ); +if (!wdt)return -ENOMEM ; - }platform_set_drvdata (pdev, wdt);spin_lock_init (&wdt->lock);
PATCH 3/8 watchdog: da9052: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/da9052_wdt.c | 1 - 1 file changed, 1 deletion(-)
drivers/watchdog/da9052_wdt.c +0 -1
@@ -185,7 +185,6 @@ static int da9052_wdt_probe(struct platform_device *pdev) driver_data =devm_kzalloc (&pdev->dev,sizeof (*driver_data),GFP_KERNEL );if (!driver_data) { -dev_err (da9052->dev,"Unable to alloacate watchdog device\n" ); ret = -ENOMEM ; goto err; }
Signature · 1 line
1.7.10.4
PATCH 4/8 watchdog: da9055: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/da9055_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/da9055_wdt.c +1 -3
@@ -151,10 +151,8 @@ static int da9055_wdt_probe(struct platform_device *pdev) driver_data =devm_kzalloc (&pdev->dev,sizeof (*driver_data),GFP_KERNEL ); -if (!driver_data) { -dev_err (da9055->dev,"Failed to allocate watchdog device\n" ); +if (!driver_data)return -ENOMEM ; - } driver_data->da9055 = da9055;
Signature · 1 line
1.7.10.4
PATCH 5/8 watchdog: pcwd_usb: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/pcwd_usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/pcwd_usb.c +1 -3
@@ -645,10 +645,8 @@ static int usb_pcwd_probe(struct usb_interface *interface,/* allocate memory for our device and initialize it */ usb_pcwd =kzalloc (sizeof (struct usb_pcwd_private ),GFP_KERNEL ); -if (usb_pcwd ==NULL ) { -pr_err ("Out of memory\n" ); +if (usb_pcwd ==NULL ) goto error; - } usb_pcwd_device = usb_pcwd;
Signature · 1 line
1.7.10.4
PATCH 6/8 watchdog: sp805_wdt: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/sp805_wdt.c | 1 - 1 file changed, 1 deletion(-)
drivers/watchdog/sp805_wdt.c +0 -1
@@ -218,7 +218,6 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id) wdt =devm_kzalloc (&adev->dev,sizeof (*wdt),GFP_KERNEL );if (!wdt) { -dev_warn (&adev->dev,"Kzalloc failed\n" ); ret = -ENOMEM ; goto err; }
Signature · 1 line
1.7.10.4
Re: [PATCH 6/8] watchdog: sp805_wdt: Remove unnecessary OOM messages
Quoted 13 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>--- drivers/watchdog/sp805_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/sp805_wdt.c +0
-0
drivers/watchdog/sp805_wdt.c sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id) · line 223
Quoted 7 lines
drivers/watchdog/sp805_wdt.c +0
-1@@ -218,7 +218,6 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id) wdt =devm_kzalloc (&adev->dev,sizeof (*wdt),GFP_KERNEL );if (!wdt) { -dev_warn (&adev->dev,"Kzalloc failed\n" ); ret = -ENOMEM ; goto err; }
PATCH 7/8 watchdog: ts72xx_wdt: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/ts72xx_wdt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/watchdog/ts72xx_wdt.c +1 -3
@@ -394,10 +394,8 @@ static int ts72xx_wdt_probe(struct platform_device *pdev)int error =0 ; wdt =devm_kzalloc (&pdev->dev,sizeof (struct ts72xx_wdt ),GFP_KERNEL ); -if (!wdt) { -dev_err (&pdev->dev,"failed to allocate memory\n" ); +if (!wdt)return -ENOMEM ; - } r1 =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); wdt->control_reg =devm_ioremap_resource (&pdev->dev, r1);
Signature · 1 line
1.7.10.4
Re: [PATCH 7/8] watchdog: ts72xx_wdt: Remove unnecessary OOM messages
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>
PATCH 8/8 watchdog: wm831x: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/watchdog/wm831x_wdt.c | 1 - 1 file changed, 1 deletion(-)
drivers/watchdog/wm831x_wdt.c +0 -1
@@ -204,7 +204,6 @@ static int wm831x_wdt_probe(struct platform_device *pdev) driver_data =devm_kzalloc (&pdev->dev,sizeof (*driver_data),GFP_KERNEL );if (!driver_data) { -dev_err (wm831x->dev,"Unable to alloacate watchdog device\n" ); ret = -ENOMEM ; goto err; }
Signature · 1 line
1.7.10.4
Quoted 8 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use
dump_stack().Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog:ts72xx_wdt: make 'ts72xx_wdt_pdev' static
There is a mistake. The followings are right.
Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog: pcwd_usb: Remove unnecessary OOM messages
watchdog: sp805_wdt: Remove unnecessary OOM messages
watchdog: ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages
Best regards,
Jingoo Han
Quoted 18 lines
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog:pcwd_usb: Remove unnecessary OOM messages
watchdog:sp805_wdt: Remove unnecessary OOM messages
watchdog:ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages--- drivers/watchdog/at32ap700x_wdt.c | 4 +--- drivers/watchdog/bcm2835_wdt.c | 4 +--- drivers/watchdog/da9052_wdt.c | 1 - drivers/watchdog/da9055_wdt.c | 4 +--- drivers/watchdog/pcwd_usb.c | 4 +--- drivers/watchdog/sp805_wdt.c | 1 - drivers/watchdog/ts72xx_wdt.c | 6 ++---- drivers/watchdog/wm831x_wdt.c | 1 - 8 files changed, 6 insertions(+), 19 deletions(-)
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use
dump_stack().
Quoted 11 lines
Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog:ts72xx_wdt: make 'ts72xx_wdt_pdev' static
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog:pcwd_usb: Remove unnecessary OOM messages
watchdog:sp805_wdt: Remove unnecessary OOM messages
watchdog:ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages
For the series:
Hi Jingoo,
Quoted 15 lines
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use
dump_stack().Jingoo Han (8):
watchdog: at32ap700x: Remove unnecessary OOM messages
watchdog:ts72xx_wdt: make 'ts72xx_wdt_pdev' static
watchdog: bcm2835: Remove unnecessary OOM messages
watchdog: da9052: Remove unnecessary OOM messages
watchdog: da9055: Remove unnecessary OOM messages
watchdog:pcwd_usb: Remove unnecessary OOM messages
watchdog:sp805_wdt: Remove unnecessary OOM messages
watchdog:ts72xx_wdt: Remove unnecessary OOM messages
watchdog: wm831x: Remove unnecessary OOM messages
Quoted 11 lines
--- drivers/watchdog/at32ap700x_wdt.c | 4 +--- drivers/watchdog/bcm2835_wdt.c | 4 +--- drivers/watchdog/da9052_wdt.c | 1 - drivers/watchdog/da9055_wdt.c | 4 +--- drivers/watchdog/pcwd_usb.c | 4 +--- drivers/watchdog/sp805_wdt.c | 1 - drivers/watchdog/ts72xx_wdt.c | 6 ++---- drivers/watchdog/wm831x_wdt.c | 1 - 8 files changed, 6 insertions(+), 19 deletions(-)
This has been added as a single patch to linux-watchdog-next.
Kind regards,
Wim.