Skip to contentSkip to conversation

rtc: rtc-puv3: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 3, 2013 Real time clock (RTC)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 40/42 rtc: rtc-puv3: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/rtc/rtc-puv3.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/rtc-puv3.c +0 -1
index 72f4371..402732c 100644
@@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device *dev)
 {
 	struct rtc_device *rtc = platform_get_drvdata(dev);
 
-	platform_set_drvdata(dev, NULL);
 	rtc_device_unregister(rtc);
 
 	puv3_rtc_setpie(&dev->dev, 0);
Signature · 1 line
1.7.2.5
Acked-by on v1 40/42
#1 lore raw
Quoted 6 lines

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Thanks.

Quoted 21 lines
---
 drivers/rtc/rtc-puv3.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/rtc-puv3.c +0 -1
index 72f4371..402732c 100644
@@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device
 *dev)
 {
 	struct rtc_device *rtc = platform_get_drvdata(dev);
 
-	platform_set_drvdata(dev, NULL);
 	rtc_device_unregister(rtc);
 

puv3_rtc_setpie(&dev->dev, 0);
--
1.7.2.5