rtc: rtc-puv3: remove unnecessary platform_set_drvdata()
PATCH 40/42 rtc: rtc-puv3: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/rtc/rtc-puv3.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/rtc-puv3.c +0 -1
@@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device *dev) {struct rtc_device *rtc =platform_get_drvdata (dev); -platform_set_drvdata (dev,NULL );rtc_device_unregister (rtc);puv3_rtc_setpie (&dev->dev,0 );
Signature · 1 line
1.7.2.5
Quoted 6 lines
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Thanks.
Acked-by Guan Xuetao <[email protected]>
Quoted 21 lines
--- drivers/rtc/rtc-puv3.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/rtc/rtc-puv3.c +0
-1@@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device *dev) {struct rtc_device *rtc =platform_get_drvdata (dev); -platform_set_drvdata (dev,NULL );rtc_device_unregister (rtc);
puv3_rtc_setpie(&dev->dev, 0);
--
1.7.2.5