Skip to contentSkip to conversation

EG20T: Update PCH_UART driver to 2.6.36

PATCH In review Tomoya MORINAGA 4 participants 6 messages Nov 17, 2010 – Dec 7, 2010

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 EG20T: Update PCH_UART driver to 2.6.36

Hi Alan,

I have modified for your indications.
- Delete unnecessary loop at tty_intert_flip_string processing.
- Replace pr_info to pr_debug in case tty_port_tty_get fails.

Please check below.

Signature · 19 lines
Thanks,
Tomoya MORINAGA(OKI SEMICONDUCTOR CO., LTD.)

---
UART driver of Intel EG20T(Topcliff) PCH

Intel EG20T PCH is the platform controller hub that is going to be used in
Intel's general embedded platform. All IO peripherals in
Intel EG20T PCH are actually devices sitting on AMBA bus. 
Intel EG20T PCH has UART I/F. Using this I/F, it is able to access system
devices connected to UART.

Signed-off-by: Tomoya MORINAGA <[email protected]>
---
 drivers/serial/Kconfig    |    8 +
 drivers/serial/Makefile   |    1 +
 drivers/serial/pch_uart.c | 1450 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1459 insertions(+), 0 deletions(-)
 create mode 100644 drivers/serial/pch_uart.c
drivers/serial/Kconfig +8 -0
index 12900f7..c9165b3 100644
@@ -1611,4 +1611,12 @@ config SERIAL_ALTERA_UART_CONSOLE
 	help
 	  Enable a Altera UART port to be the system console.
 
+config SERIAL_PCH_UART
+	tristate "Intel EG20T PCH UART"
+	select SERIAL_CORE
+	depends on PCI
+	help
+	  This driver is for PCH(Platform controller Hub) UART of Intel EG20T
+	  which is an IOH(Input/Output Hub) for x86 embedded processor.
+	  Enabling PCH_DMA, this PCH UART works as DMA mode.
 endmenu
drivers/serial/Makefile +1 -0
index 1ca4fd5..af874da 100644
@@ -88,3 +88,4 @@ obj-$(CONFIG_SERIAL_ALTERA_JTAGUART) += altera_jtaguart.o
 obj-$(CONFIG_SERIAL_ALTERA_UART) += altera_uart.o
 obj-$(CONFIG_SERIAL_MRST_MAX3110)	+= mrst_max3110.o
 obj-$(CONFIG_SERIAL_MFD_HSU)	+= mfd.o
+obj-$(CONFIG_SERIAL_PCH_UART)	+= pch_uart.o
drivers/serial/pch_uart.c new file +1450 -0

1,450 lines not on this page · raw message

Signature · 1 line
1.6.0.6
Acked-by on v5 1/1
#1 lore raw
Quoted 7 lines · On Wed, 17 Nov 2010 09:55:54 +0900 Tomoya MORINAGA…

Hi Alan,

I have modified for your indications.
- Delete unnecessary loop at tty_intert_flip_string processing.
- Replace pr_info to pr_debug in case tty_port_tty_get fails.

Please check below.

There are other minor cleanups that could be done but nothing I see now which is a barrier to merging it.

Alan

#2 lore raw

Re: Serial: EG20T: add PCH_UART driver

In reply to Tomoya MORINAGA
Quoted 7 lines · Tomoya MORINAGA

UART driver of Intel EG20T(Topcliff) PCH

Intel EG20T PCH is the platform controller hub that is going to be used in Intel's general embedded platform. All IO peripherals in
Intel EG20T PCH are actually devices sitting on AMBA bus. Intel EG20T PCH has UART I/F. Using this I/F, it is able to access system devices connected to UART.

I've applied this, but I now get the following warnings when building
the code:
drivers/serial/pch_uart.c: In function ‘dma_handle_rx’:
drivers/serial/pch_uart.c:685:24: warning: cast from pointer to integer of different size drivers/serial/pch_uart.c: In function ‘dma_handle_tx’:
drivers/serial/pch_uart.c:778:23: warning: cast from pointer to integer of different size drivers/serial/pch_uart.c: In function ‘pch_uart_init_port’:
drivers/serial/pch_uart.c:1289:20: warning: cast to pointer from integer of different size drivers/serial/pch_uart.c: In function ‘pch_uart_exit_port’:
drivers/serial/pch_uart.c:1328:2: warning: cast from pointer to integer of different size

Please send me a follow-up patch to resolve this.

thanks,

greg k-h

#3 lore raw

Re: Serial: EG20T: add PCH_UART driver

Quoted 2 lines · Greg KH

I've applied this, but I now get the following warnings when building the code:

Thank you for your applying.
I will post the patch for the warning issue.

Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

#4 lore raw

Re: Serial: EG20T: add PCH_UART driver

In reply to Greg KH
Quoted 2 lines · Greg KH

I've applied this, but I now get the following warnings when building the code:

Sorry, for late.
I can't see these warnings.
I think we build with 32bit Linux PC. But we don't have 64-bit PC.

I tried build with "-m64" option on our PC, I can see the following error. : sorry, unimplemented: 64-bit mode not compiled in

Can I see the warnings using our PC ?
If you have any information, let me know how to do.

---
Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

#5 lore raw

Re: Serial: EG20T: add PCH_UART driver

Quoted 9 lines · Tomoya MORINAGA
Quoted 2 lines · Greg KH

I've applied this, but I now get the following warnings when building the code:

Sorry, for late.
I can't see these warnings.
I think we build with 32bit Linux PC. But we don't have 64-bit PC.

Quoted 5 lines

I tried build with "-m64" option on our PC, I can see the following error. : sorry, unimplemented: 64-bit mode not compiled in

Can I see the warnings using our PC ?
If you have any information, let me know how to do.

Yes, use a version of gcc that will build in 64bit mode :)

Or use a modern processor (I find it hard to believe you don't have access to a 64bit intel processor these days...)

thanks,

greg k-h