Skip to contentSkip to conversation

isa: Add APM and ACPI dependencies for VT82C686

PATCH Applied BALATON Zoltan 3 participants 4 messages Mar 10, 2019 – Mar 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 isa: Add APM and ACPI dependencies for VT82C686

Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add dependency on these in Kconfig to fix this.

---
 hw/isa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
hw/isa/Kconfig +2 -0
index 57e09a0cb8..e092da3fc3 100644
@@ -36,6 +36,8 @@ config VT82C686
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC
+    select APM
+    select ACPI_X86
 
 config SMC37C669
     bool
Signature · 1 line
2.13.7
#1 lore raw
Quoted 14 lines · BALATON Zoltan

Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add dependency on these in Kconfig to fix this.

---
 hw/isa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
hw/isa/Kconfig +0 -0
index 57e09a0cb8..e092da3fc3 100644

hw/isa/Kconfig config VT82C686 · line 43

Quoted 8 lines
hw/isa/Kconfig +2 -0
@@ -36,6 +36,8 @@ config VT82C686
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC
+    select APM
+    select ACPI_X86
 
 config SMC37C669
     bool

Queued, thanks.

Paolo

#2 lore raw
In reply to BALATON Zoltan
Quoted 13 lines · BALATON Zoltan

Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add dependency on these in Kconfig to fix this.

---
 hw/isa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
hw/isa/Kconfig +0 -0
index 57e09a0cb8..e092da3fc3 100644

hw/isa/Kconfig config VT82C686 · line 39

Quoted 4 lines
hw/isa/Kconfig +1 -0
@@ -36,6 +36,8 @@ config VT82C686
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC
+    select APM

Correct, I missed this one.

hw/isa/Kconfig config VT82C686 · line 40

Quoted 1 line
hw/isa/Kconfig +1 -0
+    select ACPI_X86

NACK it does require ACPI but not X86.

ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series, but I might have to include this in my 'Kconfig PIIX' series.

Quoted 4 lines
hw/isa/Kconfig +0 -0
 config SMC37C669
     bool
 
#3 lore raw
Quoted 21 lines · Philippe Mathieu-Daudé
Quoted 13 lines · BALATON Zoltan

Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add dependency on these in Kconfig to fix this.

---
 hw/isa/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
hw/isa/Kconfig +0 -0
index 57e09a0cb8..e092da3fc3 100644

hw/isa/Kconfig config VT82C686 · line 39

Quoted 4 lines
hw/isa/Kconfig +1 -0
@@ -36,6 +36,8 @@ config VT82C686
     select ACPI_SMBUS
     select SERIAL_ISA
     select FDC
+    select APM

Correct, I missed this one.

Quoted 11 lines

hw/isa/Kconfig config VT82C686 · line 40

Quoted 1 line
hw/isa/Kconfig +1 -0
+    select ACPI_X86

NACK it does require ACPI but not X86.

ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series, but I might have to include this in my 'Kconfig PIIX' series.

Quoted 4 lines
hw/isa/Kconfig +0 -0
 config SMC37C669
     bool
 

Oh, I thought this was a build fix. But since MIPS does select these, I've unqueued this patch and I'll let the maintainers pick Philippe's series.

Paolo