isa: Add APM and ACPI dependencies for VT82C686
PATCH 1/1 isa: Add APM and ACPI dependencies for VT82C686
Compiling vt82c686.c fails without APM and ACPI_PM funtions. Add dependency on these in Kconfig to fix this.
--- hw/isa/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
hw/isa/Kconfig +2 -0
@@ -36,6 +36,8 @@ config VT82C686 select ACPI_SMBUS select SERIAL_ISA select FDC + select APM + select ACPI_X86 config SMC37C669 bool
Signature · 1 line
2.13.7
Paolo Bonzini
AppliedQuoted 14 lines · BALATON Zoltan
Compiling
vt82c686.cfails without APM andACPI_PMfuntions. Add dependency on these inKconfigto fix this.Signed-off-by BALATON Zoltan <[email protected]>--- hw/isa/Kconfig | 2 ++ 1 file changed, 2 insertions(+)hw/isa/Kconfig +0
-0
hw/isa/Kconfig config VT82C686 · line 43
Quoted 8 lines
hw/isa/Kconfig +2
-0@@ -36,6 +36,8 @@ config VT82C686 select ACPI_SMBUS select SERIAL_ISA select FDC + select APM + select ACPI_X86 config SMC37C669 bool
Queued, thanks.
Paolo
Quoted 13 lines · BALATON Zoltan
Compiling
vt82c686.cfails without APM andACPI_PMfuntions. Add dependency on these inKconfigto fix this.Signed-off-by BALATON Zoltan <[email protected]>--- hw/isa/Kconfig | 2 ++ 1 file changed, 2 insertions(+)hw/isa/Kconfig +0
-0
hw/isa/Kconfig config VT82C686 · line 39
Quoted 4 lines
hw/isa/Kconfig +1
-0@@ -36,6 +36,8 @@ config VT82C686 select ACPI_SMBUS select SERIAL_ISA select FDC + select APM
Correct, I missed this one.
hw/isa/Kconfig config VT82C686 · line 40
Quoted 1 line
hw/isa/Kconfig +1
-0+ select ACPI_X86
NACK it does require ACPI but not X86.
ACPI_X86 is messy. I tried to fix VT82C686 in my "Kconfig MIPS" series, but I might have to include this in my 'Kconfig PIIX' series.
Quoted 4 lines
hw/isa/Kconfig +0
-0config SMC37C669 bool
Quoted 21 lines · Philippe Mathieu-Daudé
Quoted 13 lines · BALATON Zoltan
Compiling
vt82c686.cfails without APM andACPI_PMfuntions. Add dependency on these inKconfigto fix this.Signed-off-by BALATON Zoltan <[email protected]>--- hw/isa/Kconfig | 2 ++ 1 file changed, 2 insertions(+)hw/isa/Kconfig +0
-0hw/isa/Kconfig config VT82C686 · line 39
Quoted 4 lines
hw/isa/Kconfig +1
-0@@ -36,6 +36,8 @@ config VT82C686 select ACPI_SMBUS select SERIAL_ISA select FDC + select APMCorrect, I missed this one.
Quoted 11 lines
hw/isa/Kconfig config VT82C686 · line 40
Quoted 1 line
hw/isa/Kconfig +1
-0+ select ACPI_X86NACK it does require ACPI but not X86.
ACPI_X86is messy. I tried to fix VT82C686 in my "KconfigMIPS" series, but I might have to include this in my 'KconfigPIIX' series.Quoted 4 lines
hw/isa/Kconfig +0
-0config SMC37C669 bool
Oh, I thought this was a build fix. But since MIPS does select these, I've unqueued this patch and I'll let the maintainers pick Philippe's series.
Paolo