Skip to contentSkip to conversation

ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

PATCH Superseded Simon Trimmer 2 participants 3 messages Mar 31

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

Ensure that subsystem_device is printed with leading zeros when combined with subsystem_vendor to form the SSID. Without this, devices with upper bits unset may appear to have an incorrect SSID in the debug output.

Fixes aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem Vendor and Device IDs")
---
 sound/soc/amd/ps/pci-ps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/ps/pci-ps.c +1 -1
index 3a20cc10d61f5..fafadc36e4830 100644
@@ -339,7 +339,7 @@ static struct snd_soc_acpi_mach *acp63_sdw_machine_select(struct device *dev)
 			mach->mach_params.subsystem_device = acp_data->subsystem_device;
 			mach->mach_params.subsystem_id_set = true;
 
-			dev_dbg(dev, "SSID %x%x\n", mach->mach_params.subsystem_vendor,
+			dev_dbg(dev, "SSID %x%0x\n", mach->mach_params.subsystem_vendor,
 				mach->mach_params.subsystem_device);
 			return mach;
 		}
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 5 lines · Simon Trimmer

Ensure that subsystem_device is printed with leading zeros when combined with subsystem_vendor to form the SSID. Without this, devices with upper bits unset may appear to have an incorrect SSID in the debug output.

Fixes aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem Vendor and Device IDs")

Fixes?

sound/soc/amd/ps/pci-ps.c static struct snd_soc_acpi_mach *acp63_sdw_machine_select(struct device *dev) · line 342

Quoted 2 lines
sound/soc/amd/ps/pci-ps.c +1 -1
-			dev_dbg(dev, "SSID %x%x\n", mach->mach_params.subsystem_vendor,
+			dev_dbg(dev, "SSID %x%0x\n", mach->mach_params.subsystem_vendor,

This doesn't specify a width so how would printk know how much to zero pad?

#2 lore raw
Quoted 19 lines

-----Original Message-----
From: Mark Brown <[email protected]>
Sent: Tuesday, March 31, 2026 12:27 PM
To: Simon Trimmer <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

Quoted 5 lines · Simon Trimmer

Ensure that subsystem_device is printed with leading zeros when combined with subsystem_vendor to form the SSID. Without this, devices with upper bits unset may appear to have an incorrect SSID in the debug output.

Fixes aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem

Vendor and Device IDs")

Fixes?

Quoted 7 lines
Quoted 4 lines
(quoted diff) +0 -1
-			dev_dbg(dev, "SSID %x%x\n", mach-

mach_params.subsystem_vendor,

(quoted diff) +1 -0
+			dev_dbg(dev, "SSID %x%0x\n", mach-

mach_params.subsystem_vendor,

This doesn't specify a width so how would printk know how much to zero pad?

Hmm, that's a good point - I'll correct it

Looking at sound/ there's a handful of other log messages making this same mistake