ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log
Subsystems (3)
PATCH 1/1 ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log
Ensure that subsystem_device is printed with leading zeros when combined with subsystem_vendor to form the SSID. Without this, devices with upper bits unset may appear to have an incorrect SSID in the debug output.
--- sound/soc/amd/ps/pci-ps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/amd/ps/pci-ps.c +1 -1
@@ -339,7 +339,7 @@ static struct snd_soc_acpi_mach *acp63_sdw_machine_select(struct device *dev) mach->mach_params.subsystem_device = acp_data->subsystem_device; mach->mach_params.subsystem_id_set = true; -dev_dbg (dev,"SSID %x%x\n" , mach->mach_params.subsystem_vendor, +dev_dbg (dev,"SSID %x%0x\n" , mach->mach_params.subsystem_vendor, mach->mach_params.subsystem_device);return mach; }
Signature · 1 line
2.43.0
Mark Brown
maintainerQuoted 5 lines · Simon Trimmer
Ensure that
subsystem_deviceis printed with leading zeros when combined withsubsystem_vendorto form the SSID. Without this, devices with upper bits unset may appear to have an incorrect SSID in the debug output.Fixes aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem Vendor and Device IDs")
Fixes?
sound/soc/amd/ps/pci-ps.c static struct snd_soc_acpi_mach *acp63_sdw_machine_select(struct device *dev) · line 342
Quoted 2 lines
sound/soc/amd/ps/pci-ps.c +1
-1- dev_dbg(dev, "SSID %x%x\n", mach->mach_params.subsystem_vendor, + dev_dbg(dev, "SSID %x%0x\n", mach->mach_params.subsystem_vendor,
This doesn't specify a width so how would printk know how much to zero pad?
Quoted 19 lines
-----Original Message-----
From: Mark Brown <[email protected]>
Sent: Tuesday, March 31, 2026 12:27 PM
To: Simon Trimmer <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] ASoC: amd: ps: Fix missing leading zeros insubsystem_deviceSSID logQuoted 5 lines · Simon Trimmer
Ensure that
subsystem_deviceis printed with leading zeros when combined withsubsystem_vendorto form the SSID. Without this, devices with upper bits unset may appear to have an incorrect SSID in the debug output.Fixes aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystemVendor and Device IDs")
Fixes?
Quoted 7 lines
Quoted 4 lines
(quoted diff) +0
-1- dev_dbg(dev, "SSID %x%x\n", mach-mach_params.subsystem_vendor,
(quoted diff) +1
-0+ dev_dbg(dev, "SSID %x%0x\n", mach-mach_params.subsystem_vendor,
This doesn't specify a width so how would printk know how much to zero pad?
Hmm, that's a good point - I'll correct it
Looking at sound/ there's a handful of other log messages making this same mistake