Skip to contentSkip to conversation

memorder: Adjust height of Table 15.5's header

PATCH In review Akira Yokosawa 2 participants 5 messages Nov 1, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memorder: Adjust height of Table 15.5's header

From a7e4a7ee67e980055dbef5808b89335fc0eba483 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Wed, 1 Nov 2017 23:14:44 +0900
Subject: [PATCH] memorder: Adjust height of Table 15.5's header

While we are here, for the ease of maintenance of the table, define a helper macro "\cpufml{}" to be used in the header.

Also adjust hspace for 1c layout and comment out a paragraph which is pointless for the moment.

---
 memorder/memorder.tex | 45 ++++++++++++++-------------------------------
 1 file changed, 14 insertions(+), 31 deletions(-)
memorder/memorder.tex +14 -31
index db5e065..b7d20f0 100644
@@ -3980,39 +3980,22 @@ dependencies.
 \rowcolors{4}{}{lightgray}
 \small
 \centering
-\renewcommand*{\arraystretch}{1.2}\OneColumnHSpace{-.6in}
+\newcommand{\cpufml}[1]{\begin{picture}(6,50)(0,0)\rotatebox{90}{#1}\end{picture}}
+\renewcommand*{\arraystretch}{1.2}\OneColumnHSpace{-.35in}
 \begin{tabular}{llccccccccc}
 	\toprule
 	\multicolumn{2}{l}{~} & \multicolumn{9}{c}{CPU Family} \\
 	\cmidrule{3-11}
 	\multicolumn{2}{c}{\raisebox{.5ex}{Property}}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{Alpha}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{ARMv8}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{ARMv7-A/R}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{Itanium}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{MIPS}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{\Power{}}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{SPARC TSO}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{x86}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{z~Systems}
-	  \end{picture}
+	& \cpufml{Alpha}
+	& \cpufml{ARMv8}
+	& \cpufml{ARMv7-A/R}
+	& \cpufml{Itanium}
+	& \cpufml{MIPS}
+	& \cpufml{\Power{}}
+	& \cpufml{SPARC TSO}
+	& \cpufml{x86}
+	& \cpufml{z~Systems}
 	\\
 	\cmidrule(r){1-2} \cmidrule{3-11}
 %		 Alpha ARMv8 ARMv7 Itanium MIPS PPC SPARC x86 z Systems
@@ -4070,7 +4053,7 @@ dependencies.
 	~ & ~ & C: & Compare-and-exchange instruction \\
 	~ & ~ & L: & Load-linked/store-conditional instruction \\
 \end{tabular}
-}\OneColumnHSpace{-0.7in}
+}\OneColumnHSpace{-0.4in}
 \caption{Summary of Memory Ordering}
 \label{tab:memorder:Summary of Memory Ordering}
 \end{table*}
@@ -4132,8 +4115,8 @@ instruction cache and pipeline.
 Such CPUs require special instructions be executed for self-modifying
 code.
 
-Parenthesized CPU names indicate modes that are architecturally allowed,
-but rarely used in practice.
+%Parenthesized CPU names indicate modes that are architecturally allowed,
+%but rarely used in practice.
 
 The common ``just say no'' approach to memory-ordering operations
 can be eminently reasonable where it applies,
Signature · 1 line
2.7.4
#1 lore raw
Quoted 5 lines · Akira Yokosawa
Quoted 1 line

From a7e4a7ee67e980055dbef5808b89335fc0eba483 Mon Sep 17 00:00:00 2001

From: Akira Yokosawa <[email protected]>
Date: Wed, 1 Nov 2017 23:14:44 +0900
Subject: [PATCH] memorder: Adjust height of Table 15.5's header

Quoted 7 lines

While we are here, for the ease of maintenance of the table, define a helper macro "\cpufml{}" to be used in the header.

Also adjust hspace for 1c layout and comment out a paragraph which is pointless for the moment.

Good catch on the stray paragraph, and \cpufml{} does make things much nicer, thank you!!! Queued and pushed.

There is another tables that could use this trick in locking/locking.tex. I believe that the definitions should be local to each table because the heights differ, and which quite oddly seem to need to be hard-coded.

Thanx, Paul

Quoted 82 lines
---
 memorder/memorder.tex | 45 ++++++++++++++-------------------------------
 1 file changed, 14 insertions(+), 31 deletions(-)
memorder/memorder.tex +14 -31
index db5e065..b7d20f0 100644
@@ -3980,39 +3980,22 @@ dependencies.
 \rowcolors{4}{}{lightgray}
 \small
 \centering
-\renewcommand*{\arraystretch}{1.2}\OneColumnHSpace{-.6in}
+\newcommand{\cpufml}[1]{\begin{picture}(6,50)(0,0)\rotatebox{90}{#1}\end{picture}}
+\renewcommand*{\arraystretch}{1.2}\OneColumnHSpace{-.35in}
 \begin{tabular}{llccccccccc}
 	\toprule
 	\multicolumn{2}{l}{~} & \multicolumn{9}{c}{CPU Family} \\
 	\cmidrule{3-11}
 	\multicolumn{2}{c}{\raisebox{.5ex}{Property}}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{Alpha}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{ARMv8}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{ARMv7-A/R}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{Itanium}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{MIPS}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{\Power{}}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{SPARC TSO}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{x86}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{z~Systems}
-	  \end{picture}
+	& \cpufml{Alpha}
+	& \cpufml{ARMv8}
+	& \cpufml{ARMv7-A/R}
+	& \cpufml{Itanium}
+	& \cpufml{MIPS}
+	& \cpufml{\Power{}}
+	& \cpufml{SPARC TSO}
+	& \cpufml{x86}
+	& \cpufml{z~Systems}
 	\\
 	\cmidrule(r){1-2} \cmidrule{3-11}
 %		 Alpha ARMv8 ARMv7 Itanium MIPS PPC SPARC x86 z Systems
@@ -4070,7 +4053,7 @@ dependencies.
 	~ & ~ & C: & Compare-and-exchange instruction \\
 	~ & ~ & L: & Load-linked/store-conditional instruction \\
 \end{tabular}
-}\OneColumnHSpace{-0.7in}
+}\OneColumnHSpace{-0.4in}
 \caption{Summary of Memory Ordering}
 \label{tab:memorder:Summary of Memory Ordering}
 \end{table*}
@@ -4132,8 +4115,8 @@ instruction cache and pipeline.
 Such CPUs require special instructions be executed for self-modifying
 code.
 
-Parenthesized CPU names indicate modes that are architecturally allowed,
-but rarely used in practice.
+%Parenthesized CPU names indicate modes that are architecturally allowed,
+%but rarely used in practice.
 
 The common ``just say no'' approach to memory-ordering operations
 can be eminently reasonable where it applies,
Signature · 1 line
2.7.4
#2 lore raw
Quoted 12 lines · Paul E. McKenney
Quoted 11 lines · Akira Yokosawa
Quoted 1 line

From a7e4a7ee67e980055dbef5808b89335fc0eba483 Mon Sep 17 00:00:00 2001

From: Akira Yokosawa <[email protected]>
Date: Wed, 1 Nov 2017 23:14:44 +0900
Subject: [PATCH] memorder: Adjust height of Table 15.5's header

While we are here, for the ease of maintenance of the table, define a helper macro "\cpufml{}" to be used in the header.

Also adjust hspace for 1c layout and comment out a paragraph which is pointless for the moment.

Quoted 8 lines
Quoted 1 line

Good catch on the stray paragraph, and \cpufml{} does make things much nicer, thank you!!! Queued and pushed.

There is another tables that could use this trick in locking/locking.tex. I believe that the definitions should be local to each table because the heights differ, and which quite oddly seem to need to be hard-coded.

I see. I'll take care of it tomorrow.

Akira

Quoted 87 lines

Thanx, Paul

Quoted 82 lines
---
 memorder/memorder.tex | 45 ++++++++++++++-------------------------------
 1 file changed, 14 insertions(+), 31 deletions(-)
memorder/memorder.tex +14 -31
index db5e065..b7d20f0 100644
@@ -3980,39 +3980,22 @@ dependencies.
 \rowcolors{4}{}{lightgray}
 \small
 \centering
-\renewcommand*{\arraystretch}{1.2}\OneColumnHSpace{-.6in}
+\newcommand{\cpufml}[1]{\begin{picture}(6,50)(0,0)\rotatebox{90}{#1}\end{picture}}
+\renewcommand*{\arraystretch}{1.2}\OneColumnHSpace{-.35in}
 \begin{tabular}{llccccccccc}
 	\toprule
 	\multicolumn{2}{l}{~} & \multicolumn{9}{c}{CPU Family} \\
 	\cmidrule{3-11}
 	\multicolumn{2}{c}{\raisebox{.5ex}{Property}}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{Alpha}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{ARMv8}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{ARMv7-A/R}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{Itanium}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{MIPS}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{\Power{}}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{SPARC TSO}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{x86}
-	  \end{picture}
-	& \begin{picture}(6,60)(0,0)
-		\rotatebox{90}{z~Systems}
-	  \end{picture}
+	& \cpufml{Alpha}
+	& \cpufml{ARMv8}
+	& \cpufml{ARMv7-A/R}
+	& \cpufml{Itanium}
+	& \cpufml{MIPS}
+	& \cpufml{\Power{}}
+	& \cpufml{SPARC TSO}
+	& \cpufml{x86}
+	& \cpufml{z~Systems}
 	\\
 	\cmidrule(r){1-2} \cmidrule{3-11}
 %		 Alpha ARMv8 ARMv7 Itanium MIPS PPC SPARC x86 z Systems
@@ -4070,7 +4053,7 @@ dependencies.
 	~ & ~ & C: & Compare-and-exchange instruction \\
 	~ & ~ & L: & Load-linked/store-conditional instruction \\
 \end{tabular}
-}\OneColumnHSpace{-0.7in}
+}\OneColumnHSpace{-0.4in}
 \caption{Summary of Memory Ordering}
 \label{tab:memorder:Summary of Memory Ordering}
 \end{table*}
@@ -4132,8 +4115,8 @@ instruction cache and pipeline.
 Such CPUs require special instructions be executed for self-modifying
 code.
 
-Parenthesized CPU names indicate modes that are architecturally allowed,
-but rarely used in practice.
+%Parenthesized CPU names indicate modes that are architecturally allowed,
+%but rarely used in practice.
 
 The common ``just say no'' approach to memory-ordering operations
 can be eminently reasonable where it applies,
Signature · 1 line
2.7.4
#3 lore raw

PATCH 1/1 locking: Use helper macro in Table 7.1

In reply to Paul E. McKenney

From af9e5f272a12304067120b79a86d6673b605b7b3 Mon Sep 17 00:00:00 2001
From: Akira Yokosawa <[email protected]>
Date: Thu, 2 Nov 2017 07:02:07 +0900
Subject: [PATCH] locking: Use helper macro in Table 7.1

---
 locking/locking.tex | 25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)
locking/locking.tex +7 -18
index 025320b..12a0240 100644
@@ -1314,28 +1314,17 @@ or even milliseconds.
 \begin{table}
 \renewcommand*{\arraystretch}{1.2}
 \newcommand{\x}{\textcolor{gray!20}{\rule{7pt}{7pt}}}
+\newcommand{\rothead}[1]{\begin{picture}(6,65)(0,0)\rotatebox{90}{#1}\end{picture}}
 \small
 \centering
 \begin{tabular}{lcccccc}
 	\toprule
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Null (Not Held)}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Concurrent Read}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Concurrent Write}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Protected Read}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Protected Write}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Exclusive}
-	  \end{picture}
+	& \rothead{Null (Not Held)}
+	& \rothead{Concurrent Read}
+	& \rothead{Concurrent Write}
+	& \rothead{Protected Read}
+	& \rothead{Protected Write}
+	& \rothead{Exclusive}
 	\\
 %				  NL   CR   CW     PR   PW   EX
 	\cmidrule(r){1-1} \cmidrule{2-7}
Signature · 1 line
2.7.4
#4 lore raw

Re: [PATCH] locking: Use helper macro in Table 7.1

Quoted 6 lines · Akira Yokosawa
Quoted 1 line

From af9e5f272a12304067120b79a86d6673b605b7b3 Mon Sep 17 00:00:00 2001

From: Akira Yokosawa <[email protected]>
Date: Thu, 2 Nov 2017 07:02:07 +0900
Subject: [PATCH] locking: Use helper macro in Table 7.1

Applied, thank you very much!

Thanx, Paul

Quoted 53 lines
---
 locking/locking.tex | 25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)
locking/locking.tex +7 -18
index 025320b..12a0240 100644
@@ -1314,28 +1314,17 @@ or even milliseconds.
 \begin{table}
 \renewcommand*{\arraystretch}{1.2}
 \newcommand{\x}{\textcolor{gray!20}{\rule{7pt}{7pt}}}
+\newcommand{\rothead}[1]{\begin{picture}(6,65)(0,0)\rotatebox{90}{#1}\end{picture}}
 \small
 \centering
 \begin{tabular}{lcccccc}
 	\toprule
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Null (Not Held)}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Concurrent Read}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Concurrent Write}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Protected Read}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Protected Write}
-	  \end{picture}
-	& \begin{picture}(6,65)(0,0)
-		\rotatebox{90}{Exclusive}
-	  \end{picture}
+	& \rothead{Null (Not Held)}
+	& \rothead{Concurrent Read}
+	& \rothead{Concurrent Write}
+	& \rothead{Protected Read}
+	& \rothead{Protected Write}
+	& \rothead{Exclusive}
 	\\
 %				  NL   CR   CW     PR   PW   EX
 	\cmidrule(r){1-1} \cmidrule{2-7}
Signature · 7 lines
2.7.4


--
To unsubscribe from this list: send the line "unsubscribe perfbook" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html