Skip to contentSkip to conversation

firmware: ti_sci: fix typo in boot authentication message name

PATCH In review Jorge Ramirez-Ortiz 3 participants 4 messages Jan 10, 2023 Texas instruments' system control interface (TISCI) protocol driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firmware: ti_sci: fix typo in boot authentication message name

Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)

---
 drivers/firmware/ti_sci.c | 2 +-
 drivers/firmware/ti_sci.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/ti_sci.c +1 -1
index 727e090e8a..bd7379ae55 100644
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
 
 	info = handle_to_ti_sci_info(handle);
 
-	xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
+	xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
 				     TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
 				     (u32 *)&req, sizeof(req), sizeof(*resp));
 	if (IS_ERR(xfer)) {
drivers/firmware/ti_sci.h +1 -1
index e4a087c2ba..101210eb21 100644
@@ -49,7 +49,7 @@
 #define TISCI_MSG_PROC_HANDOVER		0xc005
 #define TISCI_MSG_SET_PROC_BOOT_CONFIG	0xc100
 #define TISCI_MSG_SET_PROC_BOOT_CTRL	0xc101
-#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE	0xc120
+#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE	0xc120
 #define TISCI_MSG_GET_PROC_BOOT_STATUS	0xc400
 #define TISCI_MSG_WAIT_PROC_BOOT_STATUS	0xc401
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Jorge Ramirez-Ortiz

Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)

Quoted 32 lines
---
 drivers/firmware/ti_sci.c | 2 +-
 drivers/firmware/ti_sci.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/ti_sci.c +1 -1
index 727e090e8a..bd7379ae55 100644
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
 
        info = handle_to_ti_sci_info(handle);
 
-       xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
+       xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
                                     TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
                                     (u32 *)&req, sizeof(req), sizeof(*resp));
        if (IS_ERR(xfer)) {
drivers/firmware/ti_sci.h +1 -2
index e4a087c2ba..101210eb21 100644
@@ -49,7 +49,7 @@
 #define TISCI_MSG_PROC_HANDOVER                0xc005
 #define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100
 #define TISCI_MSG_SET_PROC_BOOT_CTRL   0xc101
-#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE        0xc120
+#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120
 #define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400
 #define TISCI_MSG_WAIT_PROC_BOOT_STATUS        0xc401
 
--
Quoted 2 lines

2.34.1

--
Best regards
Oleksandr

Oleksandr Suvorov
[email protected]

Acked-by on v1 1/1
#2 lore raw
In reply to Jorge Ramirez-Ortiz
Quoted 4 lines · Jorge Ramirez-Ortiz

Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)

---

Looks like this typo got copy/pasted over to ATF also[0].. I'll add your reported-by and go fix it over there (unless you are wanting to do that).

[0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50

Quoted 30 lines
  drivers/firmware/ti_sci.c | 2 +-
  drivers/firmware/ti_sci.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/ti_sci.c +1 -1
index 727e090e8a..bd7379ae55 100644
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
 
  	info = handle_to_ti_sci_info(handle);
 
-	xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
+	xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
  				     TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
  				     (u32 *)&req, sizeof(req), sizeof(*resp));
  	if (IS_ERR(xfer)) {
drivers/firmware/ti_sci.h +1 -1
index e4a087c2ba..101210eb21 100644
@@ -49,7 +49,7 @@
  #define TISCI_MSG_PROC_HANDOVER		0xc005
  #define TISCI_MSG_SET_PROC_BOOT_CONFIG	0xc100
  #define TISCI_MSG_SET_PROC_BOOT_CTRL	0xc101
-#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE	0xc120
+#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE	0xc120
  #define TISCI_MSG_GET_PROC_BOOT_STATUS	0xc400
  #define TISCI_MSG_WAIT_PROC_BOOT_STATUS	0xc401
 
#3 lore raw
Quoted 9 lines · Andrew Davis
Quoted 4 lines · Jorge Ramirez-Ortiz

Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)

---

Looks like this typo got copy/pasted over to ATF also[0].. I'll add your reported-by and go fix it over there (unless you are wanting to do that).

no no, please do. I was just reading code for secure boot and this typo was annoying me for some reason (go figure..)

thanks!

Quoted 32 lines

[0] https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50

Quoted 27 lines
  drivers/firmware/ti_sci.c | 2 +-
  drivers/firmware/ti_sci.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/ti_sci.c +1 -1
index 727e090e8a..bd7379ae55 100644
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle,
  	info = handle_to_ti_sci_info(handle);
-	xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMIAGE,
+	xfer = ti_sci_setup_one_xfer(info, TISCI_MSG_PROC_AUTH_BOOT_IMAGE,
  				     TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
  				     (u32 *)&req, sizeof(req), sizeof(*resp));
  	if (IS_ERR(xfer)) {
drivers/firmware/ti_sci.h +1 -1
index e4a087c2ba..101210eb21 100644
@@ -49,7 +49,7 @@
  #define TISCI_MSG_PROC_HANDOVER		0xc005
  #define TISCI_MSG_SET_PROC_BOOT_CONFIG	0xc100
  #define TISCI_MSG_SET_PROC_BOOT_CTRL	0xc101
-#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE	0xc120
+#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE	0xc120
  #define TISCI_MSG_GET_PROC_BOOT_STATUS	0xc400
  #define TISCI_MSG_WAIT_PROC_BOOT_STATUS	0xc401