firmware: ti_sci: fix typo in boot authentication message name
PATCH 1/1 firmware: ti_sci: fix typo in boot authentication message name
Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE)
--- drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/firmware/ti_sci.c +1 -1
@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, info =handle_to_ti_sci_info (handle); - xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMIAGE , + xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMAGE ,TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&req,sizeof (req),sizeof (*resp));if (IS_ERR (xfer)) {
drivers/firmware/ti_sci.h +1 -1
@@ -49,7 +49,7 @@#define TISCI_MSG_PROC_HANDOVER 0xc005#define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100#define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120#define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400#define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
Signature · 1 line
2.34.1
Quoted 4 lines · Jorge Ramirez-Ortiz
Fix
AUTH_BOOTmessage identifier (s/IMIAGE/IMAGE)Signed-off-by Jorge Ramirez-Ortiz <[email protected]>
Quoted 32 lines
--- drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/firmware/ti_sci.c +1
-1@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, info =handle_to_ti_sci_info (handle); - xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMIAGE , + xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMAGE ,TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&req,sizeof (req),sizeof (*resp));if (IS_ERR (xfer)) {drivers/firmware/ti_sci.h +1
-2@@ -49,7 +49,7 @@#define TISCI_MSG_PROC_HANDOVER 0xc005#define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100#define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120#define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400#define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401 --
Quoted 2 lines
2.34.1
--
Best regards
Oleksandr
Oleksandr Suvorov
[email protected]
Quoted 4 lines · Jorge Ramirez-Ortiz
Fix
AUTH_BOOTmessage identifier (s/IMIAGE/IMAGE)Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
Looks like this typo got copy/pasted over to ATF also[0].. I'll add your reported-by and go fix it over there (unless you are wanting to do that).
Quoted 30 lines
drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/firmware/ti_sci.c +1
-1@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, info =handle_to_ti_sci_info (handle); - xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMIAGE , + xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMAGE ,TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&req,sizeof (req),sizeof (*resp));if (IS_ERR (xfer)) {drivers/firmware/ti_sci.h +1
-1@@ -49,7 +49,7 @@#define TISCI_MSG_PROC_HANDOVER 0xc005#define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100#define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120#define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400#define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401
Quoted 9 lines · Andrew Davis
Quoted 4 lines · Jorge Ramirez-Ortiz
Fix
AUTH_BOOTmessage identifier (s/IMIAGE/IMAGE)Signed-off-by Jorge Ramirez-Ortiz <[email protected]>---
Looks like this typo got copy/pasted over to ATF also[0].. I'll add your reported-by and go fix it over there (unless you are wanting to do that).
no no, please do. I was just reading code for secure boot and this typo was annoying me for some reason (go figure..)
thanks!
Quoted 32 lines
Acked-by Andrew Davis <[email protected]>Quoted 27 lines
drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/firmware/ti_sci.c +1
-1@@ -1935,7 +1935,7 @@ static int ti_sci_cmd_proc_auth_boot_image(const struct ti_sci_handle *handle, info =handle_to_ti_sci_info (handle); - xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMIAGE , + xfer =ti_sci_setup_one_xfer (info,TISCI_MSG_PROC_AUTH_BOOT_IMAGE ,TI_SCI_FLAG_REQ_ACK_ON_PROCESSED , (u32 *)&req,sizeof (req),sizeof (*resp));if (IS_ERR (xfer)) {drivers/firmware/ti_sci.h +1
-1@@ -49,7 +49,7 @@#define TISCI_MSG_PROC_HANDOVER 0xc005#define TISCI_MSG_SET_PROC_BOOT_CONFIG 0xc100#define TISCI_MSG_SET_PROC_BOOT_CTRL 0xc101 -#define TISCI_MSG_PROC_AUTH_BOOT_IMIAGE 0xc120 +#define TISCI_MSG_PROC_AUTH_BOOT_IMAGE 0xc120#define TISCI_MSG_GET_PROC_BOOT_STATUS 0xc400#define TISCI_MSG_WAIT_PROC_BOOT_STATUS 0xc401