Skip to contentSkip to conversation

phy: samsung-ufs: Fix IS_ERR argument

PATCH Applied Gustavo A. R. Silva 4 participants 4 messages Jul 20, 2020 – Jul 21, 2020 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 phy: samsung-ufs: Fix IS_ERR argument

Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper argument to be passed to IS_ERR() is phy->rx1_symbol_clk.

This bug was detected with the help of Coccinelle.

Fixes bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC")

---
Changes in v2:
- Update subject line and changelog text.

 drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/samsung/phy-samsung-ufs.c +1 -1
index 43ef77d1d96c..9832599a0283 100644
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy)
 	}
 
 	phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
-	if (IS_ERR(phy->rx0_symbol_clk)) {
+	if (IS_ERR(phy->rx1_symbol_clk)) {
 		dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
 		return PTR_ERR(phy->rx1_symbol_clk);
 	}
Signature · 1 line
2.27.0
Reviewed-by on v2 1/1
#1 lore raw

Hi Gustavo,

Quoted 7 lines

-----Original Message-----
From: Gustavo A. R. Silva <[email protected]>
Sent: 20 July 2020 18:57
To: Kishon Vijay Abraham I <[email protected]>; Vinod Koul <[email protected]>; Seungwon Jeon <[email protected]>; Alim Akhtar <[email protected]>; Kiwoong Kim <[email protected]>
Cc: [email protected]; Gustavo A. R. Silva

<[email protected]>

Quoted 8 lines

Subject: [PATCH v2][next] phy: samsung-ufs: Fix IS_ERR argument

Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper argument to be passed to IS_ERR() is phy->rx1_symbol_clk.

This bug was detected with the help of Coccinelle.

Fixes bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung

SoC")

Quoted 2 lines

---

Quoted 23 lines

Changes in v2:
- Update subject line and changelog text.

 drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/samsung/phy-samsung-ufs.c +1 -1
index 43ef77d1d96c..9832599a0283 100644
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct
 samsung_ufs_phy *phy)
 	}
 
 	phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
-	if (IS_ERR(phy->rx0_symbol_clk)) {
+	if (IS_ERR(phy->rx1_symbol_clk)) {
 		dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
 		return PTR_ERR(phy->rx1_symbol_clk);

}
--
2.27.0

#2 lore raw
Quoted 15 lines · Alim Akhtar

Hi Gustavo,

Quoted 7 lines

-----Original Message-----
From: Gustavo A. R. Silva <[email protected]>
Sent: 20 July 2020 18:57
To: Kishon Vijay Abraham I <[email protected]>; Vinod Koul <[email protected]>; Seungwon Jeon <[email protected]>; Alim Akhtar <[email protected]>; Kiwoong Kim <[email protected]>
Cc: [email protected]; Gustavo A. R. Silva

<[email protected]>

Quoted 5 lines

Subject: [PATCH v2][next] phy: samsung-ufs: Fix IS_ERR argument

Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper argument to be passed to IS_ERR() is phy->rx1_symbol_clk.

Quoted 8 lines
Quoted 3 lines

This bug was detected with the help of Coccinelle.

Fixes bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung

SoC")

Quoted 2 lines

---

Thanks, Alim.

--
Gustavo

Quoted 25 lines
Quoted 23 lines

Changes in v2:
- Update subject line and changelog text.

 drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/samsung/phy-samsung-ufs.c +1 -1
index 43ef77d1d96c..9832599a0283 100644
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct
 samsung_ufs_phy *phy)
 	}
 
 	phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
-	if (IS_ERR(phy->rx0_symbol_clk)) {
+	if (IS_ERR(phy->rx1_symbol_clk)) {
 		dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
 		return PTR_ERR(phy->rx1_symbol_clk);

}
--
2.27.0

maintainer Applied
#3 lore raw
In reply to Gustavo A. R. Silva
Quoted 4 lines · Gustavo A. R. Silva

Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper argument to be passed to IS_ERR() is phy->rx1_symbol_clk.

This bug was detected with the help of Coccinelle.

Applied, thanks

Signature · 1 line
~Vinod