phy: samsung-ufs: Fix IS_ERR argument
PATCH v2 1/1 phy: samsung-ufs: Fix IS_ERR argument
Fix IS_ERR argument in samsung_ufs_phy_symbol_clk_init(). The proper argument to be passed to IS_ERR() is phy->rx1_symbol_clk.
This bug was detected with the help of Coccinelle.
---
Changes in v2:
- Update subject line and changelog text.
drivers/phy/samsung/phy-samsung-ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/samsung/phy-samsung-ufs.c +1 -1
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy) } phy->rx1_symbol_clk =devm_clk_get (phy->dev,"rx1_symbol_clk" ); -if (IS_ERR (phy->rx0_symbol_clk)) { +if (IS_ERR (phy->rx1_symbol_clk)) {dev_err (phy->dev,"failed to get rx1_symbol_clk clock\n" );return PTR_ERR (phy->rx1_symbol_clk); }
Signature · 1 line
2.27.0
Hi Gustavo,
Quoted 7 lines
-----Original Message-----
From: Gustavo A. R. Silva <[email protected]>
Sent: 20 July 2020 18:57
To: Kishon Vijay Abraham I <[email protected]>; Vinod Koul <[email protected]>; Seungwon Jeon <[email protected]>; Alim Akhtar <[email protected]>; Kiwoong Kim <[email protected]>
Cc: [email protected]; Gustavo A. R. Silva
Quoted 8 lines
Subject: [PATCH v2][next] phy: samsung-ufs: Fix
IS_ERRargumentFix
IS_ERRargument insamsung_ufs_phy_symbol_clk_init(). The proper argument to be passed toIS_ERR()isphy->rx1_symbol_clk.This bug was detected with the help of Coccinelle.
Fixes bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung
SoC")
Quoted 2 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Quoted 23 lines
Changes in v2:
- Update subject line and changelog text.drivers/phy/samsung/phy-samsung-ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/phy/samsung/phy-samsung-ufs.c +1
-1@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy) } phy->rx1_symbol_clk =devm_clk_get (phy->dev,"rx1_symbol_clk" ); -if (IS_ERR (phy->rx0_symbol_clk)) { +if (IS_ERR (phy->rx1_symbol_clk)) {dev_err (phy->dev,"failed to get rx1_symbol_clk clock\n" );return PTR_ERR (phy->rx1_symbol_clk);}
--
2.27.0
Quoted 15 lines · Alim Akhtar
Hi Gustavo,
Quoted 7 lines
-----Original Message-----
From: Gustavo A. R. Silva <[email protected]>
Sent: 20 July 2020 18:57
To: Kishon Vijay Abraham I <[email protected]>; Vinod Koul <[email protected]>; Seungwon Jeon <[email protected]>; Alim Akhtar <[email protected]>; Kiwoong Kim <[email protected]>
Cc: [email protected]; Gustavo A. R. SilvaQuoted 5 lines
Subject: [PATCH v2][next] phy: samsung-ufs: Fix
IS_ERRargumentFix
IS_ERRargument insamsung_ufs_phy_symbol_clk_init(). The proper argument to be passed toIS_ERR()isphy->rx1_symbol_clk.
Quoted 8 lines
Quoted 3 lines
This bug was detected with the help of Coccinelle.
Fixes bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsungSoC")
Quoted 2 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Reviewed-by Alim Akhtar <[email protected]>
Thanks, Alim.
--
Gustavo
Quoted 25 lines
Quoted 23 lines
Changes in v2:
- Update subject line and changelog text.drivers/phy/samsung/phy-samsung-ufs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/phy/samsung/phy-samsung-ufs.c +1
-1@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy) } phy->rx1_symbol_clk =devm_clk_get (phy->dev,"rx1_symbol_clk" ); -if (IS_ERR (phy->rx0_symbol_clk)) { +if (IS_ERR (phy->rx1_symbol_clk)) {dev_err (phy->dev,"failed to get rx1_symbol_clk clock\n" );return PTR_ERR (phy->rx1_symbol_clk);}
--
2.27.0
Quoted 4 lines · Gustavo A. R. Silva
Fix
IS_ERRargument insamsung_ufs_phy_symbol_clk_init(). The proper argument to be passed toIS_ERR()isphy->rx1_symbol_clk.This bug was detected with the help of Coccinelle.
Applied, thanks
Signature · 1 line
~Vinod