hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator
Subsystems (2)
PATCH 1/1 hwmon: (pmbus/tda38640) Add driver for Infineon TDA38640 Voltage Regulator
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
--- .../devicetree/bindings/trivial-devices.yaml | 2 + drivers/hwmon/pmbus/Kconfig | 16 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ 4 files changed, 97 insertions(+) create mode 100644 drivers/hwmon/pmbus/tda38640.c
Documentation/devicetree/bindings/trivial-devices.yaml +2 -0
@@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280
drivers/hwmon/pmbus/Kconfig +16 -0
@@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640. + + This driver can also be built as a module. If so, the module will + be called tda38640. + +config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator. + config SENSORS_TPS40422 tristate "TI TPS40422" help
drivers/hwmon/pmbus/Makefile +1 -0
@@ -40,6 +40,7 @@ obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o +obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.o
drivers/hwmon/pmbus/tda38640.c new file +78 -0
78 lines not on this page · raw message
base-commit: 4d891f76a30d3be4194a805c5e4277786140ef05
Signature · 1 line
2.38.1
Quoted 8 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- .../devicetree/bindings/trivial-devices.yaml | 2 +
Split bindings from driver code.
Quoted 32 lines
drivers/hwmon/pmbus/Kconfig | 16 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ 4 files changed, 97 insertions(+) create mode 100644 drivers/hwmon/pmbus/tda38640.cDocumentation/devicetree/bindings/trivial-devices.yaml +2
-0@@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280drivers/hwmon/pmbus/Kconfig +5
-0@@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640.
drivers/hwmon/pmbus/Kconfig config SENSORS_STPDDC60 · line 412
Quoted 10 lines
drivers/hwmon/pmbus/Kconfig +10
-0+ + This driver can also be built as a module. If so, the module will + be called tda38640. + +config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator.
Drop entire option, why is it needed?
Quoted 65 lines
drivers/hwmon/pmbus/Kconfig +1
-0+ config SENSORS_TPS40422 tristate "TI TPS40422" helpdrivers/hwmon/pmbus/Makefile +1
-0@@ -40,6 +40,7 @@ obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o +obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.odrivers/hwmon/pmbus/tda38640.c new file +43
-0@@ -0,0 +1,78 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for Infineon TDA38640 +* +* Copyright (c) 2023 9elements GmbH +* +*/ + +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/driver.h> +#include "pmbus.h" + +#if IS_ENABLED (CONFIG_SENSORS_TDA38640_REGULATOR ) +static const struct regulator_desc tda38640_reg_desc[] = { +PMBUS_REGULATOR ("vout" ,0 ), +}; +#endif /* CONFIG_SENSORS_TDA38640_REGULATOR */ + +static struct pmbus_driver_info tda38640_info = { + .pages =1 , + .format[PSC_VOLTAGE_IN ] = linear, + .format[PSC_VOLTAGE_OUT ] = linear, + .format[PSC_CURRENT_OUT ] = linear, + .format[PSC_CURRENT_IN ] = linear, + .format[PSC_POWER ] = linear, + .format[PSC_TEMPERATURE ] = linear, + + .func[0 ] =PMBUS_HAVE_VIN |PMBUS_HAVE_STATUS_INPUT + |PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP + |PMBUS_HAVE_IIN + |PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT + |PMBUS_HAVE_IOUT |PMBUS_HAVE_STATUS_IOUT + |PMBUS_HAVE_POUT |PMBUS_HAVE_PIN , +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) + .num_regulators =1 , + .reg_desc = tda38640_reg_desc, +#endif +}; +
drivers/hwmon/pmbus/tda38640.c line 53
Quoted 10 lines
drivers/hwmon/pmbus/tda38640.c new file +10
-0+static int tda38640_probe (struct i2c_client *client) +{ +return pmbus_do_probe (client, &tda38640_info); +} + +static const struct i2c_device_id tda38640_id[] = { + {"tda38640" ,0 }, + {} +}; +
Drop blank line
drivers/hwmon/pmbus/tda38640.c line 56
Quoted 3 lines
drivers/hwmon/pmbus/tda38640.c new file +3
-0+MODULE_DEVICE_TABLE (i2c, tda38640_id); + +#ifdef CONFIG_OF
Drop ifdefs and use __maybe_unused
drivers/hwmon/pmbus/tda38640.c line 61
Quoted 5 lines
drivers/hwmon/pmbus/tda38640.c new file +5
-0+static const struct of_device_id tda38640_of_match[] = { + { .compatible ="infineon,tda38640" }, + { }, +}; +MODULE_DEVICE_TABLE (of, tda38640_of_match);
Where is it used? You miss the user.
drivers/hwmon/pmbus/tda38640.c line 71
Quoted 10 lines
drivers/hwmon/pmbus/tda38640.c new file +10
-0+#endif + +/* This is the driver that will be inserted */ +static struct i2c_driver tda38640_driver = { + .driver = { + .name ="tda38640" , + }, + .probe_new = tda38640_probe, + .id_table = tda38640_id, +};
Best regards,
Krzysztof
Hi
Quoted 11 lines · Krzysztof Kozlowski
Quoted 8 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- .../devicetree/bindings/trivial-devices.yaml | 2 +Split bindings from driver code.
Sure
Quoted 37 lines
Quoted 37 lines
drivers/hwmon/pmbus/Kconfig | 16 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ 4 files changed, 97 insertions(+)create mode 100644
drivers/hwmon/pmbus/tda38640.cDocumentation/devicetree/bindings/trivial-devices.yaml +2
-0@@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280drivers/hwmon/pmbus/Kconfig +9
-0@@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640. + + This driver can also be built as a module. If so, the module will + be called tda38640. +
Quoted 8 lines
drivers/hwmon/pmbus/Kconfig config SENSORS_STPDDC60 · line 412
Quoted 6 lines
drivers/hwmon/pmbus/Kconfig +6
-0+config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator.Drop entire option, why is it needed?
You mean regulator option ?
This is how other pmbus regulator devices have provided option.
Quoted 70 lines
Quoted 70 lines
drivers/hwmon/pmbus/Kconfig +1
-0+ config SENSORS_TPS40422 tristate "TI TPS40422" helpdrivers/hwmon/pmbus/Makefile +1
-0@@ -40,6 +40,7 @@ obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o obj-$(CONFIG_SENSORS_Q54SJ108A2) += q54sj108a2.o obj-$(CONFIG_SENSORS_STPDDC60) += stpddc60.o +obj-$(CONFIG_SENSORS_TDA38640) += tda38640.o obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o obj-$(CONFIG_SENSORS_TPS53679) += tps53679.o obj-$(CONFIG_SENSORS_TPS546D24) += tps546d24.odrivers/hwmon/pmbus/tda38640.c new file +47
-0@@ -0,0 +1,78 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for Infineon TDA38640 +* +* Copyright (c) 2023 9elements GmbH +* +*/ + +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/regulator/driver.h> +#include "pmbus.h" + +#if IS_ENABLED (CONFIG_SENSORS_TDA38640_REGULATOR ) +static const struct regulator_desc tda38640_reg_desc[] = { +PMBUS_REGULATOR ("vout" ,0 ), +}; +#endif /* CONFIG_SENSORS_TDA38640_REGULATOR */ + +static struct pmbus_driver_info tda38640_info = { + .pages =1 , + .format[PSC_VOLTAGE_IN ] = linear, + .format[PSC_VOLTAGE_OUT ] = linear, + .format[PSC_CURRENT_OUT ] = linear, + .format[PSC_CURRENT_IN ] = linear, + .format[PSC_POWER ] = linear, + .format[PSC_TEMPERATURE ] = linear, + + .func[0 ] =PMBUS_HAVE_VIN |PMBUS_HAVE_STATUS_INPUT + |PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP + |PMBUS_HAVE_IIN + |PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT + |PMBUS_HAVE_IOUT |PMBUS_HAVE_STATUS_IOUT + |PMBUS_HAVE_POUT |PMBUS_HAVE_PIN , +#if IS_ENABLED(CONFIG_SENSORS_TDA38640_REGULATOR) + .num_regulators =1 , + .reg_desc = tda38640_reg_desc, +#endif +}; + +static int tda38640_probe (struct i2c_client *client) +{ +return pmbus_do_probe (client, &tda38640_info); +}
Quoted 8 lines
drivers/hwmon/pmbus/tda38640.c line 53
Quoted 6 lines
drivers/hwmon/pmbus/tda38640.c new file +6
-0+ +static const struct i2c_device_id tda38640_id[] = { + {"tda38640" ,0 }, + {} +}; +Drop blank line
Sure
Quoted 7 lines
drivers/hwmon/pmbus/tda38640.c line 56
Quoted 4 lines
drivers/hwmon/pmbus/tda38640.c new file +3
-0+MODULE_DEVICE_TABLE (i2c, tda38640_id); + +#ifdef CONFIG_OF Drop ifdefs and use
__maybe_unused
Quoted 7 lines
drivers/hwmon/pmbus/tda38640.c line 61
Quoted 5 lines
drivers/hwmon/pmbus/tda38640.c new file +5
-0+static const struct of_device_id tda38640_of_match[] = { + { .compatible ="infineon,tda38640" }, + { }, +}; +MODULE_DEVICE_TABLE (of, tda38640_of_match);Where is it used? You miss the user.
I'm not sure if I get your question right. This chip is used in sbp1 board to power CPU rails.
Quoted 15 lines
drivers/hwmon/pmbus/tda38640.c line 71
Quoted 11 lines
drivers/hwmon/pmbus/tda38640.c new file +10
-0+#endif + +/* This is the driver that will be inserted */ +static struct i2c_driver tda38640_driver = { + .driver = { + .name ="tda38640" , + }, + .probe_new = tda38640_probe, + .id_table = tda38640_id, +};Best regards,
Krzysztof
Best regards,
Naresh
Quoted 60 lines · Naresh Solanki
Hi
Quoted 11 lines · Krzysztof Kozlowski
Quoted 8 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- .../devicetree/bindings/trivial-devices.yaml | 2 +Split bindings from driver code.
Sure
Quoted 37 lines
Quoted 37 lines
drivers/hwmon/pmbus/Kconfig | 16 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ 4 files changed, 97 insertions(+)create mode 100644
drivers/hwmon/pmbus/tda38640.cDocumentation/devicetree/bindings/trivial-devices.yaml +2
-0@@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280drivers/hwmon/pmbus/Kconfig +9
-0@@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640. + + This driver can also be built as a module. If so, the module will + be called tda38640. +Quoted 8 lines
drivers/hwmon/pmbus/Kconfig config SENSORS_STPDDC60 · line 412
Quoted 6 lines
drivers/hwmon/pmbus/Kconfig +6
-0+config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator.Drop entire option, why is it needed?
Quoted 2 lines
You mean regulator option ?
This is how other pmbus regulator devices have provided option.
Hmmm... I wonder why this is of any use.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/hwmon/pmbus/Kconfig +1
-0+ config SENSORS_TPS40422 tristate "TI TPS40422" help
(...)
Quoted 10 lines
Quoted 8 lines
drivers/hwmon/pmbus/Kconfig
Quoted 6 lines
drivers/hwmon/pmbus/Kconfig +5
-0+static const struct of_device_id tda38640_of_match[] = { + { .compatible = "infineon,tda38640"}, + { }, +}; +MODULE_DEVICE_TABLE(of, tda38640_of_match);Where is it used? You miss the user.
I'm not sure if I get your question right. This chip is used in sbp1 board to power CPU rails.
No, where is the data structure used (except module autoloading)?
Best regards,
Krzysztof
Hi
Quoted 61 lines · Krzysztof Kozlowski
Quoted 60 lines · Naresh Solanki
Hi
Quoted 11 lines · Krzysztof Kozlowski
Quoted 8 lines · Naresh Solanki
From: Patrick Rudolph <[email protected]>
Add the pmbus driver for the Infineon TDA38640 voltage regulator.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Naresh Solanki <[email protected]>--- .../devicetree/bindings/trivial-devices.yaml | 2 +Split bindings from driver code.
Sure
Quoted 45 lines
Quoted 33 lines
drivers/hwmon/pmbus/Kconfig | 16 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/tda38640.c | 78 +++++++++++++++++++ 4 files changed, 97 insertions(+)create mode 100644
drivers/hwmon/pmbus/tda38640.cDocumentation/devicetree/bindings/trivial-devices.yaml +2
-0@@ -141,6 +141,8 @@ properties: - infineon,slb9645tt # Infineon SLB9673 I2C TPM 2.0 - infineon,slb9673 + # Infineon TDA38640 Voltage Regulator + - infineon,tda38640 # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor - infineon,tlv493d-a1b6 # Infineon Multi-phase Digital VR Controller xdpe11280drivers/hwmon/pmbus/Kconfig +5
-0@@ -395,6 +395,22 @@ config SENSORS_STPDDC60 This driver can also be built as a module. If so, the module will be called stpddc60. +config SENSORS_TDA38640 + tristate "Infineon TDA38640" + help + If you say yes here you get hardware monitoring support for Infineon + TDA38640.drivers/hwmon/pmbus/Kconfig config SENSORS_STPDDC60 · line 412
Quoted 10 lines
drivers/hwmon/pmbus/Kconfig +10
-0+ + This driver can also be built as a module. If so, the module will + be called tda38640. + +config SENSORS_TDA38640_REGULATOR + bool "Regulator support for TDA38640 and compatibles" + depends on SENSORS_TDA38640 && REGULATOR + help + If you say yes here you get regulator support for Infineon + TDA38640 as regulator.Drop entire option, why is it needed?
Quoted 4 lines
Quoted 2 lines
You mean regulator option ?
This is how other pmbus regulator devices have provided option.Hmmm... I wonder why this is of any use.
From what I can think of. Chip also provide pin to control regulator enable. If that is used in the design then the regulator option may not be needed.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/hwmon/pmbus/Kconfig +1
-0+ config SENSORS_TPS40422 tristate "TI TPS40422" help(...)
Yes this doesn't has regulator support in driver.
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
drivers/hwmon/pmbus/Kconfig
Quoted 7 lines
drivers/hwmon/pmbus/Kconfig +5
-0+static const struct of_device_id tda38640_of_match[] = { + { .compatible = "infineon,tda38640"}, + { }, +}; +MODULE_DEVICE_TABLE(of, tda38640_of_match);Where is it used? You miss the user.
Quoted 4 lines
Quoted 2 lines
I'm not sure if I get your question right. This chip is used in sbp1 board to power CPU rails.
No, where is the data structure used (except module autoloading)?
My use case is loading the driver base on DT. Not sure of other uses.
Quoted 4 lines
Best regards,
Krzysztof
Best Regards,
Naresh
Quoted 8 lines · Naresh Solanki
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/hwmon/pmbus/tda38640.c line 61
Quoted 6 lines
drivers/hwmon/pmbus/tda38640.c new file +5
-0+static const struct of_device_id tda38640_of_match[] = { + { .compatible ="infineon,tda38640" }, + { }, +}; +MODULE_DEVICE_TABLE (of, tda38640_of_match);Where is it used? You miss the user.
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
I'm not sure if I get your question right. This chip is used in sbp1 board to power CPU rails.
No, where is the data structure used (except module autoloading)?
My use case is loading the driver base on DT. Not sure of other uses.
Where is it used in the code?
Best regards,
Krzysztof