Skip to contentSkip to conversation

ARM: dts: stm32: Reinstate card detect behavior on ST boards

PATCH New Patrick Delaunay 2 participants 3 messages Jun 19, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on ST boards

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This avoid potential issue for SDCard boot:
the card detect fails with floating gpio.

Hi,

I don't have boot issue on my boards (DK2 and EV1) but this patch avoids potential issue with floating gpio as issue see by Marek on DHSOM.

To be reverted in v2020.10 when the serie [1] is accepted.

The generic impacts in gpio uclass [2] is already accepted for V2020.07 and merged in master branch.

[1] stm32mp1: activate gpio hog support and add new pinctrl ops
http://patchwork.ozlabs.org/project/uboot/list/?series=181294

[2] dm: add support of new binding in gpio and pincontrol
http://patchwork.ozlabs.org/project/uboot/list/?series=152777&state=*

Patrick

END

---

 arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 2 ++
 arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 2 ++
 2 files changed, 4 insertions(+)
arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi +2 -0
index 3fedb6f1e1..e13dade463 100644
@@ -171,6 +171,8 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
 };
 
 &sdmmc1_b4_pins_a {
arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi +2 -0
index a07c585415..b16dc28d47 100644
@@ -167,6 +167,8 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
 };
 
 &sdmmc1_b4_pins_a {
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on ST boards

Hi Patrick

Quoted 51 lines · Patrick Delaunay

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This avoid potential issue for SDCard boot:
the card detect fails with floating gpio.

Hi,

I don't have boot issue on my boards (DK2 and EV1) but this patch avoids potential issue with floating gpio as issue see by Marek on DHSOM.

To be reverted in v2020.10 when the serie [1] is accepted.

The generic impacts in gpio uclass [2] is already accepted for V2020.07 and merged in master branch.

[1] stm32mp1: activate gpio hog support and add new pinctrl ops
http://patchwork.ozlabs.org/project/uboot/list/?series=181294

[2] dm: add support of new binding in gpio and pincontrol
http://patchwork.ozlabs.org/project/uboot/list/?series=152777&state=*

Patrick

END

---

 arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 2 ++
 arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 2 ++
 2 files changed, 4 insertions(+)
arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi +2 -0
index 3fedb6f1e1..e13dade463 100644
@@ -171,6 +171,8 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
 };
 
 &sdmmc1_b4_pins_a {
arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi +0 -0
index a07c585415..b16dc28d47 100644

arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi line 174

Quoted 8 lines
arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi +2 -0
@@ -167,6 +167,8 @@
 
 &sdmmc1 {
 	u-boot,dm-spl;
+	broken-cd;
+	/delete-property/ cd-gpios;
 };
 
 &sdmmc1_b4_pins_a {

Thanks

Patrice

#2 lore raw

PATCH 1/1 ARM: dts: stm32: Reinstate card detect behavior on ST boards

In reply to Patrick Delaunay

Hi,

Quoted 8 lines

From: Patrick DELAUNAY <[email protected]>
Sent: vendredi 19 juin 2020 11:20

The cd-gpios with (GPIO_ACTIVE_LOW | GPIO_PULL_UP) gpio is thus far unsupported, reinstate the old cd-gpios behavior until this handling is fully implemented. This avoid potential issue for SDCard boot:
the card detect fails with floating gpio.

Quoted 7 lines

---

arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 2 ++ arch/arm/dts/stm32mp157c-
ed1-u-boot.dtsi | 2 ++

 2 files changed, 4 insertions(+)

Applied to u-boot-stm/master, thanks!

But I remove the Commit-note manually (error in patch sent with patman)

Regards

Patrick