riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces
Subsystems (3)
cover riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces
Drop no-mmc and power-on-delay-ms properties.
The committer cannot be reached for comment and per discussion [1] and testing there is not any observable problem that is being solved by having these properties for the VisionFive 2 or similar variant boards through the jh7110-common.dtsi include.
E Shattow (2):
riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 3 --- 1 file changed, 3 deletions(-)
base-commit: f66eb149b87677da3171a0ed51c77c3599ad55d6
Signature · 1 line
2.50.0
PATCH 1/2 riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
Relax no-mmc restriction on mmc1 for jh7110 boards. The restriction is only needed to block use of commands that would cause a device to malfunction, which by testing and observation [1] is not any problem.
--- arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0 -1
@@ -299,7 +299,6 @@ &mmc1 { assigned-clock-rates = <50000000>; bus-width = <4>; bootph-pre-ram; - no-mmc; cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>; disable-wp; cap-sd-highspeed;
Signature · 1 line
2.50.0
PATCH 2/2 riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms
In reply to E ShattowDrop post-power-on-delay-ms from mmc0 mmc1 interfaces. There is no known reason for these properties to continue, testing appears to be fine without them [1].
--- arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0 -2
@@ -285,7 +285,6 @@ &mmc0 { mmc-ddr-1_8v; mmc-hs200-1_8v; cap-mmc-hw-reset; - post-power-on-delay-ms = <200>; pinctrl-names = "default"; pinctrl-0 = <&mmc0_pins>; vmmc-supply = <&vcc_3v3>;
@@ -302,7 +301,6 @@ &mmc1 { cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>; disable-wp; cap-sd-highspeed; - post-power-on-delay-ms = <200>; pinctrl-names = "default"; pinctrl-0 = <&mmc1_pins>; status = "okay";
Signature · 1 line
2.50.0
Quoted 11 lines · E Shattow
Drop no-mmc and power-on-delay-ms properties.
The committer cannot be reached for comment and per discussion [1] and testing there is not any observable problem that is being solved by having these properties for the VisionFive 2 or similar variant boards through the
jh7110-common.dtsiinclude.E Shattow (2):
riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms
Quoted 5 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 3 --- 1 file changed, 3 deletions(-)base-commit:
f66eb149b87677da3171a0ed51c77c3599ad55d6
P.S. missed the URL for reference [1] in this cover letter. It is:
From: Conor Dooley <[email protected]>
Quoted 8 lines · E Shattow
Drop no-mmc and power-on-delay-ms properties.
The committer cannot be reached for comment and per discussion [1] and testing there is not any observable problem that is being solved by having these properties for the VisionFive 2 or similar variant boards through the
jh7110-common.dtsiinclude.[...]
Applied to riscv-dt-for-next, thanks!
[1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
https://git.kernel.org/conor/c/08128670a931 [2/2] riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms https://git.kernel.org/conor/c/b5a861a438d1
Thanks,
Conor.