Skip to contentSkip to conversation

riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces

PATCH Applied E Shattow 2 participants 5 messages Sep 3, 2025 – Sep 8, 2025

Subsystems (3)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

E Shattow

author
#0 lore raw

cover riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces

Drop no-mmc and power-on-delay-ms properties.

The committer cannot be reached for comment and per discussion [1] and testing there is not any observable problem that is being solved by having these properties for the VisionFive 2 or similar variant boards through the jh7110-common.dtsi include.

E Shattow (2):
riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms

 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 3 ---
 1 file changed, 3 deletions(-)

base-commit: f66eb149b87677da3171a0ed51c77c3599ad55d6

Signature · 1 line
2.50.0
author
#1 lore raw

PATCH 1/2 riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1

Relax no-mmc restriction on mmc1 for jh7110 boards. The restriction is only needed to block use of commands that would cause a device to malfunction, which by testing and observation [1] is not any problem.

1: https://lore.kernel.org/lkml/NT0PR01MB1312E0D9EE9F158A57B77700E63D2@NT0PR01MB1312.CHNPR01.prod.partner.outlook.cn/

---
 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0 -1
index a315113840e5..4fa77ffd54e3 100644
@@ -299,7 +299,6 @@ &mmc1 {
 	assigned-clock-rates = <50000000>;
 	bus-width = <4>;
 	bootph-pre-ram;
-	no-mmc;
 	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	cap-sd-highspeed;
Signature · 1 line
2.50.0
author
#2 lore raw

PATCH 2/2 riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms

In reply to E Shattow

Drop post-power-on-delay-ms from mmc0 mmc1 interfaces. There is no known reason for these properties to continue, testing appears to be fine without them [1].

1: https://lore.kernel.org/lkml/NT0PR01MB1312E0D9EE9F158A57B77700E63D2@NT0PR01MB1312.CHNPR01.prod.partner.outlook.cn/

---
 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0 -2
index 4fa77ffd54e3..5dc15e48b74b 100644
@@ -285,7 +285,6 @@ &mmc0 {
 	mmc-ddr-1_8v;
 	mmc-hs200-1_8v;
 	cap-mmc-hw-reset;
-	post-power-on-delay-ms = <200>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins>;
 	vmmc-supply = <&vcc_3v3>;
@@ -302,7 +301,6 @@ &mmc1 {
 	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	cap-sd-highspeed;
-	post-power-on-delay-ms = <200>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
 	status = "okay";
Signature · 1 line
2.50.0
author
#3 lore raw
In reply to E Shattow
Quoted 11 lines · E Shattow

Drop no-mmc and power-on-delay-ms properties.

The committer cannot be reached for comment and per discussion [1] and testing there is not any observable problem that is being solved by having these properties for the VisionFive 2 or similar variant boards through the jh7110-common.dtsi include.

E Shattow (2):
riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms

Quoted 5 lines
 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 3 ---
 1 file changed, 3 deletions(-)

base-commit: f66eb149b87677da3171a0ed51c77c3599ad55d6

P.S. missed the URL for reference [1] in this cover letter. It is:

1:
https://lore.kernel.org/lkml/NT0PR01MB1312E0D9EE9F158A57B77700E63D2@NT0PR01MB1312.CHNPR01.prod.partner.outlook.cn/

maintainer Applied
#4 lore raw
In reply to E Shattow

From: Conor Dooley <[email protected]>

Quoted 8 lines · E Shattow

Drop no-mmc and power-on-delay-ms properties.

The committer cannot be reached for comment and per discussion [1] and testing there is not any observable problem that is being solved by having these properties for the VisionFive 2 or similar variant boards through the jh7110-common.dtsi include.

[...]

Applied to riscv-dt-for-next, thanks!

[1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1

      https://git.kernel.org/conor/c/08128670a931
[2/2] riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms
      https://git.kernel.org/conor/c/b5a861a438d1

Thanks,
Conor.