Skip to contentSkip to conversation

ARM: dts: aspeed: Add Balcones system

PATCH Superseded Eddie James 4 participants 10 messages Feb 20, 2025 – Mar 18, 2025

Subsystems (3)
Device tree bindings Hardware monitoring Arm/Aspeed machine support

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Eddie James

author
#0 lore raw

v2 cover ARM: dts: aspeed: Add Balcones system

The Balcones system is similar to Bonnell but with a POWER11 processor.

Changes since v1:
- Add all the ucd9000 driver supported compatible strings
- Fix node ordering in Balcones device tree
- Improve commit message to explain addition of ibm-power11-dual.dtsi

Eddie James (3):
dt-bindings: arm: aspeed: add IBM Balcones board
dt-bindings: hwmon: ucd90320: Add additional compatible strings
ARM: dts: aspeed: Add Balcones system

 .../bindings/arm/aspeed/aspeed.yaml           |   1 +
 .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 +
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594 +++++++++++++
 .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++
 .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------
 6 files changed, 1383 insertions(+), 767 deletions(-)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts
 create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi
Signature · 1 line
2.43.5
author
#1 lore raw

PATCH v2 1/3 dt-bindings: arm: aspeed: add IBM Balcones board

Document a new AST2600 BMC board for IBM P11 server.

Signed-off-by Eddie James <[email protected]>
Acked-by Krzysztof Kozlowski <[email protected]>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 01333ac111fbb..e80286ff92cc1 100644
@@ -88,6 +88,7 @@ properties:
               - facebook,harma-bmc
               - facebook,minerva-cmc
               - facebook,yosemite4-bmc
+              - ibm,balcones-bmc
               - ibm,blueridge-bmc
               - ibm,everest-bmc
               - ibm,fuji-bmc
Signature · 1 line
2.43.5
author
#2 lore raw

PATCH v2 2/3 dt-bindings: hwmon: ucd90320: Add additional compatible strings

In reply to Eddie James

The device driver for the UCD90XXX chips supports several more chips than just the 90320, so document them.

Signed-off-by Eddie James <[email protected]>

---
Changes since v1:
- Add all supported devices

 .../devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml        | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml +6 -0
index e8feee38c76c8..3cfcbf6b58f2e 100644
@@ -23,7 +23,13 @@ description: |
 properties:
   compatible:
     enum:
+      - ti,ucd90000
+      - ti,ucd90120
+      - ti,ucd90124
+      - ti,ucd90160
       - ti,ucd90320
+      - ti,ucd90910
+      - ti,ucd9090
 
   reg:
     maxItems: 1
Signature · 1 line
2.43.5
Reviewed-by on v2 2/3
#3 lore raw

Re: [PATCH v2 2/3] dt-bindings: hwmon: ucd90320: Add additional compatible strings

Quoted 16 lines · Eddie James

The device driver for the UCD90XXX chips supports several more chips than just the 90320, so document them.

Signed-off-by Eddie James <[email protected]>

---
Changes since v1:
- Add all supported devices

 .../devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml        | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml +0 -0
index e8feee38c76c8..3cfcbf6b58f2e 100644

Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml description: | · line 32

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/pmbus/ti,ucd90320.yaml +6 -0
@@ -23,7 +23,13 @@ description: |
 properties:
   compatible:
     enum:
+      - ti,ucd90000
+      - ti,ucd90120
+      - ti,ucd90124
+      - ti,ucd90160
       - ti,ucd90320
+      - ti,ucd90910
+      - ti,ucd9090

Last two have mismatched order. What's interesting, driver has it correct.

With order fixed:

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

author
#4 lore raw

PATCH v2 3/3 ARM: dts: aspeed: Add Balcones system

In reply to Eddie James

The Balcones system is similar to Bonnell but with a POWER11 processor. Like POWER10, the POWER11 is a dual-chip module, so a dual chip FSI tree is needed. Therefore, split up the quad chip FSI tree.

Signed-off-by Eddie James <[email protected]>

---
Changes since v1:
- Re-order nodes
- Improve commit message for ibm-power11-dual.dtsi

 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594 +++++++++++++
 .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++
 .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------
 4 files changed, 1376 insertions(+), 767 deletions(-)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts
 create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi
arch/arm/boot/dts/aspeed/Makefile +1 -0
index 2e5f4833a073b..71b2d67fdbac8 100644
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-yamp.dtb \
 	aspeed-bmc-facebook-yosemitev2.dtb \
 	aspeed-bmc-facebook-yosemite4.dtb \
+	aspeed-bmc-ibm-balcones.dtb \
 	aspeed-bmc-ibm-blueridge.dtb \
 	aspeed-bmc-ibm-bonnell.dtb \
 	aspeed-bmc-ibm-everest.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts new file +594 -0

594 lines not on this page · raw message

arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi new file +779 -0

779 lines not on this page · raw message

arch/arm/boot/dts/aspeed/ibm-power11-quad.dtsi +2 -767

802 lines not on this page · raw message

Signature · 1 line
2.43.5
maintainer
#5 lore raw
In reply to Eddie James
Quoted 22 lines · Eddie James

The Balcones system is similar to Bonnell but with a POWER11 processor.

Changes since v1:
- Add all the ucd9000 driver supported compatible strings
- Fix node ordering in Balcones device tree
- Improve commit message to explain addition of ibm-power11-dual.dtsi

Eddie James (3):
dt-bindings: arm: aspeed: add IBM Balcones board
dt-bindings: hwmon: ucd90320: Add additional compatible strings
ARM: dts: aspeed: Add Balcones system

 .../bindings/arm/aspeed/aspeed.yaml           |   1 +
 .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 +
 arch/arm/boot/dts/aspeed/Makefile             |   1 +
 .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594 +++++++++++++
 .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++
 .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------
 6 files changed, 1383 insertions(+), 767 deletions(-)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts
 create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi
Quoted 5 lines

--
2.43.5

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for [email protected]:

arch/arm/boot/dts/aspeed/aspeed-ast2500-evb.dtb: /ahb/apb/pwm-tacho-controller@1e786000: failed to match any schema with compatible: ['aspeed,ast2500-pwm-tacho'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-minipack.dtb: /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2500-lhc']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: timer: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/timer/arm,arch_timer.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /sdram@1e6e0000: failed to match any schema with compatible: ['aspeed,ast2600-sdram-edac', 'syscon']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: bus@1e600000: compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long
from schema $id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: syscon@1e6e2000: 'smp-memram@180' does not match any of the regexes: '^interrupt-controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', '^silicon-id@[0-9a-f]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/syscon@1e6e2000/smp-memram@180: failed to match any schema with compatible: ['aspeed,ast2600-smpmem'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/syscon@1e6e2000/interrupt-controller@560: failed to match any schema with compatible: ['aspeed,ast2600-scu-ic0'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/syscon@1e6e2000/interrupt-controller@570: failed to match any schema with compatible: ['aspeed,ast2600-scu-ic1'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/display@1e6e6000: failed to match any schema with compatible: ['aspeed,ast2600-gfx', 'syscon']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: adc@1e6e9000: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: adc@1e6e9100: 'interrupts' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: crypto@1e6fa000: 'aspeed,ahbc' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/crypto/aspeed,ast2600-acry.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/video@1e700000: failed to match any schema with compatible: ['aspeed,ast2600-video-engine']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: gpio@1e780000: 'usb-power-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/timer@1e782000: failed to match any schema with compatible: ['aspeed,ast2600-timer']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: lpc@1e789000: lpc-snoop@80: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: lpc@1e789000: reg-io-width: 4 is not of type 'object'
from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: kcs@24: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: kcs@28: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: kcs@2c: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: kcs@114: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/ipmi/aspeed,ast2400-kcs-bmc.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/lpc@1e789000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2600-lhc']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/lpc@1e789000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2600-ibt-bmc']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: sdc@1e740000: sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long
from schema $id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: sdc@1e740000: sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long
from schema $id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/sdc@1e740000/sdhci@1e740100: failed to match any schema with compatible: ['aspeed,ast2600-sdhci', 'sdhci'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/sdc@1e740000/sdhci@1e740200: failed to match any schema with compatible: ['aspeed,ast2600-sdhci', 'sdhci'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any schema with compatible: ['maxim,max31785a']
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: pressure-sensor@76: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: fsi@1e79b000: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long
from schema $id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/fsi@1e79b000: failed to match any schema with compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: fsi@1e79b100: compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] is too long
from schema $id: http://devicetree.org/schemas/fsi/aspeed,ast2600-fsi-master.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/fsi@1e79b100: failed to match any schema with compatible: ['aspeed,ast2600-fsi-master', 'fsi-master'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/dma-controller@1e79e000: failed to match any schema with compatible: ['aspeed,ast2600-udma'] arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: lpc@1e789000: reg-io-width: 4 is not of type 'object'
from schema $id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml#

maintainer
#6 lore raw
Quoted 34 lines · Rob Herring (Arm)
Quoted 18 lines · Eddie James

The Balcones system is similar to Bonnell but with a POWER11 processor.

Changes since v1:
 - Add all the ucd9000 driver supported compatible strings
 - Fix node ordering in Balcones device tree
 - Improve commit message to explain addition of ibm-power11-dual.dtsi

Eddie James (3):
  dt-bindings: arm: aspeed: add IBM Balcones board
  dt-bindings: hwmon: ucd90320: Add additional compatible strings
  ARM: dts: aspeed: Add Balcones system

 .../bindings/arm/aspeed/aspeed.yaml           |   1 + .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 + arch/arm/boot/dts/aspeed/Makefile             |   1 + .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594 +++++++++++++ .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++ .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------

Quoted 9 lines
 6 files changed, 1383 insertions(+), 767 deletions(-)

 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi

--
2.43.5

My bot found new DTB warnings on the .dts files added or changed in this series.

...

Quoted 2 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: gpio@1e780000: 'usb-power-hog' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#

Ah, can you address this one?

Quoted 3 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any schema with compatible: ['maxim,max31785a'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: pressure-sensor@76: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#

And these also?

The rest looked like the usual noise.

Andrew

author
#7 lore raw
Quoted 37 lines · Andrew Jeffery
Quoted 32 lines · Rob Herring (Arm)
Quoted 19 lines · Eddie James

The Balcones system is similar to Bonnell but with a POWER11 processor.

Changes since v1:
 - Add all the ucd9000 driver supported compatible strings
 - Fix node ordering in Balcones device tree
 - Improve commit message to explain addition of ibm-power11-dual.dtsi

Eddie James (3):
  dt-bindings: arm: aspeed: add IBM Balcones board
  dt-bindings: hwmon: ucd90320: Add additional compatible strings
  ARM: dts: aspeed: Add Balcones system

  .../bindings/arm/aspeed/aspeed.yaml           |   1 +
  .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 +
  arch/arm/boot/dts/aspeed/Makefile             |   1 +
  .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594 +++++++++++++
  .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++
  .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------
  6 files changed, 1383 insertions(+), 767 deletions(-)
Quoted 8 lines

 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi

--
2.43.5

My bot found new DTB warnings on the .dts files added or changed in this series.

...

Quoted 2 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: gpio@1e780000: 'usb-power-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#

Quoted 8 lines

Ah, can you address this one?

Quoted 3 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any schema with compatible: ['maxim,max31785a'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: pressure-sensor@76: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#

And these also?

The rest looked like the usual noise.

Well, all of these errors are also present in Blueridge. I would need to write a new binding for dps310, move max31785 to yaml format, and I'm not sure how to fix the gpio hog one. I don't see that error when I run CHECK_DTBS myself... any suggestions?

Thanks!

Eddie

Quoted 3 lines

Andrew

maintainer
#8 lore raw
Quoted 47 lines · Eddie James
Quoted 44 lines · Andrew Jeffery
Quoted 32 lines · Rob Herring (Arm)
Quoted 19 lines · Eddie James

The Balcones system is similar to Bonnell but with a POWER11 processor.

Changes since v1:
- Add all the ucd9000 driver supported compatible strings
- Fix node ordering in Balcones device tree
- Improve commit message to explain addition of ibm-power11-dual.dtsi

Eddie James (3):
dt-bindings: arm: aspeed: add IBM Balcones board
dt-bindings: hwmon: ucd90320: Add additional compatible strings
ARM: dts: aspeed: Add Balcones system

  .../bindings/arm/aspeed/aspeed.yaml           |   1 +
  .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 +
  arch/arm/boot/dts/aspeed/Makefile             |   1 +
  .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594 +++++++++++++
  .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779 ++++++++++++++++++
  .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +----------------
  6 files changed, 1383 insertions(+), 767 deletions(-)
Quoted 8 lines

create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dts create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11-dual.dtsi

--
2.43.5

My bot found new DTB warnings on the .dts files added or changed in this series.

...

Quoted 2 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: gpio@1e780000: 'usb-power-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#

Ah, can you address this one?

Quoted 3 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: /ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any schema with compatible: ['maxim,max31785a'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb: pressure-sensor@76: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#

And these also?

Quoted 7 lines
Quoted 1 line

The rest looked like the usual noise.

Well, all of these errors are also present in Blueridge. I would need to write a new binding for dps310, move max31785 to yaml format, and I'm not sure how to fix the gpio hog one. I don't see that error when I run CHECK_DTBS myself... any suggestions?

I think the hog one got fixed recently. The tests run on top of whatever b4 picks for the base or linux-next if it can't figure out the base. So that might be the difference.

Rob

maintainer
#9 lore raw
Quoted 77 lines · Rob Herring
Quoted 67 lines · Eddie James
Quoted 59 lines · Andrew Jeffery
Quoted 41 lines · Rob Herring (Arm)
Quoted 24 lines · Eddie James

The Balcones system is similar to Bonnell but with a POWER11 processor.

Changes since v1:
  - Add all the ucd9000 driver supported compatible strings
  - Fix node ordering in Balcones device tree
  - Improve commit message to explain addition of ibm- power11-dual.dtsi

Eddie James (3):
   dt-bindings: arm: aspeed: add IBM Balcones board
   dt-bindings: hwmon: ucd90320: Add additional compatible strings
   ARM: dts: aspeed: Add Balcones system

  .../bindings/arm/aspeed/aspeed.yaml           |   1 + .../bindings/hwmon/pmbus/ti,ucd90320.yaml     |   6 + arch/arm/boot/dts/aspeed/Makefile             |   1 + .../dts/aspeed/aspeed-bmc-ibm-balcones.dts    | 594
+++++++++++++
  .../arm/boot/dts/aspeed/ibm-power11-dual.dtsi | 779
++++++++++++++++++
  .../arm/boot/dts/aspeed/ibm-power11-quad.dtsi | 769 +------
----------

Quoted 11 lines
  6 files changed, 1383 insertions(+), 767 deletions(-)

  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm- balcones.dts
  create mode 100644 arch/arm/boot/dts/aspeed/ibm-power11- dual.dtsi

--
2.43.5

My bot found new DTB warnings on the .dts files added or changed in this
series.

...

Quoted 5 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
gpio@1e780000: 'usb-power-hog' does not match any of the
regexes: 'pinctrl-[0-9]+'
         from schema $id:
http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#

Ah, can you address this one?

Quoted 8 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
/ahb/apb/bus@1e78a000/i2c@400/pwm@53: failed to match any schema with compatible: ['maxim,max31785a'] arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-balcones.dtb:
pressure-sensor@76: '#io-channel-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
         from schema $id:
http://devicetree.org/schemas/trivial-devices.yaml#

Quoted 3 lines

And these also?

The rest looked like the usual noise.

Quoted 7 lines

Well, all of these errors are also present in Blueridge. I would need to
write a new binding for dps310, move max31785 to yaml format, and I'm
not sure how to fix the gpio hog one. I don't see that error when I run
CHECK_DTBS myself... any suggestions?

Quoted 3 lines

I think the hog one got fixed recently. The tests run on top of whatever b4 picks for the base or linux-next if it can't figure out the base. So that might be the difference.

Eddie: Yeah, disregard the hog one. An alternative to writing/converting the bindings is dropping the relevant nodes for now, and adding them back once the bindings have been dealt with. Up to you.

Andrew