Skip to contentSkip to conversation

runqueue: Add a progress meter for checking the task stamps

PATCH Superseded Peter Kjellerstedt 1 participant 2 messages Aug 16, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 runqueue: Add a progress meter for checking the task stamps

---
 bitbake/lib/bb/runqueue.py | 8 ++++++++
 1 file changed, 8 insertions(+)
bitbake/lib/bb/runqueue.py +8 -0
index 7fa074f679..61ef864649 100644
@@ -2672,9 +2672,16 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
         stamppresent = []
         tocheck = set()
 
+        msg = "Check task stamps"
+        bb.event.fire(bb.event.ProcessStarted(msg, len(sqdata.sq_revdeps)), cooker.data)
+
+        checked = 0
         for tid in sorted(sqdata.sq_revdeps):
             (mc, fn, taskname, taskfn) = split_tid_mcfn(tid)
 
+            checked = checked + 1
+            bb.event.fire(bb.event.ProcessProgress(msg, checked), cooker.data)
+
             taskdep = rqdata.dataCaches[mc].task_deps[taskfn]
 
             if 'noexec' in taskdep and taskname in taskdep['noexec']:
@@ -2696,6 +2703,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
                 continue
 
             tocheck.add(tid)
+        bb.event.fire(bb.event.ProcessFinished(msg), cooker.data)
 
         valid = rq.validate_hashes(tocheck, cooker.data, len(stamppresent), False)
 
Signature · 1 line
2.21.0
#1 lore raw
Quoted 16 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Peter Kjellerstedt
Sent: den 16 augusti 2019 12:42
To: [email protected]
Subject: [bitbake-devel] [PATCH] runqueue: Add a progress meter for checking the task stamps

---
 bitbake/lib/bb/runqueue.py | 8 ++++++++
 1 file changed, 8 insertions(+)
bitbake/lib/bb/runqueue.py +0 -0
index 7fa074f679..61ef864649 100644

bitbake/lib/bb/runqueue.py def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): · line 2675

Quoted 4 lines
bitbake/lib/bb/runqueue.py +1 -0
@@ -2672,9 +2672,16 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
         stamppresent = []
         tocheck = set()
 
+        msg = "Check task stamps"

I do not know if this message makes sense. The commit message is also on the short side. Feel free to modify them or suggest improvements.

Quoted 21 lines
bitbake/lib/bb/runqueue.py +7 -1
+        bb.event.fire(bb.event.ProcessStarted(msg, len(sqdata.sq_revdeps)), cooker.data)
+
+        checked = 0
         for tid in sorted(sqdata.sq_revdeps):
             (mc, fn, taskname, taskfn) = split_tid_mcfn(tid)
 
+            checked = checked + 1
+            bb.event.fire(bb.event.ProcessProgress(msg, checked), cooker.data)
+
             taskdep = rqdata.dataCaches[mc].task_deps[taskfn]
 
             if 'noexec' in taskdep and taskname in taskdep['noexec']:
@@ -2696,6 +2703,7 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
                 continue
 
             tocheck.add(tid)
+        bb.event.fire(bb.event.ProcessFinished(msg), cooker.data)
 
         valid = rq.validate_hashes(tocheck, cooker.data, len(stamppresent), False)
 
--
Quoted 1 line

2.21.0

//Peter