Declare -realtime as deprecated
PATCH 1/1 Declare -realtime as deprecated
The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option.
---
Deprecation has already been suggested last year:
https://patchwork.kernel.org/patch/10480963/#22026215
... but apparently we forgot to really do it.
qemu-deprecated.texi | 5 +++++ vl.c | 2 ++ 2 files changed, 7 insertions(+)
qemu-deprecated.texi +5 -0
@@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. +@subsection -realtime (since 4.1) + +The @code{-realtime mlock=on|off} argument has been replaced by the +@code{-overcommit mem-lock=on|off} argument. + @section QEMU Machine Protocol (QMP) commands @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)
vl.c +2 -0
@@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp) }break ;case QEMU_OPTION_realtime: +warn_report ("'-realtime mlock=...' is deprecated, please use " +"'-overcommit mem-lock=...' instead" ); opts =qemu_opts_parse_noisily (qemu_find_opts ("realtime" ), optarg, false);if (!opts) {
Signature · 1 line
2.21.0
Quoted 5 lines · Thomas Huth
The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option.
FYI libvirt currently uses -realtime mlock=on so will need adapting to cope with this change.
Quoted 47 lines
Signed-off-by Thomas Huth <[email protected]>---
Deprecation has already been suggested last year:
https://patchwork.kernel.org/patch/10480963/#22026215
... but apparently we forgot to really do it.qemu-deprecated.texi | 5 +++++ vl.c | 2 ++ 2 files changed, 7 insertions(+)qemu-deprecated.texi +5
-0@@ -72,6 +72,11 @@ backend settings instead of environment variables. To ease migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. +@subsection -realtime (since 4.1) + +The @code{-realtime mlock=on|off} argument has been replaced by the +@code{-overcommit mem-lock=on|off} argument. + @section QEMU Machine Protocol (QMP) commands @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)vl.c +2
-0@@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp) }break ;case QEMU_OPTION_realtime: +warn_report ("'-realtime mlock=...' is deprecated, please use " +"'-overcommit mem-lock=...' instead" ); opts =qemu_opts_parse_noisily (qemu_find_opts ("realtime" ), optarg, false);if (!opts) {Signature · 6 lines
2.21.0 -- libvir-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/libvir-list
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 9 lines · Daniel P. Berrangé
Quoted 5 lines · Thomas Huth
The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option.
FYI libvirt currently uses -realtime mlock=on so will need adapting to cope with this change.
Done:
e8c2c8bd07 qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock' be51feff69 qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT a08c4b3741 qemu: Always assume QEMU_CAPS_REALTIME_MLOCK
Therefore, from libvirt's POV this patch is okay to go in.
Michal
Quoted 7 lines · Thomas Huth
The old -realtime mlock=on|off parameter does exactly the same as the new -overcommit mem-lock=on|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option.
Signed-off-by Thomas Huth <[email protected]>
Paolo, do you want to queue this, or should I do it through the machine queue?
Signature · 1 line
Eduardo
Quoted 9 lines · Eduardo Habkost
Quoted 3 lines
let's deprecate the old -realtime option.
Signed-off-by Thomas Huth <[email protected]>Reviewed-by Eduardo Habkost <[email protected]>Paolo, do you want to queue this, or should I do it through the machine queue?
-- Eduardo
I have just queued it.
Paolo