Skip to contentSkip to conversation

ARM: dts: add ohci and ehci controller nodes for EXYNOS5440

PATCH New Kukjin Kim 1 participant 2 messages Jun 6, 2013

Subsystems (2)
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/1 ARM: dts: add ohci and ehci controller nodes for EXYNOS5440

From: Thomas Abraham <[email protected]>

EXYNOS5440 includes both OHCI and EHCI usb host controllers. Add device tree nodes for both of these controllers.

---
 arch/arm/boot/dts/exynos5440.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/boot/dts/exynos5440.dtsi +15 -0
index 2607739..f3faabf 100644
@@ -225,4 +225,19 @@
 		clock-names = "sata";
 	};
 
+	ohci at 220000 {
+		compatible = "samsung,exynos-ohci";
+		reg = <0x220000 0x1000>;
+		interrupts = <0 29 0>;
+		clocks = <&clock 24>;
+		clock-names = "usbhost";
+	};
+
+	ehci at 221000 {
+		compatible = "samsung,exynos-ehci";
+		reg = <0x221000 0x1000>;
+		interrupts = <0 29 0>;
+		clocks = <&clock 24>;
+		clock-names = "usbhost";
+	};
 };
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 1/1 ARM: dts: add ohci and ehci controller nodes for EXYNOS5440

Quoted 6 lines · Kukjin Kim

From: Thomas Abraham <[email protected]>

EXYNOS5440 includes both OHCI and EHCI usb host controllers. Add device tree nodes for both of these controllers.

Review

Quoted 7 lines
---
 arch/arm/boot/dts/exynos5440.dtsi |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/exynos5440.dtsi

arch/arm/boot/dts/exynos5440.dtsi line 229

Quoted 9 lines

index 2607739..f3faabf 100644

arch/arm/boot/dts/exynos5440.dtsi +2 -0
@@ -225,4 +225,19 @@
 		clock-names = "sata";
 	};
 
+	ohci at 220000 {
+		compatible = "samsung,exynos-ohci";

Oops, the EHCI and OHCI controllers on exynos5440 do not need any explicit phy configuration.
So need to assign a different compatible value for these controllers...

If no problem, let me take this patch into samsung tree with fix.

+ compatible = "samsung,exynos5440-ohci";

arch/arm/boot/dts/exynos5440.dtsi line 237

Quoted 8 lines
arch/arm/boot/dts/exynos5440.dtsi +8 -0
+		reg = <0x220000 0x1000>;
+		interrupts = <0 29 0>;
+		clocks = <&clock 24>;
+		clock-names = "usbhost";
+	};
+
+	ehci at 221000 {
+		compatible = "samsung,exynos-ehci";

Same as above.

+ compatible = "samsung,exynos5440-ehci";

Quoted 8 lines
arch/arm/boot/dts/exynos5440.dtsi +5 -1
+		reg = <0x221000 0x1000>;
+		interrupts = <0 29 0>;
+		clocks = <&clock 24>;
+		clock-names = "usbhost";
+	};
 };
--

1.7.10.4