Skip to contentSkip to conversation

ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

PATCH In review Jiri Slaby (SUSE) 2 participants 3 messages Apr 18, 2023 – Jul 17, 2023 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using acpi_video for backlight control. But this is not functional on this model.

Add a DMI quirk to use the native backlight interface which works.

---

Notes:
[v2] fix authorship

 drivers/acpi/video_detect.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/acpi/video_detect.c +9 -0
index 69ef2d9710c2..af5cea005f54 100644
@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
 		},
 	},
+	{
+	 /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
+	 .callback = video_detect_force_native,
+	 /* Lenovo Ideapad Z470 */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
+		},
+	},
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
 	 .callback = video_detect_force_native,
Signature · 1 line
2.40.0
author
#1 lore raw

Hi,

this has been likely lost. Should I resend?

Thanks.

Quoted 38 lines · Jiri Slaby (SUSE)

The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using acpi_video for backlight control. But this is not functional on this model.

Add a DMI quirk to use the native backlight interface which works.

---

Notes:
[v2] fix authorship

  drivers/acpi/video_detect.c | 9 +++++++++
  1 file changed, 9 insertions(+)
drivers/acpi/video_detect.c +9 -0
index 69ef2d9710c2..af5cea005f54 100644
@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
  		DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
  		},
  	},
+	{
+	 /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
+	 .callback = video_detect_force_native,
+	 /* Lenovo Ideapad Z470 */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
+		},
+	},
  	{
  	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
  	 .callback = video_detect_force_native,
Signature · 2 lines
js
suse labs
#2 lore raw
Quoted 4 lines · Jiri Slaby

Hi,

this has been likely lost.

Yes, it has, sorry about that.

It's better to CC ACPI-related patches to [email protected], so they are included in my normal flow, to avoid such events.

Quoted 1 line

Should I resend?

No need, I've just applied it as 6.6 material.

Thanks!