Skip to contentSkip to conversation

dm: MIGRATION: Add migration plan for DM_MMC

PATCH Superseded Tom Rini 4 participants 14 messages Nov 29, 2018 Kbuild

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 8 ++++++++
 doc/driver-model/MIGRATION.txt | 9 +++++++++
 2 files changed, 17 insertions(+)
Makefile +8 -0
index a4b1d1db5241..0ab48f9ac97f 100644
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
 	@echo "before sending patches to the mailing list."
 	@echo "===================================================="
 endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_MMC. Please update"
+	@echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
 	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +9 -0
index 5ebefd608b99..71c26571828a 100644
@@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in
 2014. This file describes the schedule for deprecation of pre-driver-model
 features.
 
+CONFIG_DM_MMC
+-------------
+
+Status: In progress
+Deadline: 2019.04
+
+The subsystem itself has been converted and maintainers should submit patches
+switching over to using CONFIG_DM_MMC and other base driver model options in
+time for inclusion in the 2019.04 rerelease.
 
 CONFIG_BLK
 ----------
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v2 2/4 dm: MIGRATION: Add migration plan for DM_USB

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       |  8 ++++++++
 doc/driver-model/MIGRATION.txt | 10 ++++++++++
 2 files changed, 18 insertions(+)
Makefile +8 -0
index 0ab48f9ac97f..c8e90566e37a 100644
@@ -928,6 +928,14 @@ ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
 	@echo "See doc/driver-model/MIGRATION.txt for more info."
 	@echo "===================================================="
 endif
+ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_USB. Please update"
+	@echo "the board to use CONFIG_DM_USB before the v2019.07 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
 	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +10 -0
index 71c26571828a..0b763f72a453 100644
@@ -15,6 +15,16 @@ The subsystem itself has been converted and maintainers should submit patches
 switching over to using CONFIG_DM_MMC and other base driver model options in
 time for inclusion in the 2019.04 rerelease.
 
+CONFIG_DM_USB
+-------------
+
+Status: In progress
+Deadline: 2019.07
+
+The subsystem itself has been converted along with many of the host controller
+and maintainers should submit patches switching over to using CONFIG_DM_USB and
+other base driver model options in time for inclusion in the 2019.07 rerelease.
+
 CONFIG_BLK
 ----------
 
Signature · 1 line
2.7.4
#2 lore raw

PATCH v2 2/4 dm: MIGRATION: Add migration plan for DM_USB

Quoted 7 lines · Tom Rini

As much of the USB system has been migrated to DM now, formalize a deadline for migration.

Cc Marek Vasut <[email protected]>
Cc Simon Glass <[email protected]>
Quoted 7 lines

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       |  8 ++++++++
 doc/driver-model/MIGRATION.txt | 10 ++++++++++
 2 files changed, 18 insertions(+)
author
#4 lore raw

PATCH v2 3/4 dm: MIGRATION: Add migration plan for CONFIG_SATA

In reply to Tom Rini

As the core of the subsystem has been converted along with some of the drivers, formalize a deadline for migration.

Cc Akshay Bhat <[email protected]>
Cc Andreas Geisreiter <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christian Gmeiner <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Jason Liu <[email protected]>
Cc Ken Lin <[email protected]>
Cc Ludwig Zenz <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Max Krummenacher <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc Soeren Moch <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Tim Harvey <[email protected]>
Cc Troy Kisky <[email protected]>
Cc Tuomas Tynkkynen <[email protected]>
Cc York Sun <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.
- Even more Ccs

Apologies for the scattershot CC list here. A problem with this particular migration is we have a number of drivers for older platforms without clear ownership. Please feel free to loop in other people you know that might have interest here. Thanks!

---
 Makefile                       |  8 ++++++++
 doc/driver-model/MIGRATION.txt | 10 ++++++++++
 2 files changed, 18 insertions(+)
Makefile +8 -0
index c8e90566e37a..1adf5f4bf72a 100644
@@ -936,6 +936,14 @@ ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
 	@echo "See doc/driver-model/MIGRATION.txt for more info."
 	@echo "===================================================="
 endif
+ifeq ($(CONFIG_LIBATA)$(CONFIG_DM_SCSI)$(CONFIG_MVSATA_IDE),y)
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_SCSI. Please update"
+	@echo "the storage controller to use CONFIG_DM_SCSI before the v2019.07 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
 	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +10 -0
index 0b763f72a453..6df7e02a63de 100644
@@ -25,6 +25,16 @@ The subsystem itself has been converted along with many of the host controller
 and maintainers should submit patches switching over to using CONFIG_DM_USB and
 other base driver model options in time for inclusion in the 2019.07 rerelease.
 
+CONFIG_SATA
+-----------
+
+Status: In progress
+Deadline: 2019.07
+
+The subsystem itself has been converted along with many of the host controller
+and maintainers should submit patches switching over to using CONFIG_AHCI and
+other base driver model options in time for inclusion in the 2019.07 rerelease.
+
 CONFIG_BLK
 ----------
 
Signature · 1 line
2.7.4
#5 lore raw

PATCH v2 3/4 dm: MIGRATION: Add migration plan for CONFIG_SATA

Quoted 31 lines · Tom Rini

As the core of the subsystem has been converted along with some of the drivers, formalize a deadline for migration.

Cc Akshay Bhat <[email protected]>
Cc Andreas Geisreiter <[email protected]>
Cc Bin Meng <[email protected]>
Cc Christian Gmeiner <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Jason Liu <[email protected]>
Cc Ken Lin <[email protected]>
Cc Ludwig Zenz <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Max Krummenacher <[email protected]>
Cc Nikita Kiryanov <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Peng Fan <[email protected]>
Cc Simon Glass <[email protected]>
Cc Soeren Moch <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Stefano Babic <[email protected]>
Cc Tim Harvey <[email protected]>
Cc Troy Kisky <[email protected]>
Cc Tuomas Tynkkynen <[email protected]>
Cc York Sun <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.
- Even more Ccs

Quoted 8 lines

Apologies for the scattershot CC list here. A problem with this particular migration is we have a number of drivers for older platforms without clear ownership. Please feel free to loop in other people you know that might have interest here. Thanks!

---
 Makefile                       |  8 ++++++++
 doc/driver-model/MIGRATION.txt | 10 ++++++++++
 2 files changed, 18 insertions(+)

Regards,
Simon

author
#6 lore raw

PATCH v2 4/4 dm: MIGRATION: Update migration plan for BLK

In reply to Tom Rini

The biggest part of migration to using CONFIG_BLK is that we need to have the various subsystems migrated first, so reword the plan here to reference the new deadlines.

---
 doc/driver-model/MIGRATION.txt | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
doc/driver-model/MIGRATION.txt +5 -7
index 6df7e02a63de..6b691338b4e7 100644
@@ -39,14 +39,12 @@ CONFIG_BLK
 ----------
 
 Status: In progress
-Deadline: 2018.05
-
-Maintainers should submit patches for enabling CONFIG_BLK on all boards in
-time for inclusion in the 2018.05 release. Boards not converted by this
-time may be removed in a subsequent release.
+Deadline: 2019.07
 
-Note that this implies use of driver model for all block devices (e.g.
-MMC, USB, SCSI, SATA).
+In concert with maintainers migrating their block device usage to the
+appropriate DM driver, CONFIG_BLK needs to be set as well.  The final deadline
+here coincides with the final deadline for migration of the various block
+subsystems.
 
 CONFIG_DM_SPI
 CONFIG_DM_SPI_FLASH
Signature · 1 line
2.7.4
#7 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

In reply to Tom Rini
Quoted 8 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>
Quoted 7 lines

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 8 ++++++++
 doc/driver-model/MIGRATION.txt | 9 +++++++++
 2 files changed, 17 insertions(+)

Would be good to get Marek and a few of the others that didn't notice the migration to ack this.

- Simon

#8 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

In reply to Tom Rini
Quoted 20 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
  Makefile                       | 8 ++++++++
  doc/driver-model/MIGRATION.txt | 9 +++++++++
  2 files changed, 17 insertions(+)
Makefile +0 -0
index a4b1d1db5241..0ab48f9ac97f 100644

Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 923

Quoted 4 lines
Makefile +1 -0
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
  	@echo "before sending patches to the mailing list."
  	@echo "===================================================="
  endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.

I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)

Simon

Quoted 30 lines
Makefile +7 -0
+	@echo "===================== WARNING ======================"
+	@echo "This board does not use CONFIG_DM_MMC. Please update"
+	@echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
+	@echo "Failure to update by the deadline may result in board removal."
+	@echo "See doc/driver-model/MIGRATION.txt for more info."
+	@echo "===================================================="
+endif
  	@# Check that this build does not use CONFIG options that we do not
  	@# know about unless they are in Kconfig. All the existing CONFIG
  	@# options are whitelisted, so new ones should not be added.
doc/driver-model/MIGRATION.txt +9 -0
index 5ebefd608b99..71c26571828a 100644
@@ -5,6 +5,15 @@ U-Boot has been migrating to a new driver model since its introduction in
  2014. This file describes the schedule for deprecation of pre-driver-model
  features.
 
+CONFIG_DM_MMC
+-------------
+
+Status: In progress
+Deadline: 2019.04
+
+The subsystem itself has been converted and maintainers should submit patches
+switching over to using CONFIG_DM_MMC and other base driver model options in
+time for inclusion in the 2019.04 rerelease.
 
  CONFIG_BLK
  ----------
author
#9 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Quoted 31 lines · Simon Goldschmidt
Quoted 20 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 8 ++++++++
 doc/driver-model/MIGRATION.txt | 9 +++++++++
 2 files changed, 17 insertions(+)
Makefile +0 -0
index a4b1d1db5241..0ab48f9ac97f 100644

Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 923

Quoted 4 lines
Makefile +1 -0
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
 	@echo "before sending patches to the mailing list."
 	@echo "===================================================="
 endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.

Quoted 3 lines

I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)

Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/b8f73bce/attachment.sig>
#10 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Quoted 31 lines · Tom Rini
Quoted 30 lines · Simon Goldschmidt
Quoted 20 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
  Makefile                       | 8 ++++++++
  doc/driver-model/MIGRATION.txt | 9 +++++++++
  2 files changed, 17 insertions(+)
Makefile +0 -0
index a4b1d1db5241..0ab48f9ac97f 100644

Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 923

Quoted 4 lines
Makefile +1 -0
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
  	@echo "before sending patches to the mailing list."
  	@echo "===================================================="
  endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.

Quoted 7 lines
Quoted 3 lines

I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)

Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.

I would have suggested that, but I hesitated since I can enable CONFIG_DM_MMC without enabling CONFIG_MMC...

Regards,
Simon

author
#11 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Quoted 35 lines · Simon Goldschmidt
Quoted 34 lines · Tom Rini
Quoted 33 lines · Simon Goldschmidt
Quoted 20 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 8 ++++++++
 doc/driver-model/MIGRATION.txt | 9 +++++++++
 2 files changed, 17 insertions(+)
Makefile +0 -0
index a4b1d1db5241..0ab48f9ac97f 100644

Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 923

Quoted 4 lines
Makefile +1 -0
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
 	@echo "before sending patches to the mailing list."
 	@echo "===================================================="
 endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.

I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)

Quoted 7 lines
Quoted 4 lines

Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.

I would have suggested that, but I hesitated since I can enable CONFIG_DM_MMC without enabling CONFIG_MMC...

Ha. I bet it won't work in the end 'tho, we only traverse drivers/mmc/ with CONFIG_MMC=y. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/60b8b590/attachment.sig>
#12 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

In reply to Tom Rini
Quoted 31 lines · Tom Rini
Quoted 30 lines · Simon Goldschmidt
Quoted 20 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
  Makefile                       | 8 ++++++++
  doc/driver-model/MIGRATION.txt | 9 +++++++++
  2 files changed, 17 insertions(+)
Makefile +0 -0
index a4b1d1db5241..0ab48f9ac97f 100644

Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 923

Quoted 4 lines
Makefile +1 -0
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
  	@echo "before sending patches to the mailing list."
  	@echo "===================================================="
  endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.

Quoted 7 lines
Quoted 3 lines

I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)

Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.

And you're right, I get the same problem for USB, which I have always disabled on our boards. But with CONFIG_USB, it's more clear to be than with CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC?

Simon

author
#13 lore raw

PATCH v2 1/4 dm: MIGRATION: Add migration plan for DM_MMC

Quoted 35 lines · Simon Goldschmidt
Quoted 34 lines · Tom Rini
Quoted 33 lines · Simon Goldschmidt
Quoted 20 lines · Tom Rini

Given that at this point the MMC subsystem itself has been migrated along with a number of subsystem drivers, formalize a deadline for migration.

Cc Simon Glass <[email protected]>
Cc Jaehoon Chung <[email protected]>

---
Changes in v2:
- Note that failure to migration may lead to removal.

---
 Makefile                       | 8 ++++++++
 doc/driver-model/MIGRATION.txt | 9 +++++++++
 2 files changed, 17 insertions(+)
Makefile +0 -0
index a4b1d1db5241..0ab48f9ac97f 100644

Makefile ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y) · line 923

Quoted 4 lines
Makefile +1 -0
@@ -920,6 +920,14 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
 	@echo "before sending patches to the mailing list."
 	@echo "===================================================="
 endif
+ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)

This might not be a too widespread use of U-Boot, but I do have one configuration that boots from FPGA and loads Linux via TFTP. Due to size constraints in FPGA onchip RAM, I have MMC disabled completely. This patch gives me a warning in this case.

I can live with that as I know I have MMC disabled and don't this warning for my other configs though. Just wanted to let you know, as you complained about getting no replies to this thread ;-)

Quoted 8 lines
Quoted 4 lines

Ah, thanks. That means I should have put a test for CONFIG_MMC in there somewhere. I need to re-work the USB one too I think to confirm CONFIG_USB is set. Thanks! I'll post a v3 once I've given folks a chance in general to chime in with this having re-hit their inbox.

And you're right, I get the same problem for USB, which I have always disabled on our boards. But with CONFIG_USB, it's more clear to be than with CONFIG_MMC. Maybe CONFIG_DM_MMC should depend on CONFIG_MMC?

I suspect a small re-work to the Kconfig file to turn MMC into a menuconfig so that everything else is grouped under it would help, yes. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/9a409ce4/attachment.sig>