Skip to contentSkip to conversation

add dwc2 support for px30

PATCH New Heiko Stuebner 1 participant 6 messages Aug 2, 2018 – Sep 24, 2018

Subsystems (3)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

cover add dwc2 support for px30

This is split out from the series adding the px30 support, due to the dwc2 binding change not having landed yet in a maintainer tree.

The Acked binding change should go through some usb tree, while I'll pick up the dts changes once that has happened.

The binding itself is unchanged.

Heiko Stuebner (2):
arm64: dts: rockchip: add dwc2 otg controller on px30
arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb

Liang Chen (1):
dt-bindings: usb: dwc2: add description for px30

 Documentation/devicetree/bindings/usb/dwc2.txt |  1 +
 arch/arm64/boot/dts/rockchip/px30-evb.dts      |  4 ++++
 arch/arm64/boot/dts/rockchip/px30.dtsi         | 16 ++++++++++++++++
 3 files changed, 21 insertions(+)
Signature · 1 line
2.17.0
author maintainer
#1 lore raw

PATCH 1/3 dt-bindings: usb: dwc2: add description for px30

From: Liang Chen <[email protected]>

This patch adds the compatible of dwc2 for PX30 SoCs.

---
unchanged from it being part of the general px30 series

 Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/dwc2.txt +1 -0
index 46da5f184460..6dc3c4a34483 100644
@@ -6,6 +6,7 @@ Required properties:
   - brcm,bcm2835-usb: The DWC2 USB controller instance in the BCM2835 SoC.
   - hisilicon,hi6220-usb: The DWC2 USB controller instance in the hi6220 SoC.
   - rockchip,rk3066-usb: The DWC2 USB controller instance in the rk3066 Soc;
+  - "rockchip,px30-usb", "rockchip,rk3066-usb", "snps,dwc2": for px30 Soc;
   - "rockchip,rk3188-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3188 Soc;
   - "rockchip,rk3288-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3288 Soc;
   - "lantiq,arx100-usb": The DWC2 USB controller instance in Lantiq ARX SoCs;
Signature · 1 line
2.17.0
author maintainer
#2 lore raw

PATCH 1/3 dt-bindings: usb: dwc2: add description for px30

Hi Greg, Felipe,

Am Donnerstag, 2. August 2018, 15:01:31 CEST schrieb Heiko Stuebner:

Quoted 7 lines

From: Liang Chen <[email protected]>

This patch adds the compatible of dwc2 for PX30 SoCs.

Do you want to pick that patch through one of the usb trees, or should I just apply it with the arm64 devicetree-patches?

Thanks
Heiko

Quoted 18 lines

unchanged from it being part of the general px30 series

 Documentation/devicetree/bindings/usb/dwc2.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/dwc2.txt +1 -0
index 46da5f184460..6dc3c4a34483 100644
@@ -6,6 +6,7 @@ Required properties:
   - brcm,bcm2835-usb: The DWC2 USB controller instance in the BCM2835 SoC.
   - hisilicon,hi6220-usb: The DWC2 USB controller instance in the hi6220 SoC.
   - rockchip,rk3066-usb: The DWC2 USB controller instance in the rk3066 Soc;
+  - "rockchip,px30-usb", "rockchip,rk3066-usb", "snps,dwc2": for px30 Soc;
   - "rockchip,rk3188-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3188 Soc;
   - "rockchip,rk3288-usb", "rockchip,rk3066-usb", "snps,dwc2": for rk3288 Soc;
   - "lantiq,arx100-usb": The DWC2 USB controller instance in Lantiq ARX SoCs;
author maintainer
#3 lore raw

PATCH 2/3 arm64: dts: rockchip: add dwc2 otg controller on px30

In reply to Heiko Stuebner

Add the node for the dwc2-based otg controller on the px30 soc.

---
 arch/arm64/boot/dts/rockchip/px30.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm64/boot/dts/rockchip/px30.dtsi +16 -0
index dc3b22ca9a0e..fed782194a94 100644
@@ -702,6 +702,22 @@
 			<100000000>, <200000000>;
 	};
 
+	usb20_otg: usb at ff300000 {
+		compatible = "rockchip,px30-usb", "rockchip,rk3066-usb",
+			     "snps,dwc2";
+		reg = <0x0 0xff300000 0x0 0x40000>;
+		interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&cru HCLK_OTG>;
+		clock-names = "otg";
+		dr_mode = "otg";
+		g-np-tx-fifo-size = <16>;
+		g-rx-fifo-size = <280>;
+		g-tx-fifo-size = <256 128 128 64 32 16>;
+		g-use-dma;
+		power-domains = <&power PX30_PD_USB>;
+		status = "disabled";
+	};
+
 	usb_host0_ehci: usb at ff340000 {
 		compatible = "generic-ehci";
 		reg = <0x0 0xff340000 0x0 0x10000>;
Signature · 1 line
2.17.0
author maintainer
#4 lore raw

PATCH 3/3 arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb

In reply to Heiko Stuebner

Enable the newly added controller on the px30 evaluation board.

---
 arch/arm64/boot/dts/rockchip/px30-evb.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/rockchip/px30-evb.dts +4 -0
index c74aa910a631..263d7f3dbc44 100644
@@ -206,6 +206,10 @@
 	status = "okay";
 };
 
+&usb20_otg {
+	status = "okay";
+};
+
 &usb_host0_ehci {
 	status = "okay";
 };
Signature · 1 line
2.17.0
author maintainer
#5 lore raw

cover add dwc2 support for px30

In reply to Heiko Stuebner

Am Donnerstag, 2. August 2018, 15:01:30 CEST schrieb Heiko Stuebner:

Quoted 9 lines

This is split out from the series adding the px30 support, due to the dwc2 binding change not having landed yet in a maintainer tree.

The Acked binding change should go through some usb tree, while I'll pick up the dts changes once that has happened.

The binding itself is unchanged.

Quoted 6 lines

Heiko Stuebner (2):
arm64: dts: rockchip: add dwc2 otg controller on px30
arm64: dts: rockchip: enable dwc2-based otg controller on px30-evb

Liang Chen (1):
dt-bindings: usb: dwc2: add description for px30

applied all 3 patches for 4.20 now.