Skip to contentSkip to conversation

mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

PATCH In review Aswath Govindraju 4 participants 16 messages Apr 5, 2021 – Jul 29, 2021 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

Hi,

Quoted 3 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) If I missed something, let me know, plz.

In include/sdhci.h, it mentioned to "Non-standard".

Best Regards,
Jaehoon Chung

Quoted 22 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#2 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

Hi Jaehoon,

Quoted 12 lines · Jaehoon Chung

Hi,

Quoted 3 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) If I missed something, let me know, plz.

In include/sdhci.h, it mentioned to "Non-standard".

Thank you for pointing this out.

Yes, this is not a part of SD specification and in the specification this field is marked as reserved. I have added this, as this bit mask has been defined in include/sdhci.h. Sorry about this. I'll post a respin taking this into a consideration.

Thanks,
Aswath

Quoted 26 lines

Best Regards,
Jaehoon Chung

Quoted 22 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#3 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

Hi Jaehoon,

Quoted 16 lines · Aswath Govindraju

Hi Jaehoon,

Quoted 12 lines · Jaehoon Chung

Hi,

Quoted 3 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) If I missed something, let me know, plz.

In include/sdhci.h, it mentioned to "Non-standard".

Quoted 7 lines

Thank you for pointing this out.

Yes, this is not a part of SD specification and in the specification this field is marked as reserved. I have added this, as this bit mask has been defined in include/sdhci.h. Sorry about this. I'll post a respin taking this into a consideration.

On the other hand, the same has been accepted in kernel i.e. setting SDHCI_CTRL_HS400 bit in HOST_CONTROL2 register, drivers/mmc/host/sdhci.c in sdhci_set_uhs_signaling(). I think although this bit has not been mentioned in the specification, it seems it is used by many controllers for HS400 mode. So, as this is not specific to a controller can setting this, be allowed in the common sdhci_set_uhs_timing() function ?

Thanks,
Aswath

Quoted 30 lines

Thanks,
Aswath

Quoted 26 lines

Best Regards,
Jaehoon Chung

Quoted 22 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#4 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

Hi Aswath,

Quoted 27 lines · Aswath Govindraju

Hi Jaehoon,

Quoted 16 lines · Aswath Govindraju

Hi Jaehoon,

Quoted 12 lines · Jaehoon Chung

Hi,

Quoted 3 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) If I missed something, let me know, plz.

In include/sdhci.h, it mentioned to "Non-standard".

Quoted 7 lines

Thank you for pointing this out.

Yes, this is not a part of SD specification and in the specification this field is marked as reserved. I have added this, as this bit mask has been defined in include/sdhci.h. Sorry about this. I'll post a respin taking this into a consideration.

Quoted 6 lines

On the other hand, the same has been accepted in kernel i.e. setting SDHCI_CTRL_HS400 bit in HOST_CONTROL2 register, drivers/mmc/host/sdhci.c in sdhci_set_uhs_signaling(). I think although this bit has not been mentioned in the specification, it seems it is used by many controllers for HS400 mode. So, as this is not specific to a controller can setting this, be allowed in the common sdhci_set_uhs_timing() function ?

Frankly, i think that it can be used. Just I wondered that i missed something from Specification. :) Thanks for sharing information. I didn't check on kernel side.

Best Regards,
Jaehoon Chung

Quoted 36 lines

Thanks,
Aswath

Quoted 30 lines

Thanks,
Aswath

Quoted 26 lines

Best Regards,
Jaehoon Chung

Quoted 22 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#5 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

In reply to Aswath Govindraju
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#6 lore raw

PATCH 1/1 mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Can you please pick this patch if there are no comments.

Thanks,
Aswath

Quoted 23 lines

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#7 lore raw

Hi Peng,

Quoted 8 lines · Aswath Govindraju

Hi Peng,

Quoted 5 lines · Jaehoon Chung
Quoted 4 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

Thanks,
Aswath

Quoted 27 lines

Thanks,
Aswath

Quoted 23 lines

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#8 lore raw

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 11 lines · Aswath Govindraju

Hi Peng,

Quoted 8 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

[1] - https://patchwork.ozlabs.org/project/uboot/list/?series=247000
[2] - https://patchwork.ozlabs.org/project/uboot/list/?series=245579

Thanks,
Aswath

Quoted 31 lines

Thanks,
Aswath

Quoted 27 lines

Thanks,
Aswath

Quoted 23 lines

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
Acked-by
#9 lore raw

Hi Aswath,

Quoted 20 lines · Aswath Govindraju

Hi Peng,

Quoted 17 lines · Aswath Govindraju

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

I don't have the permission to merge on u-boot-mmc git.
I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :)

I had been already reviewed about this patch..
So if want to pick this, I think there is no problem about applied together with below patches.

Best Regards,
Jaehoon Chung

Quoted 40 lines

[1] - https://protect2.fireeye.com/v1/url?k=bf905767-e00b6fae-bf91dc28-0cc47a336fae-6a3fa5da3333a309&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D247000
[2] - https://protect2.fireeye.com/v1/url?k=c93699cd-96ada104-c9371282-0cc47a336fae-de6d85845da27eb0&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D245579

Thanks,
Aswath

Quoted 31 lines

Thanks,
Aswath

Quoted 27 lines

Thanks,
Aswath

Quoted 23 lines

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#10 lore raw

+Tom

Quoted 32 lines · Jaehoon Chung

Hi Aswath,

Quoted 20 lines · Aswath Govindraju

Hi Peng,

Quoted 17 lines · Aswath Govindraju

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

Quoted 7 lines

I don't have the permission to merge on u-boot-mmc git.
I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :)

I had been already reviewed about this patch..
So if want to pick this, I think there is no problem about applied together with below patches.

Tom,
Is it okay if I pick this patch as per above suggestion?

Thanks and regards,
Lokesh

Quoted 45 lines

Best Regards,
Jaehoon Chung

Quoted 40 lines

[1] - https://protect2.fireeye.com/v1/url?k=bf905767-e00b6fae-bf91dc28-0cc47a336fae-6a3fa5da3333a309&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D247000
[2] - https://protect2.fireeye.com/v1/url?k=c93699cd-96ada104-c9371282-0cc47a336fae-de6d85845da27eb0&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D245579

Thanks,
Aswath

Quoted 31 lines

Thanks,
Aswath

Quoted 27 lines

Thanks,
Aswath

Quoted 23 lines

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#11 lore raw

Hi Lokesh,

Quoted 38 lines · Lokesh Vutla

+Tom

Quoted 35 lines · Jaehoon Chung

Hi Aswath,

Quoted 20 lines · Aswath Govindraju

Hi Peng,

Quoted 17 lines · Aswath Govindraju

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

I don't have the permission to merge on u-boot-mmc git.
I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :)

Quoted 7 lines
Quoted 4 lines

I had been already reviewed about this patch..
So if want to pick this, I think there is no problem about applied together with below patches.

Tom,
Is it okay if I pick this patch as per above suggestion?

Isn't it enough my Acked-by tag?

Best Regards,
Jaehoon Chung

Quoted 50 lines

Thanks and regards,
Lokesh

Quoted 45 lines

Best Regards,
Jaehoon Chung

Quoted 40 lines

[1] - https://protect2.fireeye.com/v1/url?k=bf905767-e00b6fae-bf91dc28-0cc47a336fae-6a3fa5da3333a309&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D247000
[2] - https://protect2.fireeye.com/v1/url?k=c93699cd-96ada104-c9371282-0cc47a336fae-de6d85845da27eb0&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D245579

Thanks,
Aswath

Quoted 31 lines

Thanks,
Aswath

Quoted 27 lines

Thanks,
Aswath

Quoted 23 lines

Best Regards,
Jaehoon Chung

Quoted 19 lines
---
 drivers/mmc/sdhci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mmc/sdhci.c +3 -0
index d9ab6a0a839e..eea4701d8af5 100644
@@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host)
 	case MMC_HS_200:
 		reg |= SDHCI_CTRL_UHS_SDR104;
 		break;
+	case MMC_HS_400:
+		reg |= SDHCI_CTRL_HS400;
+		break;
 	default:
 		reg |= SDHCI_CTRL_UHS_SDR12;
 	}
#12 lore raw
Quoted 44 lines · Jaehoon Chung

Hi Lokesh,

Quoted 41 lines · Lokesh Vutla

+Tom

Quoted 38 lines · Jaehoon Chung

Hi Aswath,

Quoted 20 lines · Aswath Govindraju

Hi Peng,

Quoted 17 lines · Aswath Govindraju

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

I don't have the permission to merge on u-boot-mmc git.
I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :)

I had been already reviewed about this patch..
So if want to pick this, I think there is no problem about applied together with below patches.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Tom,
Is it okay if I pick this patch as per above suggestion?

Isn't it enough my Acked-by tag?

Sure it is :). I just want to make sure Tom doesn't flag it in the PR.

Thanks and regards,
Lokesh

#13 lore raw
Quoted 47 lines · Lokesh Vutla
Quoted 44 lines · Jaehoon Chung

Hi Lokesh,

Quoted 41 lines · Lokesh Vutla

+Tom

Quoted 38 lines · Jaehoon Chung

Hi Aswath,

Quoted 20 lines · Aswath Govindraju

Hi Peng,

Quoted 17 lines · Aswath Govindraju

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

I don't have the permission to merge on u-boot-mmc git.
I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :)

I had been already reviewed about this patch..
So if want to pick this, I think there is no problem about applied together with below patches.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Tom,
Is it okay if I pick this patch as per above suggestion?

Isn't it enough my Acked-by tag?

Sure it is :). I just want to make sure Tom doesn't flag it in the PR.

Thanks for explanation. :)

Best Regards,
Jaehoon Chung

Quoted 5 lines

Thanks and regards,
Lokesh

#14 lore raw
In reply to Lokesh Vutla
Quoted 38 lines · Lokesh Vutla

+Tom

Quoted 35 lines · Jaehoon Chung

Hi Aswath,

Quoted 20 lines · Aswath Govindraju

Hi Peng,

Quoted 17 lines · Aswath Govindraju

Hi Peng,

Quoted 14 lines · Aswath Govindraju

Hi Peng,

Quoted 10 lines · Jaehoon Chung
Quoted 6 lines · Aswath Govindraju

From: Faiz Abbas <[email protected]>

Enable HS400 speed mode by writing to HOST_CONTROL2 register.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Can you please pick this patch if there are no comments.

May I know if this okay to be merged ?

A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2].

I don't have the permission to merge on u-boot-mmc git.
I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :)

Quoted 7 lines
Quoted 4 lines

I had been already reviewed about this patch..
So if want to pick this, I think there is no problem about applied together with below patches.

Tom,
Is it okay if I pick this patch as per above suggestion?

Yes that's fine, thanks.

Signature · 1 line
Tom