MAINTAINERS: add entry for Rockchip drm drivers
Subsystems (4)
Heiko Stübner
maintainerPATCH 1/2 MAINTAINERS: add entry for Rockchip drm drivers
Mark Yao looks after the Rockchip drm drivers and should thus also get patches touching these.
--- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)
MAINTAINERS +7 -0
@@ -3410,6 +3410,13 @@ F: drivers/gpu/drm/rcar-du/ F: drivers/gpu/drm/shmobile/ F: include/linux/platform_data/shmob_drm.h +DRM DRIVERS FOR ROCKCHIP +M: Mark Yao <[email protected]> +L: [email protected] +S: Maintained +F: drivers/gpu/drm/rockchip/ +F: Documentation/devicetree/bindings/video/rockchip* + DSBR100 USB FM RADIO DRIVER M: Alexey Klimov <[email protected]> L: [email protected]
Signature · 7 lines
2.1.4 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Heiko Stübner
maintainerPATCH 2/2 drm/rockchip: make irq variable signed
platform_get_irq() can return negative error values and we already test for these. Therefore the variable holding this value should be signed to not loose error values.
--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1 -1
@@ -104,7 +104,7 @@ struct vop {/* lock vop irq reg */ spinlock_t irq_lock; -unsigned int irq; +int irq;/* vop AHP clk */ struct clk *hclk;
Signature · 7 lines
2.1.4 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm/rockchip: make irq variable signed
Hi Heiko,
Quoted 16 lines · Heiko Stübner
platform_get_irq()can return negative error values and we already test for these. Therefore the variable holding this value should be signed to not loose error values.Reported-by David Binderman <[email protected]>Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/rockchip/rockchip_drm_vop.c +0
-0
drivers/gpu/drm/rockchip/rockchip_drm_vop.c struct vop { · line 108
Quoted 6 lines
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1
-1@@ -104,7 +104,7 @@ struct vop {/* lock vop irq reg */ spinlock_t irq_lock; -unsigned int irq; +int irq;
Hmm. Both enable_irq() and disable_irq(), etc) want irq as an unsigned int. The thing we want here is to detect a negative return value from platform_get_irq().
So, I'd slightly prefer changing to vop_bind() to something like this:
int irq;
...
irq = platform_get_irq()
If (irq < 0)
return irq;
vop->irq = (unsigned int)irq;
-Dan
Quoted 8 lines
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +0
-1/* vop AHP clk */ struct clk *hclk; --2.1.4
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm/rockchip: make irq variable signed
In reply to Heiko StübnerHi Heiko,
Quoted 15 lines · Heiko Stübner
platform_get_irq()can return negative error values and we already test for these. Therefore the variable holding this value should be signed to not loose error values.Reported-by David Binderman <[email protected]>Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/rockchip/rockchip_drm_vop.c +0
-0
drivers/gpu/drm/rockchip/rockchip_drm_vop.c struct vop { · line 107
Quoted 5 lines
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +1
-1@@ -104,7 +104,7 @@ struct vop {/* lock vop irq reg */ spinlock_t irq_lock; -unsigned int irq; +int irq;
Hmm. Both enable_irq() and disable_irq(), etc) want irq as an unsigned int. The thing we want here is to detect a negative return value from platform_get_irq().
So, I'd slightly prefer changing to vop_bind() to something like this:
int irq;
...
irq = platform_get_irq()
If (irq < 0)
return irq;
vop->irq = (unsigned int)irq;
But, either way, this patch is:
Thanks for the fix.
Quoted 7 lines
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +0
-1/* vop AHP clk */ struct clk *hclk; --2.1.4
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel