drivers: remove meson 0.46.0 warning
Subsystems (2)
PATCH 1/1 drivers: remove meson 0.46.0 warning
From: Jerin Jacob <[email protected]>
Since meson 0.46.0 version, the extract_all_objects() API need to pass explicit boolean value.
To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.
[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.
--- drivers/common/sfc_efx/base/meson.build | 2 +- drivers/meson.build | 2 +- drivers/net/e1000/base/meson.build | 2 +- drivers/net/fm10k/base/meson.build | 2 +- drivers/net/hinic/base/meson.build | 2 +- drivers/net/i40e/base/meson.build | 2 +- drivers/net/ice/base/meson.build | 2 +- drivers/net/igc/base/meson.build | 2 +- drivers/net/ixgbe/base/meson.build | 2 +- drivers/net/ngbe/base/meson.build | 2 +- drivers/net/octeontx/base/meson.build | 2 +- drivers/net/qede/base/meson.build | 2 +- drivers/net/thunderx/base/meson.build | 2 +- drivers/net/txgbe/base/meson.build | 2 +- drivers/raw/ifpga/base/meson.build | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-)
drivers/common/sfc_efx/base/meson.build +1 -1
@@ -86,7 +86,7 @@ if build dependencies: static_rte_eal, c_args: c_args) - base_objs = base_lib.extract_all_objects() + base_objs = base_lib.extract_all_objects(recursive: true) else base_objs = [] endif
drivers/meson.build +1 -1
@@ -160,7 +160,7 @@ foreach subpath:subdirs include_directories: includes, dependencies: static_deps, c_args: cflags) - objs += tmp_lib.extract_all_objects() + objs += tmp_lib.extract_all_objects(recursive: true) sources = custom_target(out_filename, command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen], output: out_filename,
drivers/net/e1000/base/meson.build +1 -1
@@ -35,4 +35,4 @@ endforeach base_lib = static_library('e1000_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/fm10k/base/meson.build +1 -1
@@ -25,4 +25,4 @@ endforeach base_lib = static_library('fm10k_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/hinic/base/meson.build +1 -1
@@ -34,4 +34,4 @@ c_args = cflags base_lib = static_library('hinic_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/i40e/base/meson.build +1 -1
@@ -27,4 +27,4 @@ endforeach base_lib = static_library('i40e_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ice/base/meson.build +1 -1
@@ -43,4 +43,4 @@ endforeach base_lib = static_library('ice_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/igc/base/meson.build +1 -1
@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ixgbe/base/meson.build +1 -1
@@ -31,4 +31,4 @@ endforeach base_lib = static_library('ixgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ngbe/base/meson.build +1 -1
@@ -18,4 +18,4 @@ c_args = cflags base_lib = static_library('ngbe_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/octeontx/base/meson.build +1 -1
@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources, dependencies: static_objs, ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/qede/base/meson.build +1 -1
@@ -54,4 +54,4 @@ endforeach base_lib = static_library('qede_base', sources, dependencies: [static_rte_net, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/thunderx/base/meson.build +1 -1
@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources, dependencies: static_rte_ethdev ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/txgbe/base/meson.build +1 -1
@@ -24,4 +24,4 @@ endforeach base_lib = static_library('txgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/raw/ifpga/base/meson.build +1 -1
@@ -40,4 +40,4 @@ ext_deps += rtdep base_lib = static_library('ifpga_rawdev_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
Signature · 1 line
2.32.0
PATCH v2 1/1 drivers: remove warning with meson 0.59.0
From: Jerin Jacob <[email protected]>
Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.
To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.
[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.
---
v2..v1
- Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)
drivers/common/sfc_efx/base/meson.build | 2 +- drivers/meson.build | 2 +- drivers/net/e1000/base/meson.build | 2 +- drivers/net/fm10k/base/meson.build | 2 +- drivers/net/hinic/base/meson.build | 2 +- drivers/net/i40e/base/meson.build | 2 +- drivers/net/ice/base/meson.build | 2 +- drivers/net/igc/base/meson.build | 2 +- drivers/net/ixgbe/base/meson.build | 2 +- drivers/net/ngbe/base/meson.build | 2 +- drivers/net/octeontx/base/meson.build | 2 +- drivers/net/qede/base/meson.build | 2 +- drivers/net/thunderx/base/meson.build | 2 +- drivers/net/txgbe/base/meson.build | 2 +- drivers/raw/ifpga/base/meson.build | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-)
drivers/common/sfc_efx/base/meson.build +1 -1
@@ -86,7 +86,7 @@ if build dependencies: static_rte_eal, c_args: c_args) - base_objs = base_lib.extract_all_objects() + base_objs = base_lib.extract_all_objects(recursive: true) else base_objs = [] endif
drivers/meson.build +1 -1
@@ -160,7 +160,7 @@ foreach subpath:subdirs include_directories: includes, dependencies: static_deps, c_args: cflags) - objs += tmp_lib.extract_all_objects() + objs += tmp_lib.extract_all_objects(recursive: true) sources = custom_target(out_filename, command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen], output: out_filename,
drivers/net/e1000/base/meson.build +1 -1
@@ -35,4 +35,4 @@ endforeach base_lib = static_library('e1000_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/fm10k/base/meson.build +1 -1
@@ -25,4 +25,4 @@ endforeach base_lib = static_library('fm10k_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/hinic/base/meson.build +1 -1
@@ -34,4 +34,4 @@ c_args = cflags base_lib = static_library('hinic_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/i40e/base/meson.build +1 -1
@@ -27,4 +27,4 @@ endforeach base_lib = static_library('i40e_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ice/base/meson.build +1 -1
@@ -43,4 +43,4 @@ endforeach base_lib = static_library('ice_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/igc/base/meson.build +1 -1
@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ixgbe/base/meson.build +1 -1
@@ -31,4 +31,4 @@ endforeach base_lib = static_library('ixgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ngbe/base/meson.build +1 -1
@@ -18,4 +18,4 @@ c_args = cflags base_lib = static_library('ngbe_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/octeontx/base/meson.build +1 -1
@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources, dependencies: static_objs, ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/qede/base/meson.build +1 -1
@@ -54,4 +54,4 @@ endforeach base_lib = static_library('qede_base', sources, dependencies: [static_rte_net, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/thunderx/base/meson.build +1 -1
@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources, dependencies: static_rte_ethdev ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/txgbe/base/meson.build +1 -1
@@ -24,4 +24,4 @@ endforeach base_lib = static_library('txgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
drivers/raw/ifpga/base/meson.build +1 -1
@@ -40,4 +40,4 @@ ext_deps += rtdep base_lib = static_library('ifpga_rawdev_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)
--
2.32.0
Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
Quoted 9 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:
From: Jerin Jacob <[email protected]>
Since meson 0.59.0 version, the
extract_all_objects()API need to pass explicit boolean value.To remove the following warning[1], added explicit
trueforextract_all_objects()use in codebase whever there is no argument.
Quoted 6 lines
[1]
WARNING:extract_all_objectscalled without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.
Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?
Quoted 181 lines
Signed-off-by Jerin Jacob <[email protected]>---
v2..v1
- Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)drivers/common/sfc_efx/base/meson.build | 2 +- drivers/meson.build | 2 +- drivers/net/e1000/base/meson.build | 2 +- drivers/net/fm10k/base/meson.build | 2 +- drivers/net/hinic/base/meson.build | 2 +- drivers/net/i40e/base/meson.build | 2 +- drivers/net/ice/base/meson.build | 2 +- drivers/net/igc/base/meson.build | 2 +- drivers/net/ixgbe/base/meson.build | 2 +- drivers/net/ngbe/base/meson.build | 2 +- drivers/net/octeontx/base/meson.build | 2 +- drivers/net/qede/base/meson.build | 2 +- drivers/net/thunderx/base/meson.build | 2 +- drivers/net/txgbe/base/meson.build | 2 +- drivers/raw/ifpga/base/meson.build | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-)drivers/common/sfc_efx/base/meson.build +1
-1@@ -86,7 +86,7 @@ if build dependencies: static_rte_eal, c_args: c_args) - base_objs = base_lib.extract_all_objects() + base_objs = base_lib.extract_all_objects(recursive: true) else base_objs = [] endifdrivers/meson.build +1
-1@@ -160,7 +160,7 @@ foreach subpath:subdirs include_directories: includes, dependencies: static_deps, c_args: cflags) - objs += tmp_lib.extract_all_objects() + objs += tmp_lib.extract_all_objects(recursive: true) sources = custom_target(out_filename, command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen], output: out_filename,drivers/net/e1000/base/meson.build +1
-1@@ -35,4 +35,4 @@ endforeach base_lib = static_library('e1000_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/fm10k/base/meson.build +1
-1@@ -25,4 +25,4 @@ endforeach base_lib = static_library('fm10k_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/hinic/base/meson.build +1
-1@@ -34,4 +34,4 @@ c_args = cflags base_lib = static_library('hinic_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/i40e/base/meson.build +1
-1@@ -27,4 +27,4 @@ endforeach base_lib = static_library('i40e_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/ice/base/meson.build +1
-1@@ -43,4 +43,4 @@ endforeach base_lib = static_library('ice_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/igc/base/meson.build +1
-1@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/ixgbe/base/meson.build +1
-1@@ -31,4 +31,4 @@ endforeach base_lib = static_library('ixgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/ngbe/base/meson.build +1
-1@@ -18,4 +18,4 @@ c_args = cflags base_lib = static_library('ngbe_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/octeontx/base/meson.build +1
-1@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources, dependencies: static_objs, ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/qede/base/meson.build +1
-1@@ -54,4 +54,4 @@ endforeach base_lib = static_library('qede_base', sources, dependencies: [static_rte_net, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/thunderx/base/meson.build +1
-1@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources, dependencies: static_rte_ethdev ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/txgbe/base/meson.build +1
-1@@ -24,4 +24,4 @@ endforeach base_lib = static_library('txgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/raw/ifpga/base/meson.build +1
-2@@ -40,4 +40,4 @@ ext_deps += rtdep base_lib = static_library('ifpga_rawdev_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true) --2.32.0
Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
Quoted 18 lines · Bruce Richardson
Quoted 9 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:
From: Jerin Jacob <[email protected]>
Since meson 0.59.0 version, the
extract_all_objects()API need to pass explicit boolean value.To remove the following warning[1], added explicit
trueforextract_all_objects()use in codebase whever there is no argument.Quoted 6 lines
[1]
WARNING:extract_all_objectscalled without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.
Quoted 3 lines
Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?
Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.
Quoted 182 lines
Quoted 182 lines
Signed-off-by Jerin Jacob <[email protected]>---
v2..v1
- Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)drivers/common/sfc_efx/base/meson.build | 2 +- drivers/meson.build | 2 +- drivers/net/e1000/base/meson.build | 2 +- drivers/net/fm10k/base/meson.build | 2 +- drivers/net/hinic/base/meson.build | 2 +- drivers/net/i40e/base/meson.build | 2 +- drivers/net/ice/base/meson.build | 2 +- drivers/net/igc/base/meson.build | 2 +- drivers/net/ixgbe/base/meson.build | 2 +- drivers/net/ngbe/base/meson.build | 2 +- drivers/net/octeontx/base/meson.build | 2 +- drivers/net/qede/base/meson.build | 2 +- drivers/net/thunderx/base/meson.build | 2 +- drivers/net/txgbe/base/meson.build | 2 +- drivers/raw/ifpga/base/meson.build | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-)drivers/common/sfc_efx/base/meson.build +1
-1@@ -86,7 +86,7 @@ if build dependencies: static_rte_eal, c_args: c_args) - base_objs = base_lib.extract_all_objects() + base_objs = base_lib.extract_all_objects(recursive: true) else base_objs = [] endifdrivers/meson.build +1
-1@@ -160,7 +160,7 @@ foreach subpath:subdirs include_directories: includes, dependencies: static_deps, c_args: cflags) - objs += tmp_lib.extract_all_objects() + objs += tmp_lib.extract_all_objects(recursive: true) sources = custom_target(out_filename, command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen], output: out_filename,drivers/net/e1000/base/meson.build +1
-1@@ -35,4 +35,4 @@ endforeach base_lib = static_library('e1000_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/fm10k/base/meson.build +1
-1@@ -25,4 +25,4 @@ endforeach base_lib = static_library('fm10k_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/hinic/base/meson.build +1
-1@@ -34,4 +34,4 @@ c_args = cflags base_lib = static_library('hinic_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/i40e/base/meson.build +1
-1@@ -27,4 +27,4 @@ endforeach base_lib = static_library('i40e_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/ice/base/meson.build +1
-1@@ -43,4 +43,4 @@ endforeach base_lib = static_library('ice_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/igc/base/meson.build +1
-1@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/ixgbe/base/meson.build +1
-1@@ -31,4 +31,4 @@ endforeach base_lib = static_library('ixgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/ngbe/base/meson.build +1
-1@@ -18,4 +18,4 @@ c_args = cflags base_lib = static_library('ngbe_base', sources, dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/octeontx/base/meson.build +1
-1@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources, dependencies: static_objs, ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/qede/base/meson.build +1
-1@@ -54,4 +54,4 @@ endforeach base_lib = static_library('qede_base', sources, dependencies: [static_rte_net, static_rte_bus_pci], c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/thunderx/base/meson.build +1
-1@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources, dependencies: static_rte_ethdev ) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/net/txgbe/base/meson.build +1
-1@@ -24,4 +24,4 @@ endforeach base_lib = static_library('txgbe_base', sources, dependencies: static_rte_eal, c_args: c_args) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true)drivers/raw/ifpga/base/meson.build +1
-2@@ -40,4 +40,4 @@ ext_deps += rtdep base_lib = static_library('ifpga_rawdev_base', sources, dependencies: static_rte_eal, c_args: cflags) -base_objs = base_lib.extract_all_objects() +base_objs = base_lib.extract_all_objects(recursive: true) --2.32.0
Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
17/08/2021 14:54, Jerin Jacob:
Quoted 20 lines
Quoted 18 lines · Bruce Richardson
Quoted 15 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:
From: Jerin Jacob <[email protected]>
Since meson 0.59.0 version, the
extract_all_objects()API need to pass explicit boolean value.To remove the following warning[1], added explicit
trueforextract_all_objects()use in codebase whever there is no argument.[1]
WARNING:extract_all_objectscalled without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.
Quoted 6 lines
Quoted 3 lines
Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?
Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.
Bruce, are you OK with the change?
Bruce Richardson
Acked-byRe: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
Quoted 21 lines · Thomas Monjalon
17/08/2021 14:54, Jerin Jacob:
Quoted 20 lines
Quoted 18 lines · Bruce Richardson
Quoted 15 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:
From: Jerin Jacob <[email protected]>
Since meson 0.59.0 version, the
extract_all_objects()API need to pass explicit boolean value.To remove the following warning[1], added explicit
trueforextract_all_objects()use in codebase whever there is no argument.[1]
WARNING:extract_all_objectscalled without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines
Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?
Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.
Bruce, are you OK with the change?
Yes.
Thomas Monjalon
AppliedRe: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0
27/08/2021 14:55, Bruce Richardson:
Quoted 26 lines · Thomas Monjalon
Quoted 25 lines
17/08/2021 14:54, Jerin Jacob:
Quoted 24 lines
Quoted 21 lines · Bruce Richardson
Quoted 9 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:
From: Jerin Jacob <[email protected]>
Since meson 0.59.0 version, the
extract_all_objects()API need to pass explicit boolean value.To remove the following warning[1], added explicit
trueforextract_all_objects()use in codebase whever there is no argument.Quoted 6 lines
[1]
WARNING:extract_all_objectscalled without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.
Bruce, are you OK with the change?
Yes.
Acked-by Bruce Richardson <[email protected]>
Applied, thanks.