Skip to contentSkip to conversation

drivers: remove meson 0.46.0 warning

PATCH Superseded [email protected] 4 participants 7 messages Jul 30, 2021 – Aug 27, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: remove meson 0.46.0 warning

From: Jerin Jacob <[email protected]>

Since meson 0.46.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

---
 drivers/common/sfc_efx/base/meson.build | 2 +-
 drivers/meson.build                     | 2 +-
 drivers/net/e1000/base/meson.build      | 2 +-
 drivers/net/fm10k/base/meson.build      | 2 +-
 drivers/net/hinic/base/meson.build      | 2 +-
 drivers/net/i40e/base/meson.build       | 2 +-
 drivers/net/ice/base/meson.build        | 2 +-
 drivers/net/igc/base/meson.build        | 2 +-
 drivers/net/ixgbe/base/meson.build      | 2 +-
 drivers/net/ngbe/base/meson.build       | 2 +-
 drivers/net/octeontx/base/meson.build   | 2 +-
 drivers/net/qede/base/meson.build       | 2 +-
 drivers/net/thunderx/base/meson.build   | 2 +-
 drivers/net/txgbe/base/meson.build      | 2 +-
 drivers/raw/ifpga/base/meson.build      | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)
drivers/common/sfc_efx/base/meson.build +1 -1
index 9fba47b1cc..ff7f33fb44 100644
@@ -86,7 +86,7 @@ if build
         dependencies: static_rte_eal,
         c_args: c_args)
 
-    base_objs = base_lib.extract_all_objects()
+    base_objs = base_lib.extract_all_objects(recursive: true)
 else
     base_objs = []
 endif
drivers/meson.build +1 -1
index bc6f4f567f..d9e331ec85 100644
@@ -160,7 +160,7 @@ foreach subpath:subdirs
                 include_directories: includes,
                 dependencies: static_deps,
                 c_args: cflags)
-        objs += tmp_lib.extract_all_objects()
+        objs += tmp_lib.extract_all_objects(recursive: true)
         sources = custom_target(out_filename,
                 command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen],
                 output: out_filename,
drivers/net/e1000/base/meson.build +1 -1
index 317692dfab..528a33f958 100644
@@ -35,4 +35,4 @@ endforeach
 base_lib = static_library('e1000_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/fm10k/base/meson.build +1 -1
index ca98d34d4e..bd19df27f7 100644
@@ -25,4 +25,4 @@ endforeach
 base_lib = static_library('fm10k_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/hinic/base/meson.build +1 -1
index a00c90c14e..3aa53df881 100644
@@ -34,4 +34,4 @@ c_args = cflags
 base_lib = static_library('hinic_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/i40e/base/meson.build +1 -1
index 79a887a297..d94108629b 100644
@@ -27,4 +27,4 @@ endforeach
 base_lib = static_library('i40e_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ice/base/meson.build +1 -1
index 3305e5dd18..30e251876d 100644
@@ -43,4 +43,4 @@ endforeach
 base_lib = static_library('ice_base', sources,
         dependencies: static_rte_eal,
         c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/igc/base/meson.build +1 -1
index 8affc72e65..f52421f7a9 100644
@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ixgbe/base/meson.build +1 -1
index 7d3cec002d..22972c6b56 100644
@@ -31,4 +31,4 @@ endforeach
 base_lib = static_library('ixgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ngbe/base/meson.build +1 -1
index a1a9c2ff65..6081281135 100644
@@ -18,4 +18,4 @@ c_args = cflags
 base_lib = static_library('ngbe_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/octeontx/base/meson.build +1 -1
index c86a726704..8e5e8c1b55 100644
@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources,
     dependencies: static_objs,
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/qede/base/meson.build +1 -1
index 614a0c3808..4ad177b478 100644
@@ -54,4 +54,4 @@ endforeach
 base_lib = static_library('qede_base', sources,
     dependencies: [static_rte_net, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/thunderx/base/meson.build +1 -1
index 704ee65771..cec45d0ae1 100644
@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources,
     dependencies: static_rte_ethdev
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/txgbe/base/meson.build +1 -1
index c6816b4279..7a30191472 100644
@@ -24,4 +24,4 @@ endforeach
 base_lib = static_library('txgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/raw/ifpga/base/meson.build +1 -1
index 8d27c60213..db602cee69 100644
@@ -40,4 +40,4 @@ ext_deps += rtdep
 base_lib = static_library('ifpga_rawdev_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
Signature · 1 line
2.32.0
#1 lore raw

PATCH v2 1/1 drivers: remove warning with meson 0.59.0

From: Jerin Jacob <[email protected]>

Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

---
v2..v1
- Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)

 drivers/common/sfc_efx/base/meson.build | 2 +-
 drivers/meson.build                     | 2 +-
 drivers/net/e1000/base/meson.build      | 2 +-
 drivers/net/fm10k/base/meson.build      | 2 +-
 drivers/net/hinic/base/meson.build      | 2 +-
 drivers/net/i40e/base/meson.build       | 2 +-
 drivers/net/ice/base/meson.build        | 2 +-
 drivers/net/igc/base/meson.build        | 2 +-
 drivers/net/ixgbe/base/meson.build      | 2 +-
 drivers/net/ngbe/base/meson.build       | 2 +-
 drivers/net/octeontx/base/meson.build   | 2 +-
 drivers/net/qede/base/meson.build       | 2 +-
 drivers/net/thunderx/base/meson.build   | 2 +-
 drivers/net/txgbe/base/meson.build      | 2 +-
 drivers/raw/ifpga/base/meson.build      | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)
drivers/common/sfc_efx/base/meson.build +1 -1
index 9fba47b1cc..ff7f33fb44 100644
@@ -86,7 +86,7 @@ if build
         dependencies: static_rte_eal,
         c_args: c_args)
 
-    base_objs = base_lib.extract_all_objects()
+    base_objs = base_lib.extract_all_objects(recursive: true)
 else
     base_objs = []
 endif
drivers/meson.build +1 -1
index bc6f4f567f..d9e331ec85 100644
@@ -160,7 +160,7 @@ foreach subpath:subdirs
                 include_directories: includes,
                 dependencies: static_deps,
                 c_args: cflags)
-        objs += tmp_lib.extract_all_objects()
+        objs += tmp_lib.extract_all_objects(recursive: true)
         sources = custom_target(out_filename,
                 command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen],
                 output: out_filename,
drivers/net/e1000/base/meson.build +1 -1
index 317692dfab..528a33f958 100644
@@ -35,4 +35,4 @@ endforeach
 base_lib = static_library('e1000_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/fm10k/base/meson.build +1 -1
index ca98d34d4e..bd19df27f7 100644
@@ -25,4 +25,4 @@ endforeach
 base_lib = static_library('fm10k_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/hinic/base/meson.build +1 -1
index a00c90c14e..3aa53df881 100644
@@ -34,4 +34,4 @@ c_args = cflags
 base_lib = static_library('hinic_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/i40e/base/meson.build +1 -1
index 79a887a297..d94108629b 100644
@@ -27,4 +27,4 @@ endforeach
 base_lib = static_library('i40e_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ice/base/meson.build +1 -1
index 3305e5dd18..30e251876d 100644
@@ -43,4 +43,4 @@ endforeach
 base_lib = static_library('ice_base', sources,
         dependencies: static_rte_eal,
         c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/igc/base/meson.build +1 -1
index 8affc72e65..f52421f7a9 100644
@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ixgbe/base/meson.build +1 -1
index 7d3cec002d..22972c6b56 100644
@@ -31,4 +31,4 @@ endforeach
 base_lib = static_library('ixgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ngbe/base/meson.build +1 -1
index a1a9c2ff65..6081281135 100644
@@ -18,4 +18,4 @@ c_args = cflags
 base_lib = static_library('ngbe_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/octeontx/base/meson.build +1 -1
index c86a726704..8e5e8c1b55 100644
@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources,
     dependencies: static_objs,
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/qede/base/meson.build +1 -1
index 614a0c3808..4ad177b478 100644
@@ -54,4 +54,4 @@ endforeach
 base_lib = static_library('qede_base', sources,
     dependencies: [static_rte_net, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/thunderx/base/meson.build +1 -1
index 704ee65771..cec45d0ae1 100644
@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources,
     dependencies: static_rte_ethdev
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/txgbe/base/meson.build +1 -1
index c6816b4279..7a30191472 100644
@@ -24,4 +24,4 @@ endforeach
 base_lib = static_library('txgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/raw/ifpga/base/meson.build +1 -1
index 8d27c60213..db602cee69 100644
@@ -40,4 +40,4 @@ ext_deps += rtdep
 base_lib = static_library('ifpga_rawdev_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)

--
2.32.0

#2 lore raw

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

Quoted 9 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:

From: Jerin Jacob <[email protected]>

Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

Quoted 6 lines

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?

Quoted 181 lines

---
v2..v1
- Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)

 drivers/common/sfc_efx/base/meson.build | 2 +-
 drivers/meson.build                     | 2 +-
 drivers/net/e1000/base/meson.build      | 2 +-
 drivers/net/fm10k/base/meson.build      | 2 +-
 drivers/net/hinic/base/meson.build      | 2 +-
 drivers/net/i40e/base/meson.build       | 2 +-
 drivers/net/ice/base/meson.build        | 2 +-
 drivers/net/igc/base/meson.build        | 2 +-
 drivers/net/ixgbe/base/meson.build      | 2 +-
 drivers/net/ngbe/base/meson.build       | 2 +-
 drivers/net/octeontx/base/meson.build   | 2 +-
 drivers/net/qede/base/meson.build       | 2 +-
 drivers/net/thunderx/base/meson.build   | 2 +-
 drivers/net/txgbe/base/meson.build      | 2 +-
 drivers/raw/ifpga/base/meson.build      | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)
drivers/common/sfc_efx/base/meson.build +1 -1
index 9fba47b1cc..ff7f33fb44 100644
@@ -86,7 +86,7 @@ if build
         dependencies: static_rte_eal,
         c_args: c_args)
 
-    base_objs = base_lib.extract_all_objects()
+    base_objs = base_lib.extract_all_objects(recursive: true)
 else
     base_objs = []
 endif
drivers/meson.build +1 -1
index bc6f4f567f..d9e331ec85 100644
@@ -160,7 +160,7 @@ foreach subpath:subdirs
                 include_directories: includes,
                 dependencies: static_deps,
                 c_args: cflags)
-        objs += tmp_lib.extract_all_objects()
+        objs += tmp_lib.extract_all_objects(recursive: true)
         sources = custom_target(out_filename,
                 command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen],
                 output: out_filename,
drivers/net/e1000/base/meson.build +1 -1
index 317692dfab..528a33f958 100644
@@ -35,4 +35,4 @@ endforeach
 base_lib = static_library('e1000_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/fm10k/base/meson.build +1 -1
index ca98d34d4e..bd19df27f7 100644
@@ -25,4 +25,4 @@ endforeach
 base_lib = static_library('fm10k_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/hinic/base/meson.build +1 -1
index a00c90c14e..3aa53df881 100644
@@ -34,4 +34,4 @@ c_args = cflags
 base_lib = static_library('hinic_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/i40e/base/meson.build +1 -1
index 79a887a297..d94108629b 100644
@@ -27,4 +27,4 @@ endforeach
 base_lib = static_library('i40e_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ice/base/meson.build +1 -1
index 3305e5dd18..30e251876d 100644
@@ -43,4 +43,4 @@ endforeach
 base_lib = static_library('ice_base', sources,
         dependencies: static_rte_eal,
         c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/igc/base/meson.build +1 -1
index 8affc72e65..f52421f7a9 100644
@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ixgbe/base/meson.build +1 -1
index 7d3cec002d..22972c6b56 100644
@@ -31,4 +31,4 @@ endforeach
 base_lib = static_library('ixgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ngbe/base/meson.build +1 -1
index a1a9c2ff65..6081281135 100644
@@ -18,4 +18,4 @@ c_args = cflags
 base_lib = static_library('ngbe_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/octeontx/base/meson.build +1 -1
index c86a726704..8e5e8c1b55 100644
@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources,
     dependencies: static_objs,
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/qede/base/meson.build +1 -1
index 614a0c3808..4ad177b478 100644
@@ -54,4 +54,4 @@ endforeach
 base_lib = static_library('qede_base', sources,
     dependencies: [static_rte_net, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/thunderx/base/meson.build +1 -1
index 704ee65771..cec45d0ae1 100644
@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources,
     dependencies: static_rte_ethdev
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/txgbe/base/meson.build +1 -1
index c6816b4279..7a30191472 100644
@@ -24,4 +24,4 @@ endforeach
 base_lib = static_library('txgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/raw/ifpga/base/meson.build +1 -2
index 8d27c60213..db602cee69 100644
@@ -40,4 +40,4 @@ ext_deps += rtdep
 base_lib = static_library('ifpga_rawdev_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
--

2.32.0

#3 lore raw

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

Quoted 18 lines · Bruce Richardson
Quoted 9 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:

From: Jerin Jacob <[email protected]>

Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

Quoted 6 lines

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

Quoted 3 lines

Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?

Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.

Quoted 182 lines
Quoted 182 lines

---
v2..v1
- Corrrect the meson version number in git commit log(0.46.0 to 0.59.0)

 drivers/common/sfc_efx/base/meson.build | 2 +-
 drivers/meson.build                     | 2 +-
 drivers/net/e1000/base/meson.build      | 2 +-
 drivers/net/fm10k/base/meson.build      | 2 +-
 drivers/net/hinic/base/meson.build      | 2 +-
 drivers/net/i40e/base/meson.build       | 2 +-
 drivers/net/ice/base/meson.build        | 2 +-
 drivers/net/igc/base/meson.build        | 2 +-
 drivers/net/ixgbe/base/meson.build      | 2 +-
 drivers/net/ngbe/base/meson.build       | 2 +-
 drivers/net/octeontx/base/meson.build   | 2 +-
 drivers/net/qede/base/meson.build       | 2 +-
 drivers/net/thunderx/base/meson.build   | 2 +-
 drivers/net/txgbe/base/meson.build      | 2 +-
 drivers/raw/ifpga/base/meson.build      | 2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)
drivers/common/sfc_efx/base/meson.build +1 -1
index 9fba47b1cc..ff7f33fb44 100644
@@ -86,7 +86,7 @@ if build
         dependencies: static_rte_eal,
         c_args: c_args)
 
-    base_objs = base_lib.extract_all_objects()
+    base_objs = base_lib.extract_all_objects(recursive: true)
 else
     base_objs = []
 endif
drivers/meson.build +1 -1
index bc6f4f567f..d9e331ec85 100644
@@ -160,7 +160,7 @@ foreach subpath:subdirs
                 include_directories: includes,
                 dependencies: static_deps,
                 c_args: cflags)
-        objs += tmp_lib.extract_all_objects()
+        objs += tmp_lib.extract_all_objects(recursive: true)
         sources = custom_target(out_filename,
                 command: [pmdinfo, tmp_lib.full_path(), '@OUTPUT@', pmdinfogen],
                 output: out_filename,
drivers/net/e1000/base/meson.build +1 -1
index 317692dfab..528a33f958 100644
@@ -35,4 +35,4 @@ endforeach
 base_lib = static_library('e1000_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/fm10k/base/meson.build +1 -1
index ca98d34d4e..bd19df27f7 100644
@@ -25,4 +25,4 @@ endforeach
 base_lib = static_library('fm10k_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/hinic/base/meson.build +1 -1
index a00c90c14e..3aa53df881 100644
@@ -34,4 +34,4 @@ c_args = cflags
 base_lib = static_library('hinic_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci, static_rte_hash],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/i40e/base/meson.build +1 -1
index 79a887a297..d94108629b 100644
@@ -27,4 +27,4 @@ endforeach
 base_lib = static_library('i40e_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ice/base/meson.build +1 -1
index 3305e5dd18..30e251876d 100644
@@ -43,4 +43,4 @@ endforeach
 base_lib = static_library('ice_base', sources,
         dependencies: static_rte_eal,
         c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/igc/base/meson.build +1 -1
index 8affc72e65..f52421f7a9 100644
@@ -16,4 +16,4 @@ base_lib = static_library('igc_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ixgbe/base/meson.build +1 -1
index 7d3cec002d..22972c6b56 100644
@@ -31,4 +31,4 @@ endforeach
 base_lib = static_library('ixgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/ngbe/base/meson.build +1 -1
index a1a9c2ff65..6081281135 100644
@@ -18,4 +18,4 @@ c_args = cflags
 base_lib = static_library('ngbe_base', sources,
     dependencies: [static_rte_eal, static_rte_ethdev, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/octeontx/base/meson.build +1 -1
index c86a726704..8e5e8c1b55 100644
@@ -22,4 +22,4 @@ base_lib = static_library('octeontx_base', sources,
     dependencies: static_objs,
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/qede/base/meson.build +1 -1
index 614a0c3808..4ad177b478 100644
@@ -54,4 +54,4 @@ endforeach
 base_lib = static_library('qede_base', sources,
     dependencies: [static_rte_net, static_rte_bus_pci],
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/thunderx/base/meson.build +1 -1
index 704ee65771..cec45d0ae1 100644
@@ -13,4 +13,4 @@ base_lib = static_library('nicvf_base', sources,
     dependencies: static_rte_ethdev
 )
 
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/net/txgbe/base/meson.build +1 -1
index c6816b4279..7a30191472 100644
@@ -24,4 +24,4 @@ endforeach
 base_lib = static_library('txgbe_base', sources,
     dependencies: static_rte_eal,
     c_args: c_args)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
drivers/raw/ifpga/base/meson.build +1 -2
index 8d27c60213..db602cee69 100644
@@ -40,4 +40,4 @@ ext_deps += rtdep
 base_lib = static_library('ifpga_rawdev_base', sources,
     dependencies: static_rte_eal,
     c_args: cflags)
-base_objs = base_lib.extract_all_objects()
+base_objs = base_lib.extract_all_objects(recursive: true)
--

2.32.0

#4 lore raw

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

17/08/2021 14:54, Jerin Jacob:

Quoted 20 lines
Quoted 18 lines · Bruce Richardson
Quoted 15 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:

From: Jerin Jacob <[email protected]>

Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

Quoted 6 lines
Quoted 3 lines

Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?

Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.

Bruce, are you OK with the change?

#5 lore raw

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

Quoted 21 lines · Thomas Monjalon

17/08/2021 14:54, Jerin Jacob:

Quoted 20 lines
Quoted 18 lines · Bruce Richardson
Quoted 15 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:

From: Jerin Jacob <[email protected]>

Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?

Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.

Bruce, are you OK with the change?

Yes.

#6 lore raw

Re: [dpdk-dev] [PATCH v2] drivers: remove warning with meson 0.59.0

27/08/2021 14:55, Bruce Richardson:

Quoted 26 lines · Thomas Monjalon
Quoted 25 lines

17/08/2021 14:54, Jerin Jacob:

Quoted 24 lines
Quoted 21 lines · Bruce Richardson
Quoted 9 lines · On Fri, Jul 30, 2021 at 01:05:48PM +0530, [email protected] wrote:

From: Jerin Jacob <[email protected]>

Since meson 0.59.0 version, the extract_all_objects() API need to pass explicit boolean value.

To remove the following warning[1], added explicit true for extract_all_objects() use in codebase whever there is no argument.

Quoted 6 lines

[1]
WARNING: extract_all_objects called without setting recursive keyword argument. Meson currently defaults to non-recursive to maintain backward compatibility but the default will be changed in the future.

Technically this is changing the default behaviour since it previously defaulted to "false". However, since there should be no recursion involved here anyway, I don't think it matters, correct?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Yes. To be on the safer side, I just put "true" in case some drivers using for a recursive way.

Bruce, are you OK with the change?

Yes.

Applied, thanks.