Skip to contentSkip to conversation

drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt()

PATCH Superseded Markus Elfring 3 participants 4 messages Feb 5, 2024 – Feb 6, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt()

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 08:58:21 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

---
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +1 -2
index 566de4658719..1edf429c49d7 100644
@@ -834,8 +834,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
 		return PTR_ERR(ctx->pclk);
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ctx->base = devm_ioremap_resource(&pdev->dev, res);
+	ctx->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(ctx->base)) {
 		DRM_ERROR("failed to remap dsi io region\n");
 		return PTR_ERR(ctx->base);

--
2.43.0

reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 08:58:21 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

I no longer have hardware to test with this, but this looks reasonable to me.

thanks
-john

Reviewed-by on v1 1/1
#2 lore raw
In reply to Markus Elfring

Hi,

Quoted 20 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Mon, 5 Feb 2024 08:58:21 +0100

A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6 ("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.

This issue was detected by using the Coccinelle software.

---
 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +0 -0
index 566de4658719..1edf429c49d7 100644

drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi) · line 840

Quoted 9 lines
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +1 -2
@@ -834,8 +834,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
                return PTR_ERR(ctx->pclk);
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ctx->base = devm_ioremap_resource(&pdev->dev, res);
+       ctx->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
        if (IS_ERR(ctx->base)) {
                DRM_ERROR("failed to remap dsi io region\n");
                return PTR_ERR(ctx->base);

This function no longer needs the local variable "res". Remove it and then change the function call to devm_platform_ioremap_resource(). With that:

#3 lore raw

PATCH v2 1/1 drm/hisilicon: Use devm_platform_ioremap_resource() in dsi_parse_dt()

From: Markus Elfring <[email protected]>
Date: Tue, 6 Feb 2024 19:51:25 +0100

A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 ("drivers: provide devm_platform_ioremap_resource()").

* Thus reuse existing functionality instead of keeping duplicate source code.

* Delete a local variable which became unnecessary with this refactoring.

This issue was transformed by using the Coccinelle software.

---

v2:
The transformation pattern was adjusted based on advices by known contributors.

Examples:
* Douglas Anderson
* Geert Uytterhoeven
* Robin Murphy

 drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +1 -3
index 566de4658719..6db6f355394c 100644
@@ -826,7 +826,6 @@ static const struct component_ops dsi_ops = {
 static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
 {
 	struct dsi_hw_ctx *ctx = dsi->ctx;
-	struct resource *res;
 
 	ctx->pclk = devm_clk_get(&pdev->dev, "pclk");
 	if (IS_ERR(ctx->pclk)) {
@@ -834,8 +833,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
 		return PTR_ERR(ctx->pclk);
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	ctx->base = devm_ioremap_resource(&pdev->dev, res);
+	ctx->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ctx->base)) {
 		DRM_ERROR("failed to remap dsi io region\n");
 		return PTR_ERR(ctx->base);

--
2.43.0