Skip to contentSkip to conversation

hangcheck-timer: Update to 0.9.0.

PATCH Arjan van de Ven 2 participants 2 messages May 1, 2005 – May 2, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Review

Quoted 4 lines
(quoted diff) +4 -0
+
+#if defined(CONFIG_X86) || defined(CONFIG_X86_64)
+# define HAVE_MONOTONIC
+# define TIMER_FREQ 1000000000ULL

this looks wrong!

does this work with HZ=100 ?
also there is a TSC config option which you want to use most likely instead of CONFIG_X86 (and x86-64 has CONFIG_X86 defined too)

#2 lore raw
Quoted 10 lines · Arjan van de Ven

Review

Quoted 4 lines
(quoted diff) +4 -0
+
+#if defined(CONFIG_X86) || defined(CONFIG_X86_64)
+# define HAVE_MONOTONIC
+# define TIMER_FREQ 1000000000ULL

this looks wrong!

does this work with HZ=100 ?
also there is a TSC config option which you want to use most likely instead of CONFIG_X86 (and x86-64 has CONFIG_X86 defined too)

It is right, though. monotonic_clock() is defined as returning
nanoseconds, not a value based on HZ. It's supported on x86 and x86-64, hence using CONFIG_X86 to check. Someday, John will get it implemented for the other platforms, and we'll have less mess in hangcheck-timer.c. He already thinks that he should have the prototype in timer.h or so (so I don't have to extern declare it), but he hasn't gotten around to it yet.

Joel

Signature · 9 lines
Life's Little Instruction Book #30

	"Never buy a house without a fireplace."

Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: [email protected]
Phone: (650) 506-8127