hangcheck-timer: Update to 0.9.0.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Review
Quoted 4 lines
(quoted diff) +4
-0+ +#if defined(CONFIG_X86) || defined(CONFIG_X86_64) +# define HAVE_MONOTONIC +# define TIMER_FREQ 1000000000ULL
this looks wrong!
does this work with HZ=100 ?
also there is a TSC config option which you want to use most likely instead of CONFIG_X86 (and x86-64 has CONFIG_X86 defined too)
Quoted 10 lines · Arjan van de Ven
Review
Quoted 4 lines
(quoted diff) +4
-0+ +#if defined(CONFIG_X86) || defined(CONFIG_X86_64) +# define HAVE_MONOTONIC +# define TIMER_FREQ 1000000000ULLthis looks wrong!
does this work with HZ=100 ?
also there is a TSC config option which you want to use most likely instead ofCONFIG_X86(and x86-64 hasCONFIG_X86defined too)
It is right, though. monotonic_clock() is defined as returning
nanoseconds, not a value based on HZ. It's supported on x86 and x86-64, hence using CONFIG_X86 to check. Someday, John will get it implemented for the other platforms, and we'll have less mess in hangcheck-timer.c. He already thinks that he should have the prototype in timer.h or so (so I don't have to extern declare it), but he hasn't gotten around to it yet.
Joel
Signature · 9 lines
Life's Little Instruction Book #30 "Never buy a house without a fireplace." Joel Becker Senior Member of Technical Staff Oracle E-mail: [email protected] Phone: (650) 506-8127