Skip to contentSkip to conversation

ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()

PATCH In review Markus Elfring 2 participants 2 messages Nov 9, 2019 – Nov 11, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()

From: Markus Elfring <[email protected]>
Date: Sat, 9 Nov 2019 17:19:35 +0100

A coccicheck run provided information like the following.

arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device; call of_find_device_by_node on line 258, but without a corresponding object release within this function.

Generated by: scripts/coccinelle/free/put_device.cocci

Thus add the missed function call to fix the exception handling for this function implementation.

Fixes e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver")
---
 arch/arm/mach-omap2/display.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap2/display.c +1 -0
index 439e143cad7b..46012ca812f4 100644
@@ -265,6 +265,7 @@ static int __init omapdss_init_of(void)
 	r = of_platform_populate(node, NULL, NULL, &pdev->dev);
 	if (r) {
 		pr_err("Unable to populate DSS submodule devices\n");
+		put_device(&pdev->dev);
 		return r;
 	}
 

--
2.24.0

maintainer
#1 lore raw
Quoted 5 lines · Markus Elfring

From: Markus Elfring <[email protected]>
Date: Sat, 9 Nov 2019 17:19:35 +0100

A coccicheck run provided information like the following.

Quoted 8 lines

arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device; call of_find_device_by_node on line 258, but without a corresponding object release within this function.

Generated by: scripts/coccinelle/free/put_device.cocci

Thus add the missed function call to fix the exception handling for this function implementation.

Thanks applying into omap-for-v5.5/soc.

Tony