Skip to contentSkip to conversation

dom0_ops -EPERM not -EACCES?

PATCH New Rusty Russell 1 participant 1 message Nov 24, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dom0_ops -EPERM not -EACCES?

Hi all,

dom0_ops return -EACCES when the interface version in wrong. I think
that an acm failure is closer to being non-priv'ed, which returns -EPERM. Wouldn't want dom0 tools to report they were the wrong version just because ACM limited some operation, surely?

xen/common/dom0_ops.c +1 -1
diff -r e2d1c88d50f7 xen/common/dom0_ops.c
@@ -102,7 +102,7 @@
         return -EACCES;
 
     if ( acm_pre_dom0_op(op, &ssid) )
-        return -EACCES;
+        return -EPERM;
 
     spin_lock(&dom0_lock);
 
Signature · 1 line
A bad analogy is like a leaky screwdriver -- Richard Braakman