Skip to contentSkip to conversation

drivers/net/wireless/ipw2200.c: fix an array overun

PATCH Applied Adrian Bunk 3 participants 3 messages Mar 11, 2006 – Mar 18, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/wireless/ipw2200.c: fix an array overun

This patch fixes a big array overun found by the Coverity checker.

drivers/net/wireless/ipw2200.c renamed from drivers/net/wireless/ipw2200.c.old +2 -3
@@ -9956,9 +9956,8 @@ static int ipw_ethtool_set_eeprom(struct
 		return -EINVAL;
 	mutex_lock(&p->mutex);
 	memcpy(&p->eeprom[eeprom->offset], bytes, eeprom->len);
-	for (i = IPW_EEPROM_DATA;
-	     i < IPW_EEPROM_DATA + IPW_EEPROM_IMAGE_SIZE; i++)
-		ipw_write8(p, i, p->eeprom[i]);
+	for (i = 0; i < IPW_EEPROM_IMAGE_SIZE; i++)
+		ipw_write8(p, i + IPW_EEPROM_DATA, p->eeprom[i]);
 	mutex_unlock(&p->mutex);
 	return 0;
 }
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Adrian Bunk

This patch fixes a big array overun found by the Coverity checker.

drivers/net/wireless/ipw2200.c renamed from drivers/net/wireless/ipw2200.c.old +0 -0
@@ -9956,9 +9956,8 @@ static int ipw_ethtool_set_eeprom(struct
 		return -EINVAL;

drivers/net/wireless/ipw2200.c static int ipw_ethtool_set_eeprom(struct · line 9963

Quoted 10 lines
drivers/net/wireless/ipw2200.c renamed from drivers/net/wireless/ipw2200.c.old +2 -3
 	mutex_lock(&p->mutex);
 	memcpy(&p->eeprom[eeprom->offset], bytes, eeprom->len);
-	for (i = IPW_EEPROM_DATA;
-	     i < IPW_EEPROM_DATA + IPW_EEPROM_IMAGE_SIZE; i++)
-		ipw_write8(p, i, p->eeprom[i]);
+	for (i = 0; i < IPW_EEPROM_IMAGE_SIZE; i++)
+		ipw_write8(p, i + IPW_EEPROM_DATA, p->eeprom[i]);
 	mutex_unlock(&p->mutex);
 	return 0;
 }

Thanks,
-yi