drivers/net/wireless/ipw2200.c: fix an array overun
Subsystems (3)
PATCH 1/1 drivers/net/wireless/ipw2200.c: fix an array overun
This patch fixes a big array overun found by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>
drivers/net/wireless/ipw2200.c renamed from drivers/net/wireless/ipw2200.c.old +2 -3
@@ -9956,9 +9956,8 @@ static int ipw_ethtool_set_eeprom(structreturn -EINVAL ;mutex_lock (&p->mutex);memcpy (&p->eeprom[eeprom->offset], bytes, eeprom->len); -for (i =IPW_EEPROM_DATA ; - i <IPW_EEPROM_DATA +IPW_EEPROM_IMAGE_SIZE ; i++) -ipw_write8 (p, i, p->eeprom[i]); +for (i =0 ; i <IPW_EEPROM_IMAGE_SIZE ; i++) +ipw_write8 (p, i +IPW_EEPROM_DATA , p->eeprom[i]);mutex_unlock (&p->mutex);return 0 ; }
Quoted 9 lines · Adrian Bunk
This patch fixes a big array overun found by the Coverity checker.
Signed-off-by Adrian Bunk <[email protected]>drivers/net/wireless/ipw2200.c renamed from drivers/net/wireless/ipw2200.c.old +0
-0@@ -9956,9 +9956,8 @@ static int ipw_ethtool_set_eeprom(structreturn -EINVAL ;
drivers/net/wireless/ipw2200.c static int ipw_ethtool_set_eeprom(struct · line 9963
Quoted 10 lines
drivers/net/wireless/ipw2200.c renamed from drivers/net/wireless/ipw2200.c.old +2
-3mutex_lock (&p->mutex);memcpy (&p->eeprom[eeprom->offset], bytes, eeprom->len); -for (i =IPW_EEPROM_DATA ; - i <IPW_EEPROM_DATA +IPW_EEPROM_IMAGE_SIZE ; i++) -ipw_write8 (p, i, p->eeprom[i]); +for (i =0 ; i <IPW_EEPROM_IMAGE_SIZE ; i++) +ipw_write8 (p, i +IPW_EEPROM_DATA , p->eeprom[i]);mutex_unlock (&p->mutex);return 0 ; }
Acked-by Zhu Yi <[email protected]>
Thanks,
-yi
John W. Linville
AppliedQuoted 1 line · Adrian Bunk
This patch fixes a big array overun found by the Coverity checker.
Merged to upstream branch of wireless-2.6...thanks!
John
Signature · 2 lines
John W. Linville [email protected]