Remove Obsolete startNow() Method
PATCH 1/1 Remove Obsolete startNow() Method
Hi,
This patch removes the startNow() method from the XmTestDomain object. At one time, xm-test needed to wait for a domain to boot. There were two different methods: start, which did a wait, and startNow, which didn't wait. The wait was removed (except for HVM domains), so there's no difference between start and startNow(). Better to remove it.
Thanks,
Dan
# HG changeset patch
# User [email protected] # Node ID f3f82890c4fc0a7c88ef76a26efb0e2f818df134 # Parent 1569bc48b0b8cbe7504c225752f7d36b8df2e537
Remove obsolete startNow() method from XmTestDomain object.
Signed-off-by Daniel Stekloff <[email protected]>
tools/xm-test/lib/XmTestLib/XenDomain.py +0 -3
@@ -251,9 +251,6 @@ class XmTestDomain(XenDomain): if ENABLE_HVM_SUPPORT: waitForBoot() - def startNow(self): - XenDomain.start(self) - def minSafeMem(self): return 16
tools/xm-test/tests/create/10_create_fastdestroy.py +1 -1
@@ -28,7 +28,7 @@ for i in range(0,50): for i in range(0,50): domain = XmTestDomain("testdomain") try: - domain.startNow() + domain.start() except DomainError,e: print "Failed: " + e.extra NSPerror = check_for_NSP_error(e.extra)
tools/xm-test/tests/destroy/07_destroy_stale_pos.py +11 -20
@@ -101,29 +101,24 @@ def test_sysrq(name): if not re.search("[Ee]rror", output): FAIL("sysrq failed to report error after destroy!") -def runTests(tests, wait): +def runTests(tests): for test in tests: domain = XmTestDomain() # Create a domain try: - if wait: - domain.start() - else: - domain.startNow() + domain.start() except DomainError, e: FAIL(str(e)) - - if wait: - # Attach a console and make sure it's live - try: - console = XmConsole(domain.getName()) - console.sendInput("foo") - console.runCmd("ls") - except ConsoleError, e: - FAIL(str(e)) + # Attach a console and make sure it's live + try: + console = XmConsole(domain.getName()) + console.sendInput("foo") + console.runCmd("ls") + except ConsoleError, e: + FAIL(str(e)) # Destroy it
@@ -137,9 +132,5 @@ tests = [test_mem_set, test_pause, test_ test_block_list, test_shutdown, test_domid, test_domname] if verbose: - print "Running stale tests (nice mode)" -runTests(tests, True) - -if verbose: - print "Running stale tests (mean mode)" -runTests(tests, False) + print "Running stale tests" +runTests(tests)
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel