IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags
PATCH 1/1 IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags
IRQ_PER_CPU is a bit in the struct irq_desc "status" field, not in the struct irqaction "flags", so the previous code checked the wrong bit.
SA_PERCPU_IRQ is only used by drivers/char/mmtimer.c for SGI ia64 boxes.
Signed-off-by Bjorn Helgaas <[email protected]>
kernel/irq/manage.c +2 -1
@@ -237,7 +237,8 @@#if defined(CONFIG_IRQ_PER_CPU ) && defined(SA_PERCPU_IRQ )/* All handlers must agree on per-cpuness */ -if ((old->flags &IRQ_PER_CPU ) != (new->flags &IRQ_PER_CPU )) +if ((old->flags &SA_PERCPU_IRQ ) != + (new->flags &SA_PERCPU_IRQ )) goto mismatch;#endif
Quoted 7 lines · Bjorn Helgaas
IRQ_PER_CPUis a bit in the structirq_desc"status" field, not in the struct irqaction "flags", so the previous code checked the wrong bit.
SA_PERCPU_IRQis only used bydrivers/char/mmtimer.cfor SGI ia64 boxes.Signed-off-by Bjorn Helgaas <[email protected]>
Doh, good catch.
Acked-by Thomas Gleixner <[email protected]>