Skip to contentSkip to conversation

IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags

PATCH In review Bjorn Helgaas 2 participants 2 messages Jun 30, 2006 IRQ

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IRQ: Use SA_PERCPU_IRQ, not IRQ_PER_CPU, for irqaction.flags

IRQ_PER_CPU is a bit in the struct irq_desc "status" field, not in the struct irqaction "flags", so the previous code checked the wrong bit.

SA_PERCPU_IRQ is only used by drivers/char/mmtimer.c for SGI ia64 boxes.

kernel/irq/manage.c +2 -1
Index: work-mm7/kernel/irq/manage.c
===================================================================
@@ -237,7 +237,8 @@
 
 #if defined(CONFIG_IRQ_PER_CPU) && defined(SA_PERCPU_IRQ)
 		/* All handlers must agree on per-cpuness */
-		if ((old->flags & IRQ_PER_CPU) != (new->flags & IRQ_PER_CPU))
+		if ((old->flags & SA_PERCPU_IRQ) !=
+		    (new->flags & SA_PERCPU_IRQ))
 			goto mismatch;
 #endif