Skip to contentSkip to conversation

Add start-of-day setup hooks to subarch

RFC PATCH Randy Dunlap 1 participant 1 message Jul 18, 2006

lore
Share & tools
lore
#0 lore raw
Quoted 27 lines · Chris Wright
Quoted 17 lines

plain text document attachment (i386-setup)
Implement the start-of-day subarchitecture setup hooks for booting on Xen. Add subarch macros for determining loader type and initrd location.

diff -r a5848bce3730 arch/i386/kernel/setup.c

arch/i386/kernel/setup.c +1 -0
@@ -458,6 +458,7 @@ static void __init print_memory_map(char
 	}
 }
 
+#ifndef HAVE_ARCH_E820_SANITIZE
 /*
  * Sanitize the BIOS e820 map.
  *

arch/i386/kernel/setup.c int __init copy_e820_map(struct e820entr · line 682

Quoted 5 lines
arch/i386/kernel/setup.c +1 -0
@@ -677,6 +678,7 @@ int __init copy_e820_map(struct e820entr
 	} while (biosmap++,--nr_map);
 	return 0;
 }
+#endif
 

Hi,

Quoted 3 lines

what is this for? Isn't this 1) undocumented and 2) unclear and 3) ugly ? (I'm pretty sure the HAVE_ARCH_* stuff is highly deprecated for new things nowadays)

I've read that Linus doesn't like it (putting it mildly), but deprecated?? Yes, there are better/other ways.

---
~Randy